Subject: [PATCH] ohci-ssb with !CONFIG_PM -

From: Rob Landley <rob@landley.net> Jens Axboe's old email address bounces. Signed-off-by: Rob Landley <rob@landley.net> --- He's emailing from oracle.com these days, and the old one bounced with: <axboe@suse.de>: host mx2.suse.de[195.135.220.15] said: 550 <axboe@suse.de>:     Recipient address rejected: User has moved to <unknown> (in reply to RCPT     TO command) Documentation/DMA-mapping.txt | 2 +- Documentation/HOWTO | 2 +- ...

Could you try: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/linux-2.6-lockdep.git v2.6.24-lockdep on top of current -linus, I just pushed out the patch that should fix it: lockdep: per filesystem inode lock class (still hasn't replicated though, so might take a while) -

I've got a deja-vu feeling for this one but in any case: [ 7393.894980] ======================================================= [ 7393.895081] [ INFO: possible circular locking dependency detected ] [ 7393.895130] 2.6.23.1 #2 [ 7393.895175] ------------------------------------------------------- [ 7393.895225] moo/28246 is trying to acquire lock: [ 7393.895275] (tty_mutex){--..}, at: [<c1231f9f>] mutex_lock+0x8/0xa [ 7393.895486] [ 7393.895487] but task is already holding lock: [ ...

ohci_bus_{suspend,resume} exists only if we have CONFIG_PM; do the same thing as other subdrivers... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- b0b4f616f9ca381aa6a8559923137ce7cadc4108 diff --git a/drivers/usb/host/ohci-ssb.c b/drivers/usb/host/ohci-ssb.c index bc3e785..fe70e72 100644 --- a/drivers/usb/host/ohci-ssb.c +++ b/drivers/usb/host/ohci-ssb.c @@ -117,8 +117,10 @@ static const struct hc_driver ssb_ohci_hc_driver = { .hub_status_data = ohci_hub_status_data, ...

> Roland, thanks for providing this. I have some of those already, but I > really appreciate the help. I take yours and the previously posted and > push them out into a cleanup branch on my x86 git tree. No problem, this merging work is the perfect thing when I need a break-- mindless enough to be relaxing, but useful enough that I don't feel guilty... Anyway, I assume you meant to write "I [will] take yours", since I don't see anything at all in tglx/linux-2.6-x86.git right now. ...

Roland, thanks for providing this. I have some of those already, but I really appreciate the help. I take yours and the previously posted and push them out into a cleanup branch on my x86 git tree. I guess it will be unavoidable that there will be some overlap on the low hanging fruit merges, but anyone who is tackling a more complex one should make this public upfront so we can avoid the redundant work. Thanks, tglx -

Currently, evdev has working 32bit compatibility and uinput does not. uinput needs the input_event code that evdev uses, so let's refactor it so it can be shared. Signed-off-by: Philip Langdale <philipl@overt.org> --- drivers/input/Makefile | 2 drivers/input/evdev.c | 118 ++----------------------------------------- drivers/input/input_compat.c | 89 ++++++++++++++++++++++++++++++++ drivers/input/misc/uinput.c | 23 ++++++-- include/linux/input_compat.h | 61 ...

Yeah. It was that one. I cut and pasted the wrong one for the comment. Thanks, Shaggy -- David Kleikamp IBM Linux Technology Center -

Hi, There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23): <4>sysfs: duplicate filename 'ethxx1' can not be created WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one() Call Trace: [<ffffffff802d1532>] sysfs_add_one+0x5c/0xc9 [<ffffffff802d2411>] sysfs_create_link+0xd1/0x12c [<ffffffff803756da>] device_rename+0x17a/0x1db [<ffffffff803c903d>] dev_change_name+0x114/0x20c [<ffffffff803c9339>] dev_ifsioc+0x204/0x2d0 ...

Kill two never-used (not even in hidden debug macros) variables, noticed by the compiler. Signed-off-by: Jeff Garzik <jgarzik@redhat.com> --- drivers/dma/ioatdma.c | 1 - drivers/pci/hotplug/pci_hotplug_core.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/dma/ioatdma.c b/drivers/dma/ioatdma.c index 41b18c5..d9db64b 100644 --- a/drivers/dma/ioatdma.c +++ b/drivers/dma/ioatdma.c @@ -244,7 +244,6 @@ static void ioat_dma_free_chan_resources(struct ...

The recent bio work and subsequent fixups created unused variables. Signed-off-by: Jeff Garzik <jgarzik@redhat.com> --- drivers/block/cciss.c | 1 - drivers/block/cpqarray.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 28d1457..27401d6 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -1191,7 +1191,6 @@ static inline void complete_buffers(struct bio *bio, int status) { while (bio) ...

... and yes, caller wants it to return int. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/drivers/isdn/hisax/elsa.c b/drivers/isdn/hisax/elsa.c index 0c1351b..948a9b2 100644 --- a/drivers/isdn/hisax/elsa.c +++ b/drivers/isdn/hisax/elsa.c @@ -1088,7 +1088,7 @@ setup_elsa_pci(struct IsdnCard *card) #else -static void __devinit +static int __devinit setup_elsa_pci(struct IsdnCard *card) { return (1); -

Nak, this patch should be used to fix it instead. A change to lite5200 got dropped during merging. http://patchwork.ozlabs.org/linuxppc/patch?id=14077 Cheers, -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195 -

Fine by me. -

There is an xt_TCPOPTSTRIP module in the works that allows you to strip Window Scaling only on the connections you want (rather than globally); seems to be in for 2.6.24 at earliest, though it's there is also the standalone patch. -

--=-rRMR6Xk/g54HVGki4B4P Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello, all on the list. Please CC me in answers, I'm not subscribed. Please, if this is wrong list tell me what is correct. Starting with 2.6.21 (or may be 2.6.20 as I have not tried it) kernel I have problem that most tcp based services freeze at some point of operation. I've noticed this first on ssh but then found out that at lease one other service became similarly. The problem sites ...

[ 9158.155844] JFS: nTxBlock = 8192, nTxLock = 65536 [ 9159.199567] BUG at fs/jfs/jfs_logmgr.c:2333 assert(bp->l_flag & lbmRELEASE) [ 9159.206566] ------------[ cut here ]------------ [ 9159.211189] kernel BUG at fs/jfs/jfs_logmgr.c:2333! [ 9159.216066] invalid opcode: 0000 [1] SMP [ 9159.220108] CPU 2 [ 9159.222144] Modules linked in: jfs loop [ 9159.226034] Pid: 0, comm: swapper Not tainted 2.6.23-git3 #1 [ 9159.231688] RIP: 0010:[<ffffffff8801e39c>] [<ffffffff8801e39c>] ...

I don't have time to test this now, but the bio_endio patches ended up removing some return statements that need to stay. I think this should fix it. JFS: Bio cleanup: Replace missing return statements commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;" statements, rather than changing them to null returns. Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index ccfd029..15a3974 100644 --- ...

Hi all, Was having trouble with the latest source-in compiling it and did an mrproper which fixed things...well-temporarily. I was hitting another issue with permissions-as root :( I was surprised and did an ls -l on the files and guess what I found: total 0 ?--------- ? ? ? ? ? fcntl.c ?--------- ? ? ? ? ? fifo.c ?--------- ? ? ? ? ? filesystems.c ?--------- ? ? ? ? ? file_table.c ?--------- ? ? ? ? ? ...

The exception path associated with an invalid ext_csd_struct returns without freeing ext_csd. Coverity CID 1909. Signed-off-by: Florin Malita --- drivers/mmc/core/mmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 65fe288..68c0e3b 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -213,7 +213,8 @@ static int mmc_read_ext_csd(struct mmc_card *card) printk(KERN_ERR "%s: unrecognised ...

pmac_ide_init_hwif_ports() is also called by ide_init_hwif_ports() through ppc_ide_md.init_hwif. Bart -

Which is zero.. See the problem ? Alan -

Proposed addition to icside part, provided that ARM folks ACK it - gets icside to build and AFAICS it's correct: diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c index be30923..842fe08 100644 --- a/drivers/ata/pata_icside.c +++ b/drivers/ata/pata_icside.c @@ -332,12 +332,13 @@ static void ata_dummy_noret(struct ata_port *port) { } -static void pata_icside_postreset(struct ata_port *ap, unsigned int *classes) +static void pata_icside_postreset(struct ata_link *link, ...

Hi Alan, Comment in pmac_ide_init_hwif_ports() is highly misleading as this function returns early only for "normal" IDE PCI devices (pmac_ide_init_hwif_ports() can be called outside ide-pmac driver through ppc_ide_md). static int __devinit pmac_ide_pci_attach(struct pci_dev *pdev, const struct pci_device_id *id) { ... pmif = &pmac_ide[i]; ... pmif->regbase = (unsigned long) base + 0x2000; ... rc = pmac_ide_setup_device(pmif, hwif); ... } static ...

Hi, It's somewhat needed, but nobody has gotten around to actually implement it yet... bye, Roman -

commit 60187d2708caa870f0825d753df1612ea688eb9e in mainline. Spotted by taoyue <yue.tao@windriver.com> and Jeremy Katz <jeremy.katz@windriver.com>. collect_signal: sigqueue_free: list_del_init(&first->list); if (!list_empty(&q->list)) { // not taken } q->flags &= ~SIGQUEUE_PREALLOC; __sigqueue_free(first); __sigqueue_free(q); Now, __sigqueue_free() is called twice on the same "struct sigqueue" with the obviously bad implications. In particular, this ...

Both cx23885_initdev and cx23885_dev_setup free the device in their error path so a failure in the latter causes a double-free. Since cx23885_dev_setup is only called from cx23885_initdev, it should be safe to remove its deallocation and leave the cleanup up to the allocating function. Coverity CID 1922. Signed-off-by: Florin Malita <fmalita@gmail.com> --- drivers/media/video/cx23885/cx23885-core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git ...

This fixes the following bug reported in syslog: [ 4039.051658] BUG: sleeping function called from invalid context at /usr/src/davem-2.6/mm/slab.c:3032 [ 4039.051668] in_atomic():1, irqs_disabled():0 [ 4039.051670] INFO: lockdep is turned off. [ 4039.051674] [<c0104c0f>] show_trace_log_lvl+0x1a/0x30 [ 4039.051687] [<c0104d4d>] show_trace+0x12/0x14 [ 4039.051691] [<c0104d65>] dump_stack+0x16/0x18 [ 4039.051695] [<c011371e>] __might_sleep+0xaf/0xbe [ 4039.051700] [<c0157b66>] ...

commit 49af7ee181f4f516ac99eba85d3f70ed42cabe76 in mainline. NFS unregisters sysctls only if V4 support is compiled in. However, sysctl table is not V4 specific, so unregister it always. Steps to reproduce: [build nfs.ko with CONFIG_NFS_V4=n] modrobe nfs rmmod nfs ls /proc/sys Unable to handle kernel paging request at ffffffff880661c0 RIP: [<ffffffff802af8e3>] proc_sys_readdir+0xd3/0x350 PGD 203067 PUD 207063 PMD 7e216067 PTE 0 Oops: 0000 [1] SMP CPU 1 Modules linked in: lockd ...

commit ef8aef55ce61fd0e2af798695f7386ac756ae1e7 in mainline Subject: [2.6.20.21 review 34/35] [PATCH] [NET]: Do not dereference iov if length is zero When msg_iovlen is zero we shouldn't try to dereference msg_iov. Right now the only thing that tries to do so is skb_copy_and_csum_datagram_iovec. Since the total length should also be zero if msg_iovlen is zero, it's sufficient to check the total length there and simply return if it's zero. Signed-off-by: Herbert Xu ...

commit 179c85ea53bef807621f335767e41e23f86f01df in mainline. The futex list traversal on the compat side appears to have a bug. It's loop termination condition compares: while (compat_ptr(uentry) != &head->list) But that can't be right because "uentry" has the special "pi" indicator bit still potentially set at bit 0. This is cleared by fetch_robust_entry() into the "entry" return value. What this seems to mean is that the list won't terminate when list iteration gets back ...

commit 3ef9d943d26dea764f4fecf3767001c90b778b0c in mainline Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- net/ipv6/raw.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) Index: 2.6/net/ipv6/raw.c =================================================================== --- 2.6.orig/net/ipv6/raw.c +++ 2.6/net/ipv6/raw.c @@ -851,11 +851,10 @@ back_from_confirm: ...

This corresponds to upstream changesets e4630f9fd8cdc14eb1caa08dafe649eb5ae09985 and 32528d0fbda1093eeeaa7d0a2c498bbb5154099d. [CRYPTO] blkcipher: Fix handling of kmalloc page straddling The function blkcipher_get_spot tries to return a buffer of the specified length that does not straddle a page. It has an off-by-one bug so it may advance a page unnecessarily. What's worse, one of its callers doesn't provide a buffer that's sufficiently long for this operation. This patch fixes both ...

commit 3d82abae9523c33d4a16fdfdfd2bdde316d7b56a in mainline. Convert asserts (BUGs) in dx_probe from bad on-disk data to recoverable errors with helpful warnings. With help catching other asserts from Duane Griffin <duaneg@dghda.com> Signed-off-by: Eric Sandeen <sandeen@redhat.com> Acked-by: Duane Griffin <duaneg@dghda.com> Acked-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds ...

The snap_rcv code reads 5 bytes so we should make sure that we have 5 bytes in the head before proceeding. Based on diagnosis and fix by Evgeniy Polyakov, reported by Alan J. Wylie. Patch also kills the skb->sk assignment before kfree_skb since it's redundant. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- net/802/psnap.c | 17 ++++++++++++----- 1 files changed, 12 ...

(cherry picked from commit 48200baeab95fd39a7f4c4f3536c7142a64ac335) [PATCH] V4L: cx88: Avoid a NULL pointer dereference during mpeg_open() Bug: With a hardware encoder board installed as cx88[1] and a non-encoder boards installed as cx88[0], an OOPS is generated during cx8802_get_device() called from mpeg_open(). Signed-off-by: Steven Toth <stoth@hauppauge.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> Signed-off-by: ...

Use seq_file for the proc file read/write of snd-page-alloc module. This automatically fixes bugs in the old proc code. Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> --- sound/core/memalloc.c | 68 ++++++++++++++++++++++++++++--------------------- 1 files changed, 39 insertions(+), 29 deletions(-) Index: 2.6/sound/core/memalloc.c =================================================================== --- ...

From: Jan Beulich <jbeulich@novell.com> Signed-off-by: Jan Beulich <jbeulich@novell.com> Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- arch/i386/kernel/sysenter.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) Index: 2.6/arch/i386/kernel/sysenter.c =================================================================== --- 2.6.orig/arch/i386/kernel/sysenter.c +++ 2.6/arch/i386/kernel/sysenter.c @@ -183,7 +183,9 @@ struct ...

I discussed this issue with Ilpo just yesterday regarding 2.6.16, and the result of our discussion was that I reverted it. TCP being in some situations a bit more conservative than it should be isn't a big issue and not worth backporting with a risk of introducing a regression. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. ...

Hi Ilpo, Thanks for your help, I really appreciate it. In fact, I've reviewed them four, but two of them did not apply and the code looked somewhat different, so I considered them irrelevant to 2.6.20. I didn't understand that they were all related, so maybe I checked them in a wrong order. I'll recheck all that in the right sequence and will merge them four, or get back to you if something still puzzles me. Thanks! Willy -

the pwc driver has a disconnect method that waits for user space to close the device. This opens up an opportunity for a DoS attack, blocking the USB subsystem and making khubd's task busy wait in kernel space. This patch shifts freeing resources to close if an opened device is disconnected. Signed-off-by: Oliver Neukum <oneukum@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/media/video/pwc/pwc-if.c | 52 +++++++++++++++++++++++++------------ ...

It didn't handle that case at all, and now dump_stack() can be implemented directly as show_stack(current, NULL) Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- arch/sparc64/kernel/traps.c | 18 +++++++++++------- arch/sparc64/mm/fault.c | 5 +---- 2 files changed, 12 insertions(+), 11 deletions(-) Index: 2.6/arch/sparc64/kernel/traps.c =================================================================== --- ...

Author: Chuck Ebbert <cebbert@redhat.com> Add xt_statistic.h to the list of headers to install. Apparently needed to build newer versions of iptables. Signed-off-by: Chuck Ebbert <cebbert@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/netfilter/Kbuild | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) Index: ...

ACPICA: Fixed possible corruption of global GPE list Fixed a problem in acpi_ev_delete_gpe_xrupt where the global interrupt list could be corrupted if the interrupt being removed was at the head of the list. Reported by Linn Crosetto. Signed-off-by: Bob Moore <robert.moore@intel.com> Signed-off-by: Len Brown <len.brown@intel.com> Cc: Chuck Ebbert <cebbert@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/acpi/events/evgpeblk.c | 4 ++++ 1 files changed, 4 ...

Hi all, I got a Bluetooth wireless mouse identifed as, input: Microsoft Microsoft� Wireless Notebook Presenter Mouse 8000 as /devices/pci0000:00/0000:00:1d.1/usb3/3-1/3-1.3/3-1.3:1.0/input/input12 input: USB HID v1.11 Mouse [Microsoft Microsoft� Wireless Notebook Presenter Mouse 8000] on usb-0000:00:1d.1-1.3 Problem is when there is a moderate traffic on wireless interface (300-400k/s down 50-60k/up on 4Mbit) mouse is really sluggish. This is when I am running ktorrent. If I stop the ...

Hi, I think that my drives should be NCQ blacklisted too. That's what I'm getting in my /var/log/messages: ------------------------------------------------------------------------------- Oct 13 13:55:52 ko kernel: ata1.00: exception Emask 0x2 SAct 0x3f9 SErr 0x0 action 0x2 frozen Oct 13 13:55:53 ko kernel: ata1.00: (spurious completions during NCQ issue=0x0 SAct=0x3f9 FIS=004040a1:00000004) Oct 13 13:55:53 ko kernel: ata1.00: cmd 61/08:00:d0:5e:8f/00:00:0f:00:00/40 tag 0 cdb 0x0 data 4096 ...

Please kill that line. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -

Hi Linus, Andrew, Here are some m68k patches for 2.6.24: [1] m68k: Atari input drivers cleanup [2] m68k: Atari keyboard ACIA driver cleanup [3] m68k: ignore restart_syscall [4] m68k: Export cachectl.h [5] dm: emc_endio returns void [6] m68k: fix net drivers after recent get_stats updates [7] b43 wireless needs <linux/io.h> [8] ssb bus needs <linux/io.h> Patches 1-4 are m68k support updates. Patches 5-8 are fixes for regressions/failures introduced after 2.6.23. Please ...

ssb bus needs <linux/io.h> linux/drivers/ssb/main.c: In function 'ssb_ssb_read16': linux/drivers/ssb/main.c:518: error: implicit declaration of function 'readw' linux/drivers/ssb/main.c: In function 'ssb_ssb_read32': linux/drivers/ssb/main.c:526: error: implicit declaration of function 'readl' linux/drivers/ssb/main.c: In function 'ssb_ssb_write16': linux/drivers/ssb/main.c:534: error: implicit declaration of function 'writew' linux/drivers/ssb/main.c: In function ...

b43 wireless needs <linux/io.h> linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of function 'mmiowb' linux/drivers/net/wireless/b43/phy.c: In function 'b43_phy_write': linux/drivers/net/wireless/b43/phy.c:301: error: implicit declaration of function 'mmiowb' linuxdrivers/net/wireless/b43/sysfs.c: In function 'b43_attr_interfmode_store': linuxdrivers/net/wireless/b43/sysfs.c:147: error: implicit ...

I had no problems compiling b43legacy on m68k, though. Probably <linux/io.h> was included through some other include file. Of course it's safer to always #include <linux/io.h> when using I/O. During linking, I did get a bunch of `undefined reference to `dma_*'' errors, with both b43 and b43legacy (and a few other drivers). Probably they need to depend on HAS_DMA. I'll post separate patches for those after I've sorted them out. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- ...

From the distribution list for this E-mail, I presume this error occurred for m68k. Is this correct? If so, I will probably need to prepare a similar patch for b43legacy. Thanks, Larry -

m68k: fix net drivers after recent get_stats updates Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/net/macmace.c | 6 +++--- drivers/net/mvme147.c | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) --- a/drivers/net/macmace.c +++ b/drivers/net/macmace.c @@ -538,8 +538,9 @@ static void mace_set_multicast(struct ne local_irq_restore(flags); } -static void mace_handle_misc_intrs(struct mace_data *mp, int intr) +static void ...

m68k: Atari input drivers cleanup: - memleak on failed init/register of input devices fixed - correct keycodes table (Atari keycodes are almost, but not entirely, equal to Linux keycodes). Signed-off-by: Michael Schmitz <schmitz@biophys.uni-duesseldorf.de> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/input/keyboard/atakbd.c | 157 ++++++++++++++++++++++++++++++++++++--- drivers/input/mouse/atarimouse.c | 18 ++-- 2 files changed, 154 insertions(+), 21 ...

Yep, that occurs a lot in the second parameter which we expect this and cope with it. Will fix this for the next release. Thanks for the analysis. -apw -

scripts/checkpatch.pl doesn't seem to like this patch: $ scripts/checkpatch.pl m68k-export-asm-cachectl-h.diff ERROR: Does not appear to be a unified-diff format patch Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. $ cat m68k-export-asm-cachectl-h.diff Subject: m68k: Export cachectl.h From: Matthew Wilcox <matthew@wil.cx> libffi in GCC 4.2 needs cachectl.h to do its cache flushing. ...

Hi, I am using an ARM processor with CS8900 Ethernet card, it works fine in kernel 2.6.11. But, recently I upgraded it to kernel 2.6.22, the ipconfig.c started up a bond0 instead of eth0 with an IP address I actually assigned to eth0 in cs89x0.c. The trouble was I cannot event ping the ip address. Any advice why this was happend and how to fix it? Thank you. Jim -

Same issue here, and as well making mrproper fixes it. Thanks, ciao, --alessandro "you feel the sweet breath of time it's whispering, its truth not mine" (Interpol, 'No I In Threesome') -

That's a stale include/asm symlink. Can you save your .config file and do make mrproper please and check if it's solved. Thanks, tglx -

Linus, please pull from the repo and branch at git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus to receive the 2.6.24 episode of KVM. Highlights include in-kernel pic/lapic/ioapic emulation, improved guest support, preemptibility, an improved x86 emulator, and a fair amount of cleanup. The changes outside drivers/kvm/ and include/linux/kvm*.h fix the CR8 mask definition (which is not otherwise used in the kernel) and expose some ioapic register definitions even if ...

In commit 4665079cbb2a3e17de82f2ab2940b9f97f37d65e ([NETNS]: Move some code into __init section when CONFIG_NET_NS=n) we got a new section - .exit.text.refok (more of 'let's tell modpost that some bogus calls are not bogus', a-la text.init.refok). Unfortunately, commit in question forgot to add it to TEXT_TEXT, with rather amusing results. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index ...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/drivers/net/macmace.c b/drivers/net/macmace.c index 6589239..1877052 100644 --- a/drivers/net/macmace.c +++ b/drivers/net/macmace.c @@ -538,8 +538,9 @@ static void mace_set_multicast(struct net_device *dev) local_irq_restore(flags); } -static void mace_handle_misc_intrs(struct mace_data *mp, int intr) +static void mace_handle_misc_intrs(struct net_device *dev, int intr) { + struct mace_data *mp = netdev_priv(dev); ...

Breaks on any target that has copy_to_user() defined as a non-trivial macro. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c index c606332..5599a36 100644 --- a/drivers/media/video/videobuf-core.c +++ b/drivers/media/video/videobuf-core.c @@ -674,7 +674,7 @@ ssize_t videobuf_read_one(struct videobuf_queue *q, } /* Copy to userspace ...

a) include/asm-um/arch can't just point to include/asm-$(SUBARCH) now b) arch/{i386,x86_64}/crypto are merged now c) subarch-obj needed changes d) cpufeature_64.h should pull "cpufeature_32.h", not <asm/cpufeature_32.h> since it can be included from asm-um/cpufeature.h e) in case of uml-i386 we need CONFIG_X86_32 for make and gcc, but not for Kconfig f) sysctl.c shouldn't do vdso_enabled for uml-i386 (actually, that one should be registered from corresponding arch/*/kernel/*, with ifdef ...

Sure - if I knew what that was or how to do it ;). If you want to guide me, I'll give it try. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 -

Booting with initcall_debug doesn't change the output at all. If I boot a working kernel with initcall_debug, the added output starts showing up right after the point that my broken kernel is freezing. Mount-cache hash table entries: 1024 ACPI: Core revision 20070126 Boot processor id 0x0/0x0 Brought up 8 CPUs Total of 8 processors activated (15564.80 BogoMIPS). << Broken kernel freezes here >> << Good kernel continues with ...>> Calling initcall 0xa0000001009d6310: ...

Dang it -- I suspect I borked my bisection. Looks like the problem is in the few patches prior to git-block. Sorry, Jens. I'll start all over again, on some other thread, once I have something useful (to someone, likely not you ;) to say. Sorry. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 -

[Try again, with a Subject this time ...] The git-block patches in 2.6.23-mm1 freeze my ia64 SN Altix hard on boot. Not good (tm). Something broke between the git-block patch of Sept 26 in 2.6.23-rc8-mm2 and the git-block patches of Oct 10-11 in 2.6.23-mm1 on my ia64 SN Altix system using sn2_defconfig. Bisecting 2.6.23-mm1 narrows the problem down to the git-block patches: git-block.patch git-block-fixup-1.patch git-block-fixup.patch git-block-fixup-fix.patch ...

Does it depend on hardware offering suitable support? What are chances for it to work on 5 years old DVD-ROM? -

2.6.23-git2, on x86_32, with HOTPLUG=n, MODULES=n: WARNING: vmlinux.o(.text+0x809e): Section mismatch: reference to .init.text:register_cpu (between 'arch_register_cpu' and 'alternatives_smp_module_del') WARNING: vmlinux.o(.text+0x1c1acc): Section mismatch: reference to .init.text:pcibios_fixup_bus (between 'pci_scan_child_bus' and 'pci_scan_bus_parented') WARNING: vmlinux.o(.data+0x6af38): Section mismatch: reference to .init.text:asd_aic9410_setup (between 'asd_pcidev_data' and ...

Hi Andrew, Following call trace is seen will booting up the machine. Similar call trace was reported for 2.6.23-rc3-mm1 at http://lkml.org/lkml/2007/8/26/77 Mount-cache hash table entries: 512 WARNING: at kernel/lockdep.c:2664 check_flags() [<c010612f>] dump_trace+0x68/0x1d2 [<c01062b1>] show_trace_log_lvl+0x18/0x2c [<c0106c23>] show_trace+0xf/0x11 [<c0106d33>] dump_stack+0x12/0x14 [<c01414ac>] check_flags+0x92/0x145 [<c0144426>] lock_acquire+0x2f/0x8a [<c0509771>] ...

That's a clear bug.. IDE's should be called ide_platform. Jeff -

Greetings, Perhaps my .config is dainbramaged. When make oldconfig asked me if I wanted CONFIG_PATA_PLATFORM, I said "Damned if I know, go for it". drivers/ide/legacy/ide_platform.c: .name = "pata_platform", drivers/ata/pata_platform.c:#define DRV_NAME "pata_platform" [ 26.586663] sysfs: duplicate filename 'pata_platform' can not be created [ 26.601006] WARNING: at fs/sysfs/dir.c:425 sysfs_add_one() [ 26.614080] [<c010515a>] show_trace_log_lvl+0x1a/0x30 [ 26.626777] ...

Eek. The smackfs code does look pretty crufty in the context of seq_file, doesn't it? I will have a go at Nope. What you see there is a flaw, a mistake, a bug. And a serious memory use problem, too. Fix in test. Your suggestions regarding seq_file look helpful. Thank you. Casey Schaufler casey@schaufler-ca.com -

From: Randy Dunlap <randy.dunlap@oracle.com> Fix networking code kernel-doc for newly added parameters. Warning(linux-2.6.23-git2//net/core/sock.c:879): No description found for parameter 'net' Warning(linux-2.6.23-git2//net/core/dev.c:570): No description found for parameter 'net' Warning(linux-2.6.23-git2//net/core/dev.c:594): No description found for parameter 'net' Warning(linux-2.6.23-git2//net/core/dev.c:617): No description found for parameter ...

From: Randy Dunlap <randy.dunlap@oracle.com> Fix docbook templates for new x86 path/filenames: docproc: linux-2.6.23-git2/include/asm-i386/io.h: No such file or directory Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- Documentation/DocBook/deviceiobook.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.23-git2.orig/Documentation/DocBook/deviceiobook.tmpl +++ linux-2.6.23-git2/Documentation/DocBook/deviceiobook.tmpl @@ -316,7 +316,7 @@ CPU B: ...

From: Randy Dunlap <randy.dunlap@oracle.com> Fix docbook templates for modified x86 path/filenames. Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- Documentation/DocBook/kernel-hacking.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.23-git2.orig/Documentation/DocBook/kernel-hacking.tmpl +++ linux-2.6.23-git2/Documentation/DocBook/kernel-hacking.tmpl @@ -1239,7 +1239,7 @@ static struct block_device_operations op </para> <para> - ...

Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6.git Which contains: Adrian McMenamin (4): fb: pvr2fb: Shared IRQ for dreamcast pvr2. sh: Add maple bus support for the SEGA Dreamcast. video: pvr2fb: Add TV (RGB) support to Dreamcast PVR driver. sh: Fix SH-4 DMAC CHCR masking. Aoi Shinkai (1): sh: rts7751r2d cf_ide rework Kristoffer Ericson (9): sh: Fix OFFCHIP_IRQ_BASE compile error. sh: update hp6xx defconfig. ...

Fixes the problem for me, thanks Dave! Acked-by: Jean Delvare <khali@linux-fr.org> This should be applied to Linus' tree quickly. -- Jean Delvare -

I'd like to see an additional termination condition to this loop (might just be paranoia though).

So, I don't actually know what you're looking for, but of the 140 occasions that .compat_ioctl is implemented in Linus' tree, I can't find another one that actually uses this form. So, writing a shared implementation doesn't pick off any low hanging fruit. Now, it's possible that some of the other implementations could be reduced to this form - but for now, it seems the answer to your question is 'one' in either case. :-) --phil -

Perhaps say warning("override: switching to choice %s", sym->name); if sym->name is [CONFIG_]PREEMPT_VOLUNTARY. Or what is it? -- Stefan Richter -=====-=-=== =-=- -==-= http://arcgraph.de/sr/ -

Patches welcome. Even without the patch, i.e. original kconfig behavior, spews two warnings. One for the symbol, and one for the choiec object. I do not see anything wrong with that; adding extra checks would perhaps only increase the code size. -

.config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY .config:176:warning: override: PREEMPT_VOLUNTARY turns state choice Which seems correct, as PREEMPT_VOLUNTARY=y will overturn the previous decision. Perhaps it should be "%s overturns state choice" ? -

This patch further reduced iperf context switching, and boosted throughput. iperf -c localhost -P 10 -t 300 Previously reported numbers 2.6.23-smp [SUM] 0.0-300.0 sec 153 GBytes 4.39 Gbits/sec [SUM] 0.0-300.1 sec 148 GBytes 4.23 Gbits/sec [SUM] 0.0-300.0 sec 152 GBytes 4.36 Gbits/sec 2.6.23-smp-d (sched-devel) [SUM] 0.0-300.0 sec 173 GBytes 4.96 Gbits/sec [SUM] 0.0-300.1 sec 173 GBytes 4.96 Gbits/sec [SUM] 0.0-300.0 sec 172 GBytes 4.93 ...

Yes. Throughput falls as preemption climbs. -Mike -

I guess something like this ought to do, but its a tad late so I'm quite sure :-) --- kernel/sched_fair.c | 44 +++++++++++++++++++++++++++++++++++++------- 1 file changed, 37 insertions(+), 7 deletions(-) Index: linux-2.6/kernel/sched_fair.c =================================================================== --- linux-2.6.orig/kernel/sched_fair.c +++ linux-2.6/kernel/sched_fair.c @@ -737,6 +737,24 @@ static inline struct sched_entity *paren #endif /* CONFIG_FAIR_GROUP_SCHED ...

Ah, but HRTICK is not compatible with PREEMPT_RESTRICT, it will be

Andy, I've tested the --emacs feature in the above latest checkpatch.pl-next. Below is a patch that completes the functionality of the --emacs option: it ensures that only the cc-style error messages are printed, no extra context lines or caret lines, no extra newlines, etc. Although this patch changes every call to a message-producing function, it is a trivial change, and I believe it's the cleanest way to handle the separation between the terse cc-style messages and the verbose ...

Ext2, 3 & 4 use it to determine whether someone has the right to use the reserved space according to whether their UID/GID match those in the superblock. See ext3_has_free_blocks() for an example. David -

--=20 Andrey Panin | Linux and UNIX system administrator pazke@donpac.ru | PGP key: wwwkeys.pgp.net

No, they aren't. I believe the linker only makes one copy of each section, and once a copy is inserted, all other attempts to make a copy of it are ignored. NAK. David -

Hi, Do you have CONFIG_SLUB enabled? Try looking into /sys/slab/. Pekka -

Hi, I don't think slabtop in procps has been updated to support slub. Christoph? Pekka -

Hi Good news (I hope). With kernel option maxcpus=1, I can not get a lock, so the system is stable and running. Where could be a problem? Best regards, Rok -

hm: [ 104.224904] oprofile: using NMI interrupt. could you disable CONFIG_OPROFILE? Maybe it interferes with the NMI watchdog? how does /proc/interrupts look like shortly after bootup? Does a simple "intentional lockup" piece of code, which provokes a hard lockup from user-space, get properly zapped by the NMI watchdog (within a minute or so): # cat > lockup.c int main(void) { iopl(3); for (;;) asm("cli"); } Ctrl-D # make lockup # ./lockup <hard hang> the NMI ...

I also saw this behaiour, but make mrproper solved the problem. ciao cate -

After a quick look: [sam@neptun x86.git]$ find -name '*.i' ./include/asm-x86/alternative-asm_64.i ./include/asm-x86/alternative-asm_32.i ./include/asm-x86/frame.i ./include/asm-x86/alternative-asm.i ./include/asm-um/frame.i ./include/asm-um/alternative-asm.i [sam@neptun x86.git]$ grep '*.i' Documentation/dontdiff *.i But I cannot see how this could result in the bug you reported.. Anyway at least one dontdiff buglet - or we should preferably drop the .i files in the kernel ...

Hi Andrew, The build fails with following message CC drivers/net/ibm_newemac/zmii.o CC drivers/net/ibm_newemac/rgmii.o drivers/net/ibm_newemac/rgmii.c: In function ‘rgmii_probe’: drivers/net/ibm_newemac/rgmii.c:254: error: implicit declaration of function ‘device_is_compatible’ make[3]: *** [drivers/net/ibm_newemac/rgmii.o] Error 1 make[2]: *** [drivers/net/ibm_newemac] Error 2 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 The function device_is_compatible does not ...

Media player -> http://www.videolan.org/vlc/ -

Something seems to be amiss with CONFIG_LOCALVERSION handling. I am routinely building with CONFIG_LOCALVERSION=3D"-testing" CONFIG_LOCALVERSION_AUTO=3Dy My usual sequence of "make ; sudo make modules_install install" has worked fine for all of 2.6.23{-rc?{,-mm?},}. For 2.6.23-mm1 it fails with: ts@xenon:~/kernel/linux-2.6.23-mm1-work> sudo make modules_install instal= l root's password: INSTALL arch/i386/crypto/aes-i586.ko [...] INSTALL sound/usb/usx2y/snd-usb-usx2y.ko if [ -r ...

Thanks for helping track this down. Fix pushed out to libata-dev.git. Jeff -

Hi Andrew, Another build failure with following message CC drivers/scsi/advansys.o drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API drivers/scsi/advansys.c: In function ‘AdvBuildCarrierFreelist’: drivers/scsi/advansys.c:6486: error: implicit declaration of function ‘virt_to_bus’ drivers/scsi/advansys.c: In function ‘AdvInitAsc3550Driver’: drivers/scsi/advansys.c:6974: error: implicit declaration of function ...

Ouch. I think that the appended patch is needed. Unfortunately, I can't test it here. Greetings, Rafael Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- arch/powerpc/platforms/52xx/lite5200_pm.c | 35 +++++++++++++++++++----------- include/asm-powerpc/mpc52xx.h | 4 +-- 2 files changed, 25 insertions(+), 14 deletions(-) Index: linux-2.6.23-mm1/include/asm-powerpc/mpc52xx.h =================================================================== --- ...

Aha. I am looking at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/broken... Looks like the original patch was damaged somehow, it doesn't have the "put_user(nr, parent_tidptr)" code. Oleg. -

No, the reason is that pthread_join() succeeds while it shouldn't. The main thread does exit_group() and kills the sub-thread sleeping in nanosleep. ERESTART_RESTARTBLOCK is not delivered to the user-space (sub-thread is dying), I bet something like this void *threda(void *arg) { for (;;) pause(); return NULL; } int main(void) { pthread_t tid; pthread_create(&tid, NULL, thread, NULL); pthread_join(tid, NULL); return 0; } Because do_fork() doesn't use ...

In the traceback you have "ata_scsi_flush_xlat", which is the function that translates a SCSI sync-cache command into an ATA flush-cache command. The "WARNING: at drivers/ata/libata-core.c:5752 ata_qc_issue()" also guides us to the code comment /* Make sure only one non-NCQ command is outstanding. The * check is skipped for old EH because it reuses active qc to * request ATAPI sense. */ which is a check related to NCQ->off and off->NCQ edge ...

I don't have the meminfo or slabinfo, only the output from SysRq+M: SysRq : Show Memory Mem-info: Node 0 DMA per-cpu: CPU 0: Hot: hi: 0, btch: 1 usd: 0 Cold: hi: 0, btch: 1 usd: 0 CPU 1: Hot: hi: 0, btch: 1 usd: 0 Cold: hi: 0, btch: 1 usd: 0 CPU 2: Hot: hi: 0, btch: 1 usd: 0 Cold: hi: 0, btch: 1 usd: 0 CPU 3: Hot: hi: 0, btch: 1 usd: 0 Cold: hi: 0, btch: 1 usd: 0 Node 0 DMA32 per-cpu: CPU 0: Hot: hi: 186, btch: ...

3 boots, all worked. So I'm very sure that was the bug, but I will now do a little load testing... The only strange thing about 2.6.23-mm1 is, that it takes ~4 second more to boot. 2.6.23-rc8-mm1: [ 3.720000] scsi0 : sata_sil24 [ 3.730000] scsi1 : sata_sil24 [ 3.740000] ata1: SATA max UDMA/100 irq 17 [ 3.750000] ata2: SATA max UDMA/100 irq 17 [ 4.110000] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300) [ 4.160000] ata1.00: ATA-7: MAXTOR STM3320820AS, 3.AAE, max ...

Aha. That makes sense. But on the second error, where the drive was kicked out completely all three traces did not have ata_scsi_flush_xlat. First WARNING: Oct 13 07:46:48 treogen [ 99.850000] Call Trace: Oct 13 07:46:48 treogen [ 99.850000] [<ffffffff8044431a>] ata_qc_issue+0x4aa/0x540 Oct 13 07:46:48 treogen [ 99.850000] [<ffffffff80432e60>] scsi_done+0x0/0x20 Oct 13 07:46:48 treogen [ 99.850000] [<ffffffff8044ce30>] ata_scsi_pass_thru+0x0/0x2c0 Oct 13 07:46:48 treogen [ ...

On the next boot no WARNING show up. On the third boot with 2.6.23-mm1 the drive failed completely: First I got this WARNING: Oct 13 07:46:48 treogen smartd[6081]: Device: /dev/sdc, opened Oct 13 07:46:48 treogen [ 99.850000] WARNING: at drivers/ata/libata-core.c:5761 ata_qc_issue() Oct 13 07:46:48 treogen [ 99.850000] Oct 13 07:46:48 treogen [ 99.850000] Call Trace: Oct 13 07:46:48 treogen [ 99.850000] [<ffffffff8044431a>] ata_qc_issue+0x4aa/0x540 Oct 13 07:46:48 treogen [ ...

These declarations are extern, but pm-rework-struct-platform_suspend_ops.patch makes the function definitions static, which doesn't seem to be allowed. After removing the static bits from those two functions in mpc52xx_pm.c it builds, but there are lots of warnings, which seem to be related: CC arch/powerpc/kernel/prom.o In file included from arch/powerpc/platforms/52xx/mpc52xx_pic.c:34: include/asm/mpc52xx.h:271: warning: parameter names (without types) in function declaration ...

The WARNING indicates that there is a SWNCQ bug in sata_nv. Given that the problem appears when SYNCHRONIZE CACHE is being issued, I would guess that sata_nv is not properly handling non-queued commands. NVIDIA CC'd. This is a patch from libata-dev.git#nv-swncq (via #ALL). Jeff -

Yes. Thanks. -- Yasunori Goto -

*shrug* I find miniconfig much easier to read because I can see what the 50 or so intentional options are, not just the 1000 or so background options set to various default values. Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson. -

Patch doesn't apply cleanly due to spaces instead of tabs. Copy-and-paste ? --- ~Randy -

The system is stable, the EH seems to be doing its job. Luca -

While doing that clean-up, shouldn't these be converted as well? folkert@muur:/usr/src/linux$ find . -name \*.c -print0 | xargs -0 grep "^ *char *\* *[a-zA-Z0-9_]* *= *\".*\".*;" ./arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:char *toshiba_name = ""; ./arch/ppc/boot/simple/misc-embedded.c:char *bootrom_cmdline = ""; ./arch/blackfin/mach-bf561/boards/ezkit.c:char *bfin_board_name = "ADDS-BF561-EZKIT"; ./arch/blackfin/mach-bf561/boards/generic_board.c:char *bfin_board_name = ...

Yes: a stock kernel, please. Preferably 2.6.23. Thanks. -

From: David Miller <davem@davemloft.net> BTW, even my reply didn't reach him, nifty.com reports "user unknown" for him. I really, truly, suspect therefore that he has other kinds of issues at his site :-) -

Dear David Actually, tcp_sk(sk)->snd_ssthresh is not initialized, if initial_ssthresh is 0. The patch should be static void bictcp_init(struct sock *sk) { bictcp_reset(inet_csk_ca(sk)); - if (initial_ssthresh) - tcp_sk(sk)->snd_ssthresh = initial_ssthresh; + + tcp_sk(sk)->snd_ssthresh = initial_ssthresh; } Best Regards -- Komuro <komurojun@nifty.com> -

OK, I just checked the latest version of checkpatch on 2.6.23.1. Here are the stats broken down by subsystem and category of message (error, warning, or subjective check): SUBSYSTEM Error Warn Check Total drivers 866113 168093 7712 1041918 fs 102133 14016 1236 117385 arch 78531 32898 5400 116829 include 41237 42974 1838 86049 sound 59175 20319 1184 80678 net 6898 6614 ...

Greetings, This is not the proper forum for compilation help (if nothing is broken of course). You would probably get good help asking on fedora forum (or simply do a search there). Looking at your log it seems to more reflect headers missing than anything wrong with the kernel in it self. If you fail to find anything useful, I can help you but please send me mail directly so we don't put additional weight on this mailinglist. Best wishes Kristoffer Ericson On Sat, 13 Oct 2007 22:16:08 ...

On Mon, Oct 01, 2007 at 02:22:22PM -0700, Andrew Morton wrote: can you please add http://lkml.org/lkml/2007/7/30/98 also to the misc-queue for the warning still persists and the patch is good to go as is (against current git v2.6.23-2840-g752097c, for example) albeit with a little fuzziness. -- Regards/Gruß, Boris. -

I got completely fed up with maintaining that patch against ongoing churn frenzy in Greg's trees so I dropped it. If/when things settle down in that area someone will need to redo the patch. -

Hi Dmitry, Well, from the few reports I got it seems not all Elantech touchpads are created equal. And as we don't have any documentation on these touchpads I really don't know whether they all support absolute mode, have the same parameters or use the same protocol for it. So for the time being I really would like to keep support for absolute as well as relative mode in to make it easier for users to switch and test and find out and report where thing go wrong. Maybe that once we find ...