Re: [PATCH] frv: Remove duplicate output of .exit.data

Previous thread: RE: [PATCH try #3] Blackfin BF54x Input Keypad controller driver by Hennerich, Michael on Friday, October 12, 2007 - 11:09 am. (1 message)

Next thread: [PATCH] VFS: Remove lives_below_in_same_fs() by Jan Blunck on Friday, October 12, 2007 - 11:58 am. (1 message)
To: David Howells <dhowells@...>, Andrew Morton <akpm@...>
Cc: <linux-kernel@...>
Date: Friday, October 12, 2007 - 11:40 am

When CONFIG_DEBUG_INFO is unset the input .exit.data sections are copied
twice to vmlinux. Remove the copy made to .init.text and keep one in
.data only.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
It looks like an accidental mistake to me. It applies to current Linus's
2.6.23.

Please consider,

Maciej

patch-mips-2.6.23-rc5-20070904-frv-exit-data-0
diff -up --recursive --new-file linux-mips-2.6.23-rc5-20070904.macro/arch/frv/kernel/vmlinux.lds.S linux-mips-2.6.23-rc5-20070904/arch/frv/kernel/vmlinux.lds.S
--- linux-mips-2.6.23-rc5-20070904.macro/arch/frv/kernel/vmlinux.lds.S 2007-09-04 04:55:18.000000000 +0000
+++ linux-mips-2.6.23-rc5-20070904/arch/frv/kernel/vmlinux.lds.S 2007-10-11 22:53:09.000000000 +0000
@@ -30,7 +30,6 @@ SECTIONS
#ifndef CONFIG_DEBUG_INFO
*(.init.text)
*(.exit.text)
- *(.exit.data)
*(.exitcall.exit)
#endif
}
-

To: Maciej W. Rozycki <macro@...>
Cc: <dhowells@...>, Andrew Morton <akpm@...>, <linux-kernel@...>
Date: Saturday, October 13, 2007 - 5:17 am

No, they aren't. I believe the linker only makes one copy of each section,
and once a copy is inserted, all other attempts to make a copy of it are
ignored.

NAK.

David
-

To: David Howells <dhowells@...>
Cc: Andrew Morton <akpm@...>, <linux-kernel@...>
Date: Monday, October 15, 2007 - 11:27 am

Fair enough -- a quick test shows you are right. Wouldn't it deserve a
comment, though? I know hardly anybody dares looking into these scripts,
;-) but those who do, may not be sure this setup is intentional.

Maciej
-

To: Maciej W. Rozycki <macro@...>
Cc: <dhowells@...>, Andrew Morton <akpm@...>, <linux-kernel@...>
Date: Monday, October 15, 2007 - 4:43 pm

Probably.

David
-

Previous thread: RE: [PATCH try #3] Blackfin BF54x Input Keypad controller driver by Hennerich, Michael on Friday, October 12, 2007 - 11:09 am. (1 message)

Next thread: [PATCH] VFS: Remove lives_below_in_same_fs() by Jan Blunck on Friday, October 12, 2007 - 11:58 am. (1 message)