login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
13
Re: [git patches] IDE updates (part 2)
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Benjamin Herrenschmidt
Subject:
Re: [git patches] IDE updates (part 2)
Date: Saturday, October 13, 2007 - 5:08 pm
On Sun, 2007-10-14 at 00:41 +0200, Bartlomiej Zolnierkiewicz wrote:
quoted text
> On Sunday 14 October 2007, Alan Cox wrote: > > > > > /* Probably a PCI interface... */ > > > > > for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; ++i) > > > > > hw->io_ports[i] = data_port + i - IDE_DATA_OFFSET; > > > > > hw->io_ports[IDE_CONTROL_OFFSET] = ctrl_port; > > > > Ok so in actual fact > > > > - The piece of code above can't be executed anyway > > - The ctrl_port argument is not needed ? > > pmac_ide_init_hwif_ports() is also called by ide_init_hwif_ports() > through ppc_ide_md.init_hwif.
In which case it should be called with a ctrl_port right ? Ben. -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[git patches] IDE updates (part 2)
, Bartlomiej Zolnierki ...
, (Sat Oct 13, 9:25 am)
Re: [git patches] IDE updates (part 2)
, Alan Cox
, (Sat Oct 13, 12:56 pm)
Re: [git patches] IDE updates (part 2)
, Bartlomiej Zolnierki ...
, (Sat Oct 13, 1:59 pm)
Re: [git patches] IDE updates (part 2)
, Alan Cox
, (Sat Oct 13, 2:44 pm)
Re: [git patches] IDE updates (part 2)
, Bartlomiej Zolnierki ...
, (Sat Oct 13, 3:09 pm)
Re: [git patches] IDE updates (part 2)
, Alan Cox
, (Sat Oct 13, 3:29 pm)
Re: [git patches] IDE updates (part 2)
, Bartlomiej Zolnierki ...
, (Sat Oct 13, 3:41 pm)
Re: [git patches] IDE updates (part 2)
, Benjamin Herrenschmidt
, (Sat Oct 13, 5:08 pm)
Re: [git patches] IDE updates (part 2)
, Al Viro
, (Sat Oct 13, 5:12 pm)
Re: [git patches] IDE updates (part 2)
, Bartlomiej Zolnierki ...
, (Sun Oct 14, 9:07 am)
Re: [git patches] IDE updates (part 2)
, Bartlomiej Zolnierki ...
, (Sun Oct 14, 9:21 am)
Re: [git patches] IDE updates (part 2)
, Benjamin Herrenschmidt
, (Sun Oct 14, 2:15 pm)
Re: [git patches] IDE updates (part 2)
, Jeff Garzik
, (Mon Oct 15, 12:54 pm)
Re: [git patches] IDE updates (part 2)
, Russell King
, (Mon Oct 15, 12:58 pm)
Re: [git patches] IDE updates (part 2)
, Jeff Garzik
, (Mon Oct 15, 1:07 pm)
Re: [git patches] IDE updates (part 2)
, Russell King
, (Tue Oct 16, 8:55 am)
Re: [git patches] IDE updates (part 2)
, Bartlomiej Zolnierki ...
, (Tue Oct 16, 12:41 pm)
Re: [git patches] IDE updates (part 2)
, Russell King
, (Wed Oct 24, 5:38 am)
Re: [git patches] IDE updates (part 2)
, Jeff Garzik
, (Wed Oct 24, 5:53 am)
Re: [git patches] IDE updates (part 2)
, Russell King
, (Wed Oct 24, 6:12 am)
Re: [git patches] IDE updates (part 2)
, Jeff Garzik
, (Wed Oct 24, 6:20 am)
Re: [git patches] IDE updates (part 2)
, Jeff Garzik
, (Wed Oct 24, 11:05 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Alan Cox
Re: Please add ZFS support (from GPL sources)
Trenton D. Adams
Re: Flash IO slow 1.5 MB/s
Rafael J. Wysocki
[Bug #11287] Regression in 2.6.27-rc2 in acpi_processor_init()
Bart Van Assche
Re: Is gcc thread-unsafe?
Ingo Molnar
Re: [PATCH] x86: silence section mismatch warning - uv_cpu_init
git
:
Mark Junker
git on MacOSX and files with decomposed utf-8 file names
Junio C Hamano
Re: git-svnimport
Mark Burton
Re: Sporadic BSOD with msys git?
Junio C Hamano
Re: [PATCH] Detached HEAD (experimental)
Johannes Schindelin
Re: [PATCH] Fix approxidate("never") to always return 0
git-commits-head
:
Linux Kernel Mailing List
ath9k_htc: Allocate URBs properly
Linux Kernel Mailing List
net: don't grab a mutex within a timer context in gianfar
Linux Kernel Mailing List
powerpc/kexec: Add support for FSL-BookE
Linux Kernel Mailing List
[ARM] 4691/1: add missing i2c_board_info struct for at91rm9200
Linux Kernel Mailing List
V4L/DVB (8976): af9015: Add USB ID for AVerMedia A309
linux-netdev
:
David Miller
Re: [RFC 0/5] generic rx recycling
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Gerrit Renker
[PATCH 37/37] dccp: Debugging functions for feature negotiation
Jeff Garzik
Re: [PATCH] drivers/net: remove network drivers' last few uses of IRQF_SAMPLE_RANDOM
openbsd-misc
:
Christophe Rioux
Implementation example of snmp
Nick Holland
Re: booting openbsd on eee without cd-rom
Cabillot Julien
Re: OpenBSD isakmpd and pf vs Cisco PIX or ASA
Nice Daemon
Re: Bind ntpd on certain interface?
Marco Peereboom
Re: Singularity OS
Colocation donated by:
Syndicate