login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
13
Re: [PATCH] JFS: Bio cleanup: Replace missing return statements
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Randy Dunlap <randy.dunlap@...>
To: Jeff Garzik <jeff@...>
Cc: Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>, LKML <linux-kernel@...>, <shaggy@...>
Subject:
Re: [PATCH] JFS: Bio cleanup: Replace missing return statements
Date: Saturday, October 13, 2007 - 3:28 pm
On Sat, 13 Oct 2007 15:11:10 -0400 Jeff Garzik wrote:
quoted text
> > From: Dave Kleikamp <shaggy@linux.vnet.ibm.com> > > commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;" > statements, rather than changing them to null returns.
Is my git tree mucked up? It looks to me like it was commit e30408b2a99cb7b8bf529c7dc2328a19d71894cf that removed the return 0's.
quoted text
> Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com> > Signed-off-by: Jeff Garzik <jgarzik@redhat.com> > --- > Dave sent this under a different cover, but just in case it was missed > in the middle of the thread, I wanted to make sure it was not missed. > > fs/jfs/jfs_logmgr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c > index ccfd029..15a3974 100644 > --- a/fs/jfs/jfs_logmgr.c > +++ b/fs/jfs/jfs_logmgr.c > @@ -2234,6 +2234,8 @@ static void lbmIODone(struct bio *bio, int error) > > /* wakeup I/O initiator */ > LCACHE_WAKEUP(&bp->l_ioevent); > + > + return; > } > > /* > @@ -2258,6 +2260,7 @@ static void lbmIODone(struct bio *bio, int error) > if (bp->l_flag & lbmDIRECT) { > LCACHE_WAKEUP(&bp->l_ioevent); > LCACHE_UNLOCK(flags); > + return; > } > > tail = log->wqueue;
--- ~Randy -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] JFS: Bio cleanup: Replace missing return statements
, Jeff Garzik
, (Sat Oct 13, 3:11 pm)
Re: [PATCH] JFS: Bio cleanup: Replace missing return stateme...
, Randy Dunlap
, (Sat Oct 13, 3:28 pm)
Re: [PATCH] JFS: Bio cleanup: Replace missing return stateme...
, Dave Kleikamp
, (Sat Oct 13, 9:46 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 008/196] Chinese: add translation of volatile-considered-harmful.txt
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH
Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in
Andrew Morton
-mm merge plans for 2.6.23
git
:
linux-netdev
:
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Herbert Xu
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
Rémi Denis-Courmont
[PATCH 01/14] Phonet global definitions
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
3 users
and
686 guests
online.
Online users
Jeremy
Kedar Sovani
emeka_micro
Syndicate