Home » Mailing list archives » linux-kernel » 2007 » October » 13

[PATCH] JFS: Bio cleanup: Replace missing return statements

Previous thread: linux-2.6.23-git3: Many sysfs-related warnings in dmesg by Rafael J. Wysocki on Saturday, October 13, 2007 - 12:26 pm. (21 messages)

Next thread: [PATCH] Input: Refactor evdev 32bit compat to be shareable with uinput by Philip Langdale on Saturday, October 13, 2007 - 12:12 pm. (5 messages)
[view original message]
From: Jeff Garzik
Subject: [PATCH] JFS: Bio cleanup: Replace missing return statements
Date: Saturday, October 13, 2007 - 12:11 pm

From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>

commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;"
statements, rather than changing them to null returns.

Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
Dave sent this under a different cover, but just in case it was missed
in the middle of the thread, I wanted to make sure it was not missed.

 fs/jfs/jfs_logmgr.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index ccfd029..15a3974 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -2234,6 +2234,8 @@ static void lbmIODone(struct bio *bio, int error)
 
 		/* wakeup I/O initiator */
 		LCACHE_WAKEUP(&bp->l_ioevent);
+
+		return;
 	}
 
 	/*
@@ -2258,6 +2260,7 @@ static void lbmIODone(struct bio *bio, int error)
 	if (bp->l_flag & lbmDIRECT) {
 		LCACHE_WAKEUP(&bp->l_ioevent);
 		LCACHE_UNLOCK(flags);
+		return;
 	}
 
 	tail = log->wqueue;

-


[ message continues ]
[view original message]
From: Randy Dunlap
Subject: Re: [PATCH] JFS: Bio cleanup: Replace missing return statements
Date: Saturday, October 13, 2007 - 12:28 pm

Is my git tree mucked up?  It looks to me like it was commit

---
~Randy
-


[ message continues ]
[view original message]
From: Dave Kleikamp
Subject: Re: [PATCH] JFS: Bio cleanup: Replace missing return statements
Date: Saturday, October 13, 2007 - 6:46 pm

Yeah.  It was that one.  I cut and pasted the wrong one for the comment.

Thanks,
Shaggy
-- 
David Kleikamp
IBM Linux Technology Center

-


[ message continues ]
Previous thread: linux-2.6.23-git3: Many sysfs-related warnings in dmesg by Rafael J. Wysocki on Saturday, October 13, 2007 - 12:26 pm. (21 messages)

Next thread: [PATCH] Input: Refactor evdev 32bit compat to be shareable with uinput by Philip Langdale on Saturday, October 13, 2007 - 12:12 pm. (5 messages)