Home » Mailing list archives » linux-kernel » 2007 » October » 13

[PATCH] JFS: Bio cleanup: Replace missing return statements

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jeff Garzik <jeff@...>
To: Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>
Cc: LKML <linux-kernel@...>, <shaggy@...>
Subject: [PATCH] JFS: Bio cleanup: Replace missing return statements
Date: Saturday, October 13, 2007 - 3:11 pm

From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>

commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;"
statements, rather than changing them to null returns.

Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
Dave sent this under a different cover, but just in case it was missed
in the middle of the thread, I wanted to make sure it was not missed.

 fs/jfs/jfs_logmgr.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index ccfd029..15a3974 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -2234,6 +2234,8 @@ static void lbmIODone(struct bio *bio, int error)
 
 		/* wakeup I/O initiator */
 		LCACHE_WAKEUP(&bp->l_ioevent);
+
+		return;
 	}
 
 	/*
@@ -2258,6 +2260,7 @@ static void lbmIODone(struct bio *bio, int error)
 	if (bp->l_flag & lbmDIRECT) {
 		LCACHE_WAKEUP(&bp->l_ioevent);
 		LCACHE_UNLOCK(flags);
+		return;
 	}
 
 	tail = log->wqueue;

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] JFS: Bio cleanup: Replace missing return statements, Jeff Garzik, (Sat Oct 13, 3:11 pm)
Re: [PATCH] JFS: Bio cleanup: Replace missing return stateme..., Randy Dunlap, (Sat Oct 13, 3:28 pm)
Re: [PATCH] JFS: Bio cleanup: Replace missing return stateme..., Dave Kleikamp, (Sat Oct 13, 9:46 pm)