Home » Mailing list archives » linux-kernel » 2007 » October » 13

[PATCH] mmc: possible leak in mmc_read_ext_csd

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Florin Malita <fmalita@...>
To: <drzeus-mmc@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>
Subject: [PATCH] mmc: possible leak in mmc_read_ext_csd
Date: Saturday, October 13, 2007 - 12:27 pm

The exception path associated with an invalid ext_csd_struct returns 
without freeing ext_csd.

Coverity CID 1909.

Signed-off-by: Florin Malita
---

 drivers/mmc/core/mmc.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 65fe288..68c0e3b 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -213,7 +213,8 @@ static int mmc_read_ext_csd(struct mmc_card *card)
 		printk(KERN_ERR "%s: unrecognised EXT_CSD structure "
 			"version %d\n", mmc_hostname(card->host),
 			ext_csd_struct);
-		return -EINVAL;
+		err = -EINVAL;
+		goto out;
 	}
 
 	if (ext_csd_struct >= 2) {

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] mmc: possible leak in mmc_read_ext_csd, Florin Malita, (Sat Oct 13, 12:27 pm)
Re: [PATCH] mmc: possible leak in mmc_read_ext_csd, Pierre Ossman, (Wed Oct 17, 3:32 pm)