login
Header Space

 
 

Re: 2.6.23-mm1 thread exit_group issue

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...>, <viro@...>, <kamezawa.hiroyu@...>, <linux-kernel@...>, <sam@...>, <netdev@...>, Pavel Emelyanov <xemul@...>, Sukadev Bhattiprolu <sukadev@...>, Paul Menage <menage@...>, Eric W. Biederman <ebiederm@...>
Date: Saturday, October 13, 2007 - 7:48 am

On 10/12, Andrew Morton wrote:

No, the reason is that pthread_join() succeeds while it shouldn't. The main
thread does exit_group() and kills the sub-thread sleeping in nanosleep.
ERESTART_RESTARTBLOCK is not delivered to the user-space (sub-thread is dying),
it is just reported by gdb.


I bet something like this

	void *threda(void *arg)
	{
		for (;;)
			pause();
		return NULL;
	}

	int main(void)
	{
		pthread_t tid;

		pthread_create(&tid, NULL, thread, NULL);
		pthread_join(tid, NULL);

		return 0;
	}

won't work as well.


Because do_fork() doesn't use parent_tidptr. At all! So it is very clear
why 2.6.23-mm1 is broken.


This? http://marc.info/?l=linux-mm-commits&m=118712242002039

Pavel, this patch has a subtle difference compared to what we discussed on
containers list. It moves put_user(parent_tidptr) from copy_process() to
do_fork(), so we don't report child's pid if copy_process() failed. I do
not think this is bad, but Eric seems to disagree with such a change.

But I can't understand why Andrew sees the same problem _after_ this patch!

And which patch removed the "put_user(nr, parent_tidptr)" chunk?

Andrew, could I get the kernel source after bisection somehow? (I am not
familiar with guilt, will try to study it later)

Mathieu, could you try the patch below?

Oleg.

--- kernel/fork.c~	2007-10-13 15:41:35.000000000 +0400
+++ kernel/fork.c	2007-10-13 15:41:41.000000000 +0400
@@ -1443,6 +1443,9 @@ long do_fork(unsigned long clone_flags,
 			task_pid_nr_ns(p, current->nsproxy->pid_ns) :
 				task_pid_vnr(p);
 
+		if (clone_flags & CLONE_PARENT_SETTID)
+			put_user(nr, parent_tidptr);
+
 		if (clone_flags & CLONE_VFORK) {
 			p->vfork_done = &vfork;
 			init_completion(&vfork);

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.23-mm1, Andrew Morton, (Fri Oct 12, 12:31 am)
kernel panic when running tcpdump, Mariusz Kozlowski, (Mon Oct 22, 2:40 pm)
Re: kernel panic when running tcpdump, Andrew Morton, (Mon Oct 22, 3:03 pm)
Re: kernel panic when running tcpdump, Mariusz Kozlowski, (Mon Oct 22, 5:16 pm)
mysqld prevents s2ram [Re: 2.6.23-mm1], Mattia Dongili, (Sun Oct 21, 1:58 am)
Re: mysqld prevents s2ram [Re: 2.6.23-mm1], Pavel Machek, (Sun Oct 21, 5:58 am)
Re: mysqld prevents s2ram [Re: 2.6.23-mm1], Rafael J. Wysocki, (Sun Oct 21, 7:53 am)
Re: mysqld prevents s2ram [Re: 2.6.23-mm1], Mattia Dongili, (Sun Oct 21, 2:28 am)
Re: 2.6.23-mm1 - list_add corruption in cgroup, Cedric Le Goater, (Wed Oct 17, 11:54 am)
Re: 2.6.23-mm1 - list_add corruption in cgroup, Paul Menage, (Fri Oct 19, 6:11 pm)
Re: 2.6.23-mm1 - list_add corruption in cgroup, Paul Menage, (Thu Oct 18, 11:56 am)
Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs, Laurent Riffard, (Sun Oct 14, 6:34 pm)
Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs, Christoph Hellwig, (Mon Oct 15, 4:40 am)
Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs, Laurent Riffard, (Mon Oct 15, 3:51 pm)
Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs, Jeff Mahoney, (Mon Oct 15, 2:31 pm)
Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs, Laurent Riffard, (Mon Oct 15, 4:06 pm)
Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs, Jeff Mahoney, (Mon Oct 15, 4:23 pm)
Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs, Christoph Hellwig, (Wed Oct 17, 4:59 am)
Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs, Christoph Hellwig, (Wed Oct 17, 4:58 am)
Re: 2.6.23-mm1: BUG in reiserfs_delete_xattrs, Jeff Mahoney, (Wed Oct 17, 10:55 am)
[2.6.23-mm1] CONFIG_LOCALVERSION handling broken, Tilman Schmidt, (Sat Oct 13, 6:11 pm)
Re: [2.6.23-mm1] CONFIG_LOCALVERSION handling broken, Tilman Schmidt, (Wed Oct 17, 7:06 pm)
Re: [2.6.23-mm1] CONFIG_LOCALVERSION handling broken, Tilman Schmidt, (Sat Oct 27, 11:19 am)
Re: [2.6.23-mm1] CONFIG_LOCALVERSION handling broken, Sam Ravnborg, (Sat Oct 27, 11:28 am)
Re: [2.6.23-mm1] CONFIG_LOCALVERSION handling broken, Sam Ravnborg, (Wed Oct 17, 4:27 pm)
Re: 2.6.23-mm1, Gabriel C, (Sat Oct 13, 1:12 pm)
Re: 2.6.23-mm1, Andrew Morton, (Sat Oct 13, 2:01 pm)
Re: 2.6.23-mm1, Gabriel C, (Sat Oct 13, 2:08 pm)
Re: 2.6.23-mm1, Dave Hansen, (Mon Oct 15, 12:28 pm)
Re: 2.6.23-mm1 - build failure with advansys, Kamalesh Babulal, (Sat Oct 13, 12:44 am)
Re: 2.6.23-mm1 - build failure with advansys, Andrew Morton, (Sat Oct 13, 2:52 am)
Re: 2.6.23-mm1 - build failure with advansys, Paul Mackerras, (Wed Oct 17, 8:07 pm)
Re: 2.6.23-mm1 - build failure with advansys, Matthew Wilcox, (Wed Oct 17, 9:48 pm)
Re: 2.6.23-mm1 - Build failure on rgmii, Kamalesh Babulal, (Sat Oct 13, 12:35 am)
Re: 2.6.23-mm1, Laurent Riffard, (Fri Oct 12, 4:38 pm)
Re: 2.6.23-mm1, Andrew Morton, (Fri Oct 12, 5:00 pm)
Re: 2.6.23-mm1, Zan Lynx, (Mon Oct 15, 12:13 pm)
Re: 2.6.23-mm1 - build failure on axonram, Kamalesh Babulal, (Fri Oct 12, 3:44 am)
oops in lbmIODone, fails to boot [Re: 2.6.23-mm1], Mattia Dongili, (Sat Oct 20, 12:57 am)
Re: oops in lbmIODone, fails to boot [Re: 2.6.23-mm1], Andrew Morton, (Sat Oct 20, 1:34 am)
Re: oops in lbmIODone, fails to boot [Re: 2.6.23-mm1], Dave Kleikamp, (Sat Oct 20, 8:18 am)
Re: oops in lbmIODone, fails to boot [Re: 2.6.23-mm1], Mattia Dongili, (Sun Oct 21, 1:44 am)
Re: 2.6.23-mm1 - autofs broken, Rik van Riel, (Sat Oct 20, 1:13 am)
Re: 2.6.23-mm1 - autofs broken, Ian Kent, (Sun Oct 21, 11:45 pm)
Re: 2.6.23-mm1 - autofs broken, Rik van Riel, (Mon Oct 22, 12:46 pm)
Re: 2.6.23-mm1 - autofs broken, Andrew Morton, (Sat Oct 20, 1:39 am)
Re: 2.6.23-mm1 - autofs broken, Rik van Riel, (Sat Oct 20, 1:54 am)
Re: 2.6.23-mm1 - autofs broken, Rik van Riel, (Sat Oct 20, 1:54 am)
Re: 2.6.23-mm1 - autofs broken, Rik van Riel, (Sat Oct 20, 10:56 am)
Re: 2.6.23-mm1 - autofs broken, Dave Hansen, (Mon Oct 22, 6:03 pm)
Re: 2.6.23-mm1, KAMEZAWA Hiroyuki, (Wed Oct 17, 3:01 am)
Re: 2.6.23-mm1, Jiri Kosina, (Wed Oct 17, 5:10 am)
Re: 2.6.23-mm1, KAMEZAWA Hiroyuki, (Wed Oct 17, 5:36 am)
Re: 2.6.23-mm1, Jiri Kosina, (Fri Oct 19, 5:54 pm)
Re: 2.6.23-mm1, Jiri Kosina, (Wed Oct 17, 7:42 am)
Re: 2.6.23-mm1, KAMEZAWA Hiroyuki, (Wed Oct 17, 8:33 am)
PIE randomization (was Re: 2.6.23-mm1), Jiri Kosina, (Fri Oct 19, 5:07 am)
Re: 2.6.23-mm1, Andrew Morton, (Wed Oct 17, 5:02 am)
Suspend Broken (Re: 2.6.23-mm1), Dhaval Giani, (Sat Oct 13, 1:58 pm)
Re: Suspend Broken (Re: 2.6.23-mm1), Rafael J. Wysocki, (Sat Oct 13, 2:33 pm)
Re: Suspend Broken (Re: 2.6.23-mm1), Dhaval Giani, (Sun Oct 14, 12:26 am)
Re: Suspend Broken (Re: 2.6.23-mm1), Rafael J. Wysocki, (Sun Oct 14, 10:19 am)
Re: 2.6.23-mm1 pm_prepare() and _finish() w/ args vs. without, Rafael J. Wysocki, (Sat Oct 13, 1:22 pm)
Re: 2.6.23-mm1 pm_prepare() and _finish() w/ args vs. without, Rafael J. Wysocki, (Sat Oct 13, 3:13 pm)
Re: 2.6.23-mm1 pm_prepare() and _finish() w/ args vs. without, Rafael J. Wysocki, (Sun Oct 14, 4:20 pm)
Re: 2.6.23-mm1 pm_prepare() and _finish() w/ args vs. without, Rafael J. Wysocki, (Mon Oct 15, 4:55 pm)
Re: 2.6.23-mm1, Rafael J. Wysocki, (Fri Oct 12, 5:32 pm)
Re: 2.6.23-mm1, Mark Gross, (Mon Oct 15, 12:09 pm)
Re: 2.6.23-mm1, Rafael J. Wysocki, (Mon Oct 15, 4:40 pm)
Re: 2.6.23-mm1, Mark Gross, (Tue Oct 16, 3:58 pm)
Re: 2.6.23-mm1, Rafael J. Wysocki, (Tue Oct 16, 4:28 pm)
Re: 2.6.23-mm1, Mark Gross, (Tue Oct 16, 7:31 pm)
Re: 2.6.23-mm1, KAMEZAWA Hiroyuki, (Fri Oct 12, 1:03 am)
Re: 2.6.23-mm1, Cedric Le Goater, (Fri Oct 12, 2:48 am)
Re: 2.6.23-mm1, Andrew Morton, (Fri Oct 12, 2:42 am)
Re: 2.6.23-mm1, Torsten Kaiser, (Fri Oct 12, 4:31 am)
Re: 2.6.23-mm1, Andrew Morton, (Fri Oct 12, 4:37 am)
Re: 2.6.23-mm1, Torsten Kaiser, (Sat Oct 13, 4:01 am)
Re: 2.6.23-mm1, Jeff Garzik, (Sat Oct 13, 6:55 am)
Re: 2.6.23-mm1, Torsten Kaiser, (Sat Oct 13, 8:03 am)
Re: 2.6.23-mm1, Jeff Garzik, (Sat Oct 13, 8:19 am)
Re: 2.6.23-mm1, Torsten Kaiser, (Sat Oct 13, 10:32 am)
Re: 2.6.23-mm1, Torsten Kaiser, (Sat Oct 13, 10:40 am)
Re: 2.6.23-mm1, Torsten Kaiser, (Sat Oct 13, 11:13 am)
Re: 2.6.23-mm1, Jeff Garzik, (Sat Oct 13, 1:48 pm)
Re: 2.6.23-mm1, Torsten Kaiser, (Sat Oct 13, 2:05 pm)
Re: 2.6.23-mm1, Jeff Garzik, (Sat Oct 13, 2:41 pm)
Re: 2.6.23-mm1, Andrew Morton, (Sat Oct 13, 2:18 pm)
Re: 2.6.23-mm1, Torsten Kaiser, (Sun Oct 14, 7:54 am)
Re: 2.6.23-mm1, Andrew Morton, (Sun Oct 14, 2:39 pm)
Re: 2.6.23-mm1, Torsten Kaiser, (Sun Oct 14, 3:12 pm)
Re: 2.6.23-mm1, Andrew Morton, (Sun Oct 14, 3:26 pm)
Re: 2.6.23-mm1, Torsten Kaiser, (Sun Oct 14, 3:40 pm)
Re: 2.6.23-mm1, Milan Broz, (Sun Oct 14, 6:03 pm)
Re: 2.6.23-mm1, Jens Axboe, (Mon Oct 15, 2:50 am)
Re: 2.6.23-mm1, Torsten Kaiser, (Sat Oct 13, 2:35 pm)
Re: 2.6.23-mm1, Torsten Kaiser, (Fri Oct 12, 8:46 am)
Re: 2.6.23-mm1, KAMEZAWA Hiroyuki, (Fri Oct 12, 3:25 am)
Re: 2.6.23-mm1, Sam Ravnborg, (Fri Oct 12, 4:36 am)
Re: 2.6.23-mm1, Al Viro, (Fri Oct 12, 2:46 am)
Re: 2.6.23-mm1, Andrew Morton, (Fri Oct 12, 3:13 am)
Re: 2.6.23-mm1 thread exit_group issue, Mathieu Desnoyers, (Fri Oct 12, 3:47 pm)
Re: 2.6.23-mm1 thread exit_group issue, Andrew Morton, (Fri Oct 12, 9:03 pm)
Re: 2.6.23-mm1 thread exit_group issue, Oleg Nesterov, (Sat Oct 13, 7:48 am)
Re: 2.6.23-mm1 thread exit_group issue, Mathieu Desnoyers, (Sun Oct 14, 12:04 am)
Re: 2.6.23-mm1 thread exit_group issue, Oleg Nesterov, (Sat Oct 13, 8:02 am)
Re: 2.6.23-mm1 thread exit_group issue, Andrew Morton, (Sat Oct 13, 1:49 pm)
Re: 2.6.23-mm1 thread exit_group issue, Andrew Morton, (Fri Oct 12, 4:01 pm)
Re: 2.6.23-mm1, Al Viro, (Fri Oct 12, 3:04 pm)
[PATCH net-2.6] uml: hard_header fix, Stephen Hemminger, (Fri Oct 12, 2:06 pm)
Build Failure (Was Re: 2.6.23-mm1), Dhaval Giani, (Fri Oct 12, 5:42 am)
[PATCH] add missing parenthesis in cfe_writeblk() macro, Mariusz Kozlowski, (Fri Oct 12, 2:51 am)
nfs mmap adventure (was: 2.6.23-mm1), Peter Zijlstra, (Mon Oct 15, 8:28 am)
Re: nfs mmap adventure (was: 2.6.23-mm1), David Howells, (Mon Oct 15, 10:06 am)
Re: nfs mmap adventure (was: 2.6.23-mm1), Nick Piggin, (Mon Oct 15, 9:46 pm)
Re: nfs mmap adventure (was: 2.6.23-mm1), David Howells, (Mon Oct 15, 7:27 pm)
Re: nfs mmap adventure (was: 2.6.23-mm1), Trond Myklebust, (Mon Oct 15, 11:51 am)
Re: nfs mmap adventure (was: 2.6.23-mm1), Peter Zijlstra, (Mon Oct 15, 12:38 pm)
Re: nfs mmap adventure (was: 2.6.23-mm1), Trond Myklebust, (Mon Oct 15, 11:43 am)
speck-geostationary