[PATCH 10/75] Driver core: remove put_bus()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Friday, October 12, 2007 - 3:16 pm

put_bus() should not be globally visable as it is not used by anything
other than drivers/base/bus.c.  This patch removes the visability of it,
and renames it to match all of the other *_put() functions in the
kernel.


Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/base/base.h |    1 -
 drivers/base/bus.c  |   29 ++++++++++++++---------------
 2 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/drivers/base/base.h b/drivers/base/base.h
index 47eb02d..cebc7e7 100644
--- a/drivers/base/base.h
+++ b/drivers/base/base.h
@@ -19,7 +19,6 @@ extern int bus_add_device(struct device * dev);
 extern void bus_attach_device(struct device * dev);
 extern void bus_remove_device(struct device * dev);
 extern struct bus_type *get_bus(struct bus_type * bus);
-extern void put_bus(struct bus_type * bus);
 
 extern int bus_add_driver(struct device_driver *);
 extern void bus_remove_driver(struct device_driver *);
diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index bc38085..4f53b75 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -30,6 +30,11 @@
 static int __must_check bus_rescan_devices_helper(struct device *dev,
 						void *data);
 
+static void bus_put(struct bus_type *bus)
+{
+	kset_put(&bus->subsys);
+}
+
 static ssize_t
 drv_attr_show(struct kobject * kobj, struct attribute * attr, char * buf)
 {
@@ -124,7 +129,7 @@ int bus_create_file(struct bus_type * bus, struct bus_attribute * attr)
 	int error;
 	if (get_bus(bus)) {
 		error = sysfs_create_file(&bus->subsys.kobj, &attr->attr);
-		put_bus(bus);
+		bus_put(bus);
 	} else
 		error = -EINVAL;
 	return error;
@@ -134,7 +139,7 @@ void bus_remove_file(struct bus_type * bus, struct bus_attribute * attr)
 {
 	if (get_bus(bus)) {
 		sysfs_remove_file(&bus->subsys.kobj, &attr->attr);
-		put_bus(bus);
+		bus_put(bus);
 	}
 }
 
@@ -186,7 +191,7 @@ static ssize_t driver_unbind(struct device_driver *drv,
 		err = count;
 	}
 	put_device(dev);
-	put_bus(bus);
+	bus_put(bus);
 	return err;
 }
 static DRIVER_ATTR(unbind, S_IWUSR, NULL, driver_unbind);
@@ -219,7 +224,7 @@ static ssize_t driver_bind(struct device_driver *drv,
 			err = -ENODEV;
 	}
 	put_device(dev);
-	put_bus(bus);
+	bus_put(bus);
 	return err;
 }
 static DRIVER_ATTR(bind, S_IWUSR, NULL, driver_bind);
@@ -459,7 +464,7 @@ out_subsys:
 out_id:
 	device_remove_attrs(bus, dev);
 out_put:
-	put_bus(dev->bus);
+	bus_put(dev->bus);
 	return error;
 }
 
@@ -509,7 +514,7 @@ void bus_remove_device(struct device * dev)
 		}
 		pr_debug("bus %s: remove device %s\n", dev->bus->name, dev->bus_id);
 		device_release_driver(dev);
-		put_bus(dev->bus);
+		bus_put(dev->bus);
 	}
 }
 
@@ -646,7 +651,7 @@ int bus_add_driver(struct device_driver *drv)
 out_unregister:
 	kobject_unregister(&drv->kobj);
 out_put_bus:
-	put_bus(bus);
+	bus_put(bus);
 	return error;
 }
 
@@ -671,7 +676,7 @@ void bus_remove_driver(struct device_driver * drv)
 	driver_detach(drv);
 	module_remove_driver(drv);
 	kobject_unregister(&drv->kobj);
-	put_bus(drv->bus);
+	bus_put(drv->bus);
 }
 
 
@@ -732,12 +737,6 @@ struct bus_type *get_bus(struct bus_type *bus)
 				struct bus_type, subsys) : NULL;
 }
 
-void put_bus(struct bus_type * bus)
-{
-	kset_put(&bus->subsys);
-}
-
-
 /**
  *	find_bus - locate bus by name.
  *	@name:	name of bus.
@@ -874,7 +873,7 @@ out:
  *	@bus:	bus.
  *
  *	Unregister the child subsystems and the bus itself.
- *	Finally, we call put_bus() to release the refcount
+ *	Finally, we call bus_put() to release the refcount
  */
 void bus_unregister(struct bus_type * bus)
 {
-- 
1.5.3.4

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 02/75] HOWTO: update ja_JP/HOWTO with latest changes, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 03/75] Driver core: make sysfs uevent-attributes static, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 04/75] Driver core: change add_uevent_var to use a ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 05/75] Driver core: add CONFIG_UEVENT_HELPER_PATH, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 06/75] Driver core: remove subsys_set_kset, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 07/75] Driver core: remove kset_set_kset_s, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 08/75] Driver core: remove subsys_put(), Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 09/75] Driver core: remove subsys_get(), Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 10/75] Driver core: remove put_bus(), Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 11/75] Driver core: remove get_bus(), Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 12/75] kobjects: fix up improper use of the kobject ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 13/75] cdev: remove unneeded setting of cdev names, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 14/75] Drivers: clean up direct setting of the name ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 15/75] kobject: remove the static array for the name, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 16/75] Driver core: clean up removed functions from ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 17/75] debugfs: helper for decimal challenged, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 18/75] sysfs/file.c - use mutex instead of semaphore, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 19/75] sysfs: cleanup semaphore.h, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 20/75] sysfs: Remove first pass at shadow directory ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 21/75] sysfs: cosmetic changes in sysfs_lookup(), Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 22/75] sysfs: simplify sysfs_rename_dir(), Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 23/75] sysfs: make sysfs_add/remove_one() call link ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 24/75] sysfs: make sysfs_add_one() automatically ch ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 25/75] sysfs: make sysfs_addrm_finish() return void, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 26/75] dmi-id: Use dynamic sysfs attributes, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 27/75] dmi-id: Possible cleanup, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 28/75] Convert from class_device to device for driv ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 29/75] Convert from class_device to device in drive ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 30/75] Driver core: exclude kobject_uevent.c for !C ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 31/75] Driver core: add uevent file for bus and driver, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 32/75] Driver core: kerneldoc - kobject_uevent_env ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 33/75] Fix Firmware class name collision, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 34/75] drivers/base/power/: make 2 functions static, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 35/75] sysfs: Fix typos in fs/sysfs/file.c, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 36/75] sysdev: remove global sysdev drivers list, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 37/75] Driver core: Make platform_device.id an int, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 38/75] sysfs: fix i_mutex locking in sysfs_get_dentry(), Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 39/75] sysfs: Move all of inode initialization into ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 40/75] sysfs: Remove sysfs_instantiate, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 41/75] sysfs: Use kill_anon_super, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 42/75] sysfs: Make sysfs_mount static, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 43/75] sysfs: In sysfs_lookup don't open code sysfs ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 44/75] sysfs: Simplify readdir., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 45/75] sysfs: Rewrite sysfs_drop_dentry., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 46/75] sysfs: Introduce sysfs_rename_mutex, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 47/75] sysfs: simply sysfs_get_dentry, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 48/75] sysfs: Remove s_dentry, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 49/75] sysfs: Rewrite rename in terms of sysfs dirents, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 50/75] sysfs: Rewrite sysfs_move_dir in terms of sy ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 51/75] PTY: add kernel parameter to overwrite legac ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 52/75] sysfs: spit a warning to users when they try ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 53/75] sysfs: fix comments of sysfs_add/remove_one(), Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 54/75] sysfs: fix sysfs_chmod_file() such that it u ..., Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 55/75] sysfs: clean up header files, Greg Kroah-Hartman, (Fri Oct 12, 3:16 pm)
[PATCH 56/75] sysfs: kill sysfs_update_file(), Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 57/75] sysfs: reposition sysfs_dirent-&gt;s_mode., Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 58/75] sysfs: kill unnecessary sysfs_get() in open ..., Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 59/75] sysfs: kill unnecessary NULL pointer check i ..., Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 60/75] sysfs: make bin attr open get active referen ..., Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 61/75] sysfs: make s_elem an anonymous union, Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 62/75] sysfs: open code sysfs_attach_dentry(), Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 63/75] sysfs: make sysfs_root a regular directory d ..., Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 65/75] sysfs: implement sysfs_open_dirent, Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 66/75] sysfs: move sysfs file poll implementation t ..., Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 67/75] driver core: remove subsystem_init(), Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 68/75] Driver core: rename ktype_class, Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 69/75] Driver core: rename ktype_device, Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 70/75] Driver core: rename ktype_driver, Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 71/75] Driver core: rename ktype_edd and ktype_efivar, Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 72/75] kset: add some kerneldoc to help describe wh ..., Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 73/75] kobject: update the copyrights, Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 74/75] sysfs: add copyrights, Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)
[PATCH 75/75] PM: merge device power-management source files, Greg Kroah-Hartman, (Fri Oct 12, 3:17 pm)