Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Kyle McMartin

Subject: Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON()

Date: Thursday, October 11, 2007 - 7:04 pm

On Fri, Oct 12, 2007 at 11:23:39AM +1000, Paul Mackerras wrote:
quoted text> Olof Johansson writes:
> 
> > Not using the ppc-specific WARN_ON/BUG_ON constructs actually saves about
> > 4K text on a ppc64_defconfig. The main reason seems to be that prepping
> > the arguments to the conditional trap instructions is more work than
> > just doing a compare and branch.
> 
> It might be more instructions but it takes fewer cycles, I would
> expect.  Do you have the actual instruction sequences to compare?
> 

I really hope WARN_ON/BUG_ON aren't hotpaths on powerpc. ;-)

Cheers,
	Kyle
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/2] bug.h: Introduce HAVE_ARCH_WARN, Olof Johansson, (Thu Oct 11, 10:12 am)

[PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON(), Olof Johansson, (Thu Oct 11, 10:14 am)

Re: [PATCH 1/2] bug.h: Introduce HAVE_ARCH_WARN, Kyle McMartin, (Thu Oct 11, 10:20 am)

Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON(), Scott Wood, (Thu Oct 11, 12:55 pm)

Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON(), Paul Mackerras, (Thu Oct 11, 6:23 pm)

Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON(), Kyle McMartin, (Thu Oct 11, 7:04 pm)

Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON(), Olof Johansson, (Thu Oct 11, 7:40 pm)

Re: [PATCH 2/2] powerpc: Switch to generic WARN_ON()/BUG_ON(), Olof Johansson, (Thu Oct 11, 7:41 pm)

Re: [PATCH 1/2] bug.h: Introduce HAVE_ARCH_WARN, Paul Mundt, (Thu Oct 11, 7:53 pm)

Re: [PATCH 1/2] bug.h: Introduce HAVE_ARCH_WARN, Andrew Morton, (Thu Oct 18, 3:17 pm)

Re: [PATCH 1/2] bug.h: Introduce HAVE_ARCH_WARN, Olof Johansson, (Thu Oct 18, 3:34 pm)

[PATCH v2] [1/2] bug.h: Remove HAVE_ARCH_BUG.* / HAVE_ARCH ..., Olof Johansson, (Thu Oct 18, 7:03 pm)

[PATCH v2] [2/2] powerpc: Switch to generic WARN_ON()/BUG_ON(), Olof Johansson, (Thu Oct 18, 7:03 pm)


linux-kernel:
Greg Kroah-Hartman	[PATCH 041/196] kobject: add kobject_init_and_add function
Lukas Hejtmanek	Re: Another libata error related to OCZ SSD
Greg Kroah-Hartman	[PATCH 023/196] MCP_UCB1200: Convert from class_device to device
Florian Fainelli	Re: System clock runs too fast after 2.6.27 -> 2.6.28.1 upgrade
Christoph Lameter	[patch 1/4] mmu_notifier: Core code
git:
Johannes Schindelin	Re: [PATCH 1/2] Add strbuf_initf()
John Bito	[EGIT] Push to GitHub caused corruption
Jakub Narebski	Re: [PATCH 0/2] gitweb: patch view
Junio C Hamano	Re: [PATCH] When a remote is added but not fetched, tell the user.
Andy Parkins	Re: [RFC] Submodules in GIT
git-commits-head:
Linux Kernel Mailing List	ahci: Workaround HW bug for SB600/700 SATA controller PMP support
Linux Kernel Mailing List	V4L/DVB (11086): au0828: rename macro for currently non-function VBI support
Linux Kernel Mailing List	ceph: client types
Linux Kernel Mailing List	ceph: on-wire types
Linux Kernel Mailing List	crypto: chainiv - Use kcrypto_wq instead of keventd_wq
linux-netdev:
Andrew Morton	Re: [Bugme-new] [Bug 14969] New: b44: WOL does not work in suspended state
Giuseppe CAVALLARO	Re: [PATCH 03/13] stmmac: add the new Header file for stmmac platform data
Taku Izumi	[PATCH 3/3] ixgbe: add registers etc. printout code just before resetting adapters
Eric Dumazet	rps: some comments
Thomas Gleixner	Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:
openbsd-misc:
Stephan Andreas	problems with login after xlock in OpenBSD release 4.7
pmc	Make A Change. Alcoholism and Drug Addiction Treatment
ropers	Re: what exactly is enc0?
Fuad NAHDI	Re: What does your environment look like?
Matthew Szudzik	Typo on OpenBSD 4.4 CD Set