login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
October
»
11
Re: [PATCH 1/2] x86: mce init optimization and signedness fixup
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Thomas Gleixner <tglx@...>
To: Christoph Egger <Christoph.Egger@...>
Cc: Joerg Roedel <joerg.roedel@...>, Linux Kernel Mailing List <linux-kernel@...>
Subject:
Re: [PATCH 1/2] x86: mce init optimization and signedness fixup
Date: Thursday, October 11, 2007 - 12:50 pm
On Thu, 11 Oct 2007, Christoph Egger wrote:
quoted text
> On Thursday 11 October 2007 16:55:36 Thomas Gleixner wrote: > > > > > + > > > > > + if (!cpu_has(c, X86_FEATURE_MCA) || !cpu_has(c, X86_FEATURE_MCE)) { > > > > > + printk(KERN_INFO "CPU%i: No machine check support available\n", > > > > > + smp_processor_id()); > > > > > + return; > > > > > > > > This breaks winchip MCE support. > > > > > > First, what is a winchip? It sounds to be something windows specific. ;) > > > Second, can you explain in which way MCE support gets broken, please? > > > > First, winchip is the code name of Centaurs early x86 cpus. > > > > Second, those beasts do not have FEATURE_MCA, but they have FEATURE_MCE, > > so they support the fatal exception, but not the non fatal check. > > So when I change the above code snippet to: > > + if (!cpu_has(c, X86_FEATURE_MCE)) { > + printk(KERN_INFO "CPU%i: No machine check support available\n", > + smp_processor_id()); > + return; > > Would this make the whole patch acceptable then?
Yeah, but then we can clean up the extra checks for _MCE in the various cpu type init functions as well. tglx -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 0/2] x86: MCE optimization and cleanups
, Joerg Roedel
, (Thu Oct 11, 8:17 am)
[PATCH 1/2] x86: mce init optimization and signedness fixup
, Joerg Roedel
, (Thu Oct 11, 8:17 am)
Re: [PATCH 1/2] x86: mce init optimization and signedness fi...
, Thomas Gleixner
, (Thu Oct 11, 9:51 am)
Re: [PATCH 1/2] x86: mce init optimization and signedness fi...
, Christoph Egger
, (Thu Oct 11, 10:01 am)
Re: [PATCH 1/2] x86: mce init optimization and signedness fi...
, Thomas Gleixner
, (Thu Oct 11, 10:55 am)
Re: [PATCH 1/2] x86: mce init optimization and signedness fi...
, Alan Cox
, (Thu Oct 11, 11:11 am)
Re: [PATCH 1/2] x86: mce init optimization and signedness fi...
, Christoph Egger
, (Thu Oct 11, 11:03 am)
Re: [PATCH 1/2] x86: mce init optimization and signedness fi...
, Alan Cox
, (Thu Oct 11, 3:55 pm)
Re: [PATCH 1/2] x86: mce init optimization and signedness fi...
, Thomas Gleixner
, (Thu Oct 11, 12:50 pm)
Re: [PATCH 1/2] x86: mce init optimization and signedness fi...
, Christoph Egger
, (Fri Oct 12, 3:44 am)
Re: [PATCH 1/2] x86: mce init optimization and signedness fi...
, Dave Jones
, (Thu Oct 11, 1:30 pm)
[PATCH 2/2] x86: mce minor indent cleanup
, Joerg Roedel
, (Thu Oct 11, 8:17 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Davide Libenzi
Re: [patch 7/8] fdmap v2 - implement sys_socket2
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
Greg Kroah-Hartman
[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Mariusz Kozlowski
[KJ PATCHES] mostly kmalloc + memset conversion to k[cz]alloc
git
:
linux-netdev
:
KOSAKI Motohiro
[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
Stefan Richter
Re: [GIT]: Networking
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 0/37] dccp: Feature negotiation - last call for comments
git-commits-head
:
Colocation donated by:
Who's online
There are currently
2 users
and
777 guests
online.
Online users
strcmp
zerhai30
Syndicate