Re: ARPM shutdown oops (Re: [stable] [patch 09/12] Fix SMP poweroff hangs)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Kevin <spaceman__spiff@...>
Cc: Greg KH <greg@...>, Olof Johansson <olof@...>, Greg KH <gregkh@...>, Rafael J. Wysocki <rjw@...>, Theodore Ts'o <tytso@...>, Zwane Mwaikambo <zwane@...>, Justin Forbes <jmforbes@...>, Linux Kernel Mailing List <linux-kernel@...>, Chris Wedgwood <reviews@...>, Domenico Andreoli <cavokz@...>, Mark Lord <mlord@...>, Randy Dunlap <rdunlap@...>, Michael Krufky <mkrufky@...>, Chuck Ebbert <cebbert@...>, Dave Jones <davej@...>, <akpm@...>, Chuck Wolber <chuckw@...>, <stable@...>, <alan@...>, BDFL <volkerdi@...>, Stephen Rothwell <sfr@...>
Date: Thursday, October 11, 2007 - 11:31 am

On Wed, 10 Oct 2007, Kevin wrote:

Ok, this is the real reason. 

The APM code does:

        if (PM_IS_ACTIVE()) {
                printk(KERN_NOTICE "apm: overridden by ACPI.\n");
                apm_info.disabled = 1;
                return -ENODEV;
        }

and in previous kernels that would notice that you have ACPI enabled, and 
APM gets shut out, and you never see your buggy APM BIOS.

In 2.6.23, this apparently doesn't happen for some reason.

And I think I see the problem: it's a config change. You don't have 
PM_LEGACY enabled. Your config file diff shows:

	-CONFIG_PM_LEGACY=y
	+# CONFIG_PM_LEGACY is not set

I suspect we should make CONFIG_APM either depend on, or select, 
PM_LEGACY. But as far as I can see, nothing has actually changed in this 
area in the kernel, and this bug has been there before - just your config 
change made it appear. 

Rafael? Stephen? Opinions? I'd think that making APM depend on 
CONFIG_PM_LEGACY is the right thing to do these days..

		Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: ARPM shutdown oops (Re: [stable] [patch 09/12] Fix SMP p..., Linus Torvalds, (Thu Oct 11, 11:31 am)
Re: APM shutdown oops (Re: [stable] [patch 09/12] Fix SMP po..., Rafael J. Wysocki, (Fri Oct 12, 8:05 am)
Re: ARPM shutdown oops (Re: [stable] [patch 09/12] Fix SMP p..., Rafael J. Wysocki, (Thu Oct 11, 4:55 pm)