m68k Kconfig undefined symbol in 2.6.23.

Previous thread: [GIT PATCHES] V4L/DVB changes for 2.6.24 by Mauro Carvalho Chehab on Wednesday, October 10, 2007 - 5:50 pm. (26 messages)

Next thread: [PATCH] Make m68k cross compile like every other architecture. by Rob Landley on Wednesday, October 10, 2007 - 6:22 pm. (21 messages)
To: Geert Uytterhoeven <geert@...>
Cc: <linux-kernel@...>
Date: Wednesday, October 10, 2007 - 6:19 pm

The m68k Kconfig tries to select a symbol (APM_EMULATION) that doesn't exist.

I did this to fix it, without really understanding the larger problem. (Did
APM go away?) Just FYI...

Rob

diff -r 79f0ea1e0e70 drivers/macintosh/Kconfig
--- a/drivers/macintosh/Kconfig Tue Oct 09 21:00:40 2007 +0000
+++ b/drivers/macintosh/Kconfig Wed Oct 10 17:17:07 2007 -0500
@@ -116,11 +116,6 @@ config PMAC_SMU
on the "SMU" system control chip which replaces the old PMU.
If you don't know, say Y.

-config PMAC_APM_EMU
- tristate "APM emulation"
- select APM_EMULATION
- depends on ADB_PMU && PM && PPC32
-
config PMAC_MEDIABAY
bool "Support PowerBook hotswap media bay"
depends on PPC_PMAC && PPC32

--
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
-

To: Rob Landley <rob@...>
Cc: Geert Uytterhoeven <geert@...>, <linux-kernel@...>
Date: Thursday, October 11, 2007 - 8:05 am

the obvious problem with the above is that APM_EMULATION is defined in
kernel/power/Kconfig arch-independently thusly:

config APM_EMULATION
tristate "Advanced Power Management Emulation"
depends on PM && SYS_SUPPORTS_APM_EMULATION
help
... blah blah ...

but the Kconfig variable SYS_SUPPORTS_APM_EMULATION is defined for
only a small subset of architectures:

$ grep "config SYS_SUPPORTS_APM_EMULATION" $(find . -name Kconfig*)
./arch/mips/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/sh/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/arm/Kconfig:config SYS_SUPPORTS_APM_EMULATION
./arch/powerpc/Kconfig:config SYS_SUPPORTS_APM_EMULATION

so there's a good chance that doing a kernel config with any other
arch than those listed above that supports PM is going to generate the
same warning.

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-

To: Rob Landley <rob@...>
Cc: <linux-kernel@...>
Date: Thursday, October 11, 2007 - 3:16 am

^^^^^
I.e. PPC, not m68k.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-

Previous thread: [GIT PATCHES] V4L/DVB changes for 2.6.24 by Mauro Carvalho Chehab on Wednesday, October 10, 2007 - 5:50 pm. (26 messages)

Next thread: [PATCH] Make m68k cross compile like every other architecture. by Rob Landley on Wednesday, October 10, 2007 - 6:22 pm. (21 messages)