Re: idio{,ma}tic typos (was Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alexey Dobriyan <adobriyan@...>
Cc: Al Viro <viro@...>, <linux-kernel@...>, <davej@...>, Pierre Ossman <drzeus@...>, <akpm@...>, <linux-sparse@...>
Date: Wednesday, October 10, 2007 - 9:35 am

> While we're at it, below is somewhat ugly sparse patch for detecting

Excellent idea, and there is something to be said about a low-footprint patch
like that.  However, if you really want to capture this kind of bugs, you would
need to have some kind "not a boolean" or "bitfield" attribute that
can propagate.
For example, you would want

    if (foo && (BAR | BAZ)) ...;

with BAR and BAZ being hex constants to produce the same warning.

Incidentally, it is probably not just hex constants that deserve this treatment:
octal constants and variations of (1 << cst) are of the same nature.  As well
as enums defined in such manners.

Morten
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: idio{,ma}tic typos (was Re: + fix-vm_can_nonlinear-check..., Morten Welinder, (Wed Oct 10, 9:35 am)