Hi Linus et al., 2.6.23 does not build with my usual .config on x86_64 and gcc-4.2.1: In file included from fs/drop_caches.c:8: include/linux/mm.h:1210: warning: 'struct super_block' declared inside parameter list nclude/linux/mm.h:1210: warning: its scope is only this definition or declaration, which is probably not what you want fs/drop_caches.c:17: error: conflicting types for 'drop_pagecache_sb' include/linux/mm.h:1210: error: previous declaration of 'drop_pagecache_sb' was here fs/drop_caches.c:28: error: conflicting types for 'drop_pagecache_sb' include/linux/mm.h:1210: error: previous declaration of 'drop_pagecache_sb' was here A little forward declaration fixes this: --- linux-2.6.23/include/linux/mm.h.vanilla 2007-10-10 09:28:33.000000000 +0200 +++ linux-2.6.23/include/linux/mm.h 2007-10-10 09:30:23.000000000 +0200 @@ -1207,6 +1207,7 @@ void __user *, size_t *, loff_t *); unsigned long shrink_slab(unsigned long scanned, gfp_t gfp_mask, unsigned long lru_pages); +struct super_block; extern void drop_pagecache_sb(struct super_block *); void drop_pagecache(void); void drop_slab(void); You probably end up fixing it some other way, but as I do not know this file inside out I just wanted to drop a note. Yours, René Rebe On Tuesday 09 October 2007 22:54:30 Linus Torvalds wrote:-- René Rebe - ExactCODE GmbH - Europe, Germany, Berlin http://exactcode.de | http://t2-project.org | http://rene.rebe.name -
| Linus Torvalds | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Artem Bityutskiy | [RFC PATCH 06/26] UBIFS: add superblock and master node |
| Joe Perches | [PATCH 001/148] include/asm-x86/acpi.h: checkpatch cleanups - formatting only |
| Linus Torvalds | Re: LSM conversion to static interface |
git: | |
| Alexey Dobriyan | Re: [GIT]: Networking |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Christoph Lameter | Network latency regressions from 2.6.22 to 2.6.29 |
