[PATCH 3/3] UML - Definitively kill subprocesses on panic

Previous thread: 2.6.23-rc8 build failure: __you_cannot_kmalloc_that_much in dmi_id_init by Jean Delvare on Monday, October 1, 2007 - 4:54 pm. (5 messages)

Next thread: -mm merge plans for 2.6.24 by Andrew Morton on Monday, October 1, 2007 - 5:22 pm. (111 messages)
To: Andrew Morton <akpm@...>
Cc: LKML <linux-kernel@...>, uml-devel <user-mode-linux-devel@...>, Lepton Wu <ytht.net@...>
Date: Monday, October 1, 2007 - 5:23 pm

From: Lepton Wu <ytht.net@gmail.com>

In a stock 2.6.22.6 kernel, poweroff a user mode linux guest
(2.6.22.6 running in skas0 mode) will halt the host linux. I
think the reason is the kernel thread abort because of a bug.
Then the sys_reboot in process of user mode linux guest is
not trapped by the user mode linux kernel and is executed by host.
I think it is better to make sure all of our children process
to quit when user mode linux kernel abort.

[ jdike - the kernel process needs to ignore SIGTERM, plus the
waitpid/kill loop is needed to make sure that all of our children
are dead before the kernel exits ]

Signed-off-by: Lepton Wu <ytht.net@gmail.com>
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
---
arch/um/os-Linux/skas/process.c | 2 +-
arch/um/os-Linux/util.c | 38 ++++++++++++++++++++++++++++++++++++++
2 files changed, 39 insertions(+), 1 deletion(-)

Index: linux-2.6.22/arch/um/os-Linux/util.c
===================================================================
--- linux-2.6.22.orig/arch/um/os-Linux/util.c 2007-10-01 15:11:14.000000000 -0400
+++ linux-2.6.22/arch/um/os-Linux/util.c 2007-10-01 17:04:34.000000000 -0400
@@ -105,6 +105,44 @@ int setjmp_wrapper(void (*proc)(void *,

void os_dump_core(void)
{
+ int pid;
+
signal(SIGSEGV, SIG_DFL);
+
+ /*
+ * We are about to SIGTERM this entire process group to ensure that
+ * nothing is around to run after the kernel exits. The
+ * kernel wants to abort, not die through SIGTERM, so we
+ * ignore it here.
+ */
+
+ signal(SIGTERM, SIG_IGN);
+ kill(0, SIGTERM);
+ /*
+ * Most of the other processes associated with this UML are
+ * likely sTopped, so give them a SIGCONT so they see the
+ * SIGTERM.
+ */
+ kill(0, SIGCONT);
+
+ /*
+ * Now, having sent signals to everyone but us, make sure they
+ * die by ptrace. Processes can survive what's been done to
+ * them so far - the mechanism I understand is receiving a
+ * SIGSEGV and segfaulting immediatel...

Previous thread: 2.6.23-rc8 build failure: __you_cannot_kmalloc_that_much in dmi_id_init by Jean Delvare on Monday, October 1, 2007 - 4:54 pm. (5 messages)

Next thread: -mm merge plans for 2.6.24 by Andrew Morton on Monday, October 1, 2007 - 5:22 pm. (111 messages)