Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Christoph Hellwig <hch@...>
Cc: Linus Torvalds <torvalds@...>, David Howells <dhowells@...>, <viro@...>, <akpm@...>, <linux-kernel@...>, <linux-fsdevel@...>
Date: Monday, October 1, 2007 - 2:18 pm

> 	return ERR_PTR(PTR_ERR(inode));

It seems like a pretty noisy way to get a (void *) cast :/.  Maybe a  
function that has the cast but makes sure it's only used for IS_ERR()  
pointers?

/* haha, continuing the fine tradition of terrible names in this  
api..  */
static inline void *PTR_PTR(void *err_ptr) {
	BUG_ON(!IS_ERR(err_ptr) || !err_ptr);
	return err_ptr;
}

Meh.

- z
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/30] Remove iget() and read_inode(), David Howells, (Mon Oct 1, 9:09 am)
[PATCH 18/30] IGET: Stop ISOFS from using read_inode(), David Howells, (Mon Oct 1, 9:10 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read..., Zach Brown, (Mon Oct 1, 2:18 pm)
[PATCH 03/30] IGET: Use iget_failed() in GFS2, David Howells, (Mon Oct 1, 9:09 am)
[PATCH 02/30] IGET: Use iget_failed() in AFS, David Howells, (Mon Oct 1, 9:09 am)