Home » Mailing list archives » linux-kernel » 2007 » October » 1

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds
Subject: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()
Date: Monday, October 1, 2007 - 11:19 am

On Mon, 1 Oct 2007, Christoph Hellwig wrote:

Ahh, ok. Then it actually makes sense. Although I'd prefer it if people 
planned on writing code like that more along the lines of

	error = PTR_ERR(inode);
	if (IS_ERR(inode)
		return ERR_PTR(error);

because let's face it, the compiler can turn this into nice code, and 
humans can read it much better even if it's got an "unnecessary" extra 
variable etc..

			Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/30] Remove iget() and read_inode(), David Howells, (Mon Oct 1, 6:09 am)
[PATCH 01/30] IGET: Introduce a function to register iget ..., David Howells, (Mon Oct 1, 6:09 am)
[PATCH 02/30] IGET: Use iget_failed() in AFS, David Howells, (Mon Oct 1, 6:09 am)
[PATCH 03/30] IGET: Use iget_failed() in GFS2, David Howells, (Mon Oct 1, 6:09 am)
[PATCH 04/30] IGET: Mark iget() and read_inode() as being ..., David Howells, (Mon Oct 1, 6:09 am)
[PATCH 05/30] IGET: Stop AFFS from using iget() and read_i ..., David Howells, (Mon Oct 1, 6:09 am)
[PATCH 06/30] IGET: Stop autofs from using iget() and read ..., David Howells, (Mon Oct 1, 6:09 am)
[PATCH 07/30] IGET: Stop BEFS from using iget() and read_i ..., David Howells, (Mon Oct 1, 6:09 am)
[PATCH 08/30] IGET: Stop BFS from using iget() and read_in ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 09/30] IGET: Stop CIFS from using iget() and read_i ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 10/30] IGET: Stop EFS from using iget() and read_in ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 11/30] IGET: Stop EXT2 from using iget() and read_i ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 12/30] IGET: Stop EXT3 from using iget() and read_i ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 13/30] IGET: Stop EXT4 from using iget() and read_i ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 14/30] IGET: Stop FAT from using iget() and read_in ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 15/30] IGET: Stop FreeVXFS from using iget() and re ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 16/30] IGET: Stop FUSE from using iget() and read_i ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 17/30] IGET: Stop HFSPLUS from using iget() and rea ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 18/30] IGET: Stop ISOFS from using read_inode(), David Howells, (Mon Oct 1, 6:10 am)
[PATCH 19/30] IGET: Stop JFFS2 from using iget() and read_ ..., David Howells, (Mon Oct 1, 6:10 am)
[PATCH 20/30] IGET: Stop JFS from using iget() and read_in ..., David Howells, (Mon Oct 1, 6:11 am)
[PATCH 21/30] IGET: Stop the MINIX filesystem from using i ..., David Howells, (Mon Oct 1, 6:11 am)
[PATCH 22/30] IGET: Stop PROCFS from using iget() and read ..., David Howells, (Mon Oct 1, 6:11 am)
[PATCH 23/30] IGET: Stop QNX4 from using iget() and read_i ..., David Howells, (Mon Oct 1, 6:11 am)
[PATCH 24/30] IGET: Stop ROMFS from using iget() and read_ ..., David Howells, (Mon Oct 1, 6:11 am)
[PATCH 25/30] IGET: Stop the SYSV filesystem from using ig ..., David Howells, (Mon Oct 1, 6:11 am)
[PATCH 26/30] IGET: Stop UFS from using iget() and read_in ..., David Howells, (Mon Oct 1, 6:11 am)
[PATCH 27/30] IGET: Stop OPENPROMFS from using iget() and ..., David Howells, (Mon Oct 1, 6:11 am)
[PATCH 28/30] IGET: Stop HOSTFS from using iget() and read ..., David Howells, (Mon Oct 1, 6:11 am)
[PATCH 29/30] IGET: Stop HPPFS from using iget() and read_ ..., David Howells, (Mon Oct 1, 6:11 am)
[PATCH 30/30] IGET: Remove iget() and the read_inode() sup ..., David Howells, (Mon Oct 1, 6:11 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ..., Zach Brown, (Mon Oct 1, 10:39 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ..., Linus Torvalds, (Mon Oct 1, 10:44 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ..., Christoph Hellwig, (Mon Oct 1, 11:06 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ..., Zach Brown, (Mon Oct 1, 11:18 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ..., Linus Torvalds, (Mon Oct 1, 11:19 am)
Re: [PATCH 20/30] IGET: Stop JFS from using iget() and rea ..., Dave Kleikamp, (Mon Oct 1, 11:44 am)
Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and re ..., Jan Kara, (Tue Oct 2, 3:06 am)
Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and re ..., Jan Kara, (Tue Oct 2, 3:24 am)
Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and re ..., Jan Kara, (Tue Oct 2, 3:28 am)
Re: [PATCH 13/30] IGET: Stop EXT4 from using iget() and re ..., Jan Kara, (Tue Oct 2, 5:26 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ..., David Howells, (Tue Oct 2, 5:32 am)
Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and re ..., David Howells, (Tue Oct 2, 5:58 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ..., Dave Kleikamp, (Tue Oct 2, 6:02 am)
Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and re ..., David Howells, (Tue Oct 2, 6:16 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ..., David Howells, (Tue Oct 2, 6:24 am)
Re: [PATCH 13/30] IGET: Stop EXT4 from using iget() and re ..., David Howells, (Tue Oct 2, 6:37 am)
Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and re ..., Dave Kleikamp, (Tue Oct 2, 7:16 am)