Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode() | KernelTrap

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Linus Torvalds <torvalds@...>

To: Zach Brown <zab@...>

Cc: David Howells <dhowells@...>, <hch@...>, <viro@...>, <akpm@...>, <linux-kernel@...>, <linux-fsdevel@...>

Subject: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

Date: Monday, October 1, 2007 - 1:44 pm

On Mon, 1 Oct 2007, Zach Brown wrote:
quoted text>
> If you're soliciting opinions, I think I tend to prefer the feel of the
> code paths after the changes.  I don't know the benefits of the change
> are worth the risk in unmaintained file systems, though.
> 
> > +		return ERR_PTR(PTR_ERR(inode));
> 
> This caught my eye.  Surely we can do better :).  It seems to happen a
> few times in the patches, the instance in this patch was the first that
> I noticed.

Yeah. The above obviously *should* be the same as

	return inode;

apart from a few casts. But if the casts matter, there's something else 
wrong.

		Linus
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/30] Remove iget() and read_inode(), David Howells, (Mon Oct 1, 9:09 am)

[PATCH 30/30] IGET: Remove iget() and the read_inode() super..., David Howells, (Mon Oct 1, 9:11 am)

[PATCH 29/30] IGET: Stop HPPFS from using iget() and read_in..., David Howells, (Mon Oct 1, 9:11 am)

[PATCH 28/30] IGET: Stop HOSTFS from using iget() and read_i..., David Howells, (Mon Oct 1, 9:11 am)

[PATCH 27/30] IGET: Stop OPENPROMFS from using iget() and re..., David Howells, (Mon Oct 1, 9:11 am)

[PATCH 26/30] IGET: Stop UFS from using iget() and read_inod..., David Howells, (Mon Oct 1, 9:11 am)

[PATCH 25/30] IGET: Stop the SYSV filesystem from using iget..., David Howells, (Mon Oct 1, 9:11 am)

[PATCH 24/30] IGET: Stop ROMFS from using iget() and read_in..., David Howells, (Mon Oct 1, 9:11 am)

[PATCH 23/30] IGET: Stop QNX4 from using iget() and read_ino..., David Howells, (Mon Oct 1, 9:11 am)

[PATCH 22/30] IGET: Stop PROCFS from using iget() and read_i..., David Howells, (Mon Oct 1, 9:11 am)

[PATCH 21/30] IGET: Stop the MINIX filesystem from using ige..., David Howells, (Mon Oct 1, 9:11 am)

[PATCH 20/30] IGET: Stop JFS from using iget() and read_inod..., David Howells, (Mon Oct 1, 9:11 am)

Re: [PATCH 20/30] IGET: Stop JFS from using iget() and read_..., Dave Kleikamp, (Mon Oct 1, 2:44 pm)

[PATCH 19/30] IGET: Stop JFFS2 from using iget() and read_in..., David Howells, (Mon Oct 1, 9:10 am)

[PATCH 18/30] IGET: Stop ISOFS from using read_inode(), David Howells, (Mon Oct 1, 9:10 am)

[PATCH 17/30] IGET: Stop HFSPLUS from using iget() and read_..., David Howells, (Mon Oct 1, 9:10 am)

[PATCH 16/30] IGET: Stop FUSE from using iget() and read_ino..., David Howells, (Mon Oct 1, 9:10 am)

[PATCH 15/30] IGET: Stop FreeVXFS from using iget() and read..., David Howells, (Mon Oct 1, 9:10 am)

[PATCH 14/30] IGET: Stop FAT from using iget() and read_inod..., David Howells, (Mon Oct 1, 9:10 am)

[PATCH 13/30] IGET: Stop EXT4 from using iget() and read_ino..., David Howells, (Mon Oct 1, 9:10 am)

Re: [PATCH 13/30] IGET: Stop EXT4 from using iget() and read..., Jan Kara, (Tue Oct 2, 8:26 am)

Re: [PATCH 13/30] IGET: Stop EXT4 from using iget() and read..., David Howells, (Tue Oct 2, 9:37 am)

[PATCH 12/30] IGET: Stop EXT3 from using iget() and read_ino..., David Howells, (Mon Oct 1, 9:10 am)

Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and read..., Jan Kara, (Tue Oct 2, 6:28 am)

Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and read..., Jan Kara, (Tue Oct 2, 6:24 am)

Re: [PATCH 12/30] IGET: Stop EXT3 from using iget() and read..., David Howells, (Tue Oct 2, 9:16 am)

[PATCH 11/30] IGET: Stop EXT2 from using iget() and read_ino..., David Howells, (Mon Oct 1, 9:10 am)

Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read..., Jan Kara, (Tue Oct 2, 6:06 am)

Re: [PATCH 11/30] IGET: Stop EXT2 from using iget() and read..., David Howells, (Tue Oct 2, 8:58 am)

[PATCH 10/30] IGET: Stop EFS from using iget() and read_inod..., David Howells, (Mon Oct 1, 9:10 am)

[PATCH 09/30] IGET: Stop CIFS from using iget() and read_ino..., David Howells, (Mon Oct 1, 9:10 am)

[PATCH 08/30] IGET: Stop BFS from using iget() and read_inod..., David Howells, (Mon Oct 1, 9:10 am)

[PATCH 07/30] IGET: Stop BEFS from using iget() and read_ino..., David Howells, (Mon Oct 1, 9:09 am)

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read..., Zach Brown, (Mon Oct 1, 1:39 pm)

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read..., Linus Torvalds, (Mon Oct 1, 1:44 pm)

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read..., Christoph Hellwig, (Mon Oct 1, 2:06 pm)

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read..., Zach Brown, (Mon Oct 1, 2:18 pm)

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read..., David Howells, (Tue Oct 2, 8:32 am)

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read..., Dave Kleikamp, (Tue Oct 2, 9:02 am)

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read..., David Howells, (Tue Oct 2, 9:24 am)

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read..., Dave Kleikamp, (Tue Oct 2, 10:16 am)

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read..., Linus Torvalds, (Mon Oct 1, 2:19 pm)

[PATCH 06/30] IGET: Stop autofs from using iget() and read_i..., David Howells, (Mon Oct 1, 9:09 am)

[PATCH 05/30] IGET: Stop AFFS from using iget() and read_ino..., David Howells, (Mon Oct 1, 9:09 am)

[PATCH 04/30] IGET: Mark iget() and read_inode() as being ob..., David Howells, (Mon Oct 1, 9:09 am)

[PATCH 03/30] IGET: Use iget_failed() in GFS2, David Howells, (Mon Oct 1, 9:09 am)

[PATCH 02/30] IGET: Use iget_failed() in AFS, David Howells, (Mon Oct 1, 9:09 am)

[PATCH 01/30] IGET: Introduce a function to register iget fa..., David Howells, (Mon Oct 1, 9:09 am)

Navigation

Popular discussions


linux-kernel:
Justin C. Sherrill	Re: pkgsrc bulk build and tiff
Linus Torvalds	Linux 2.6.27-rc5
Ingo Molnar	[crash, bisected] Kernel BUG at ffffffff8079afb1 (__netif_schedule())
Greg KH	[GIT PATCH] driver core patches against 2.6.24
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Evgeniy Polyakov	Re: tbench wrt. loopback TSO
openbsd-misc:

Colocation donated by:

Who's online

There are currently 2 users and 825 guests online.

Online users

Syndicate