Re: [PATCH] removes array_size duplicates

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Andrew Morton <akpm@...>

Cc: roel <12o3l@...>, lkml <linux-kernel@...>

Subject: Re: [PATCH] removes array_size duplicates

Date: Monday, October 1, 2007 - 5:55 am

On Mon, 1 Oct 2007, Robert P. J. Day wrote:

...
quoted text> among other things, one of the creepy issues here is the definition in
> include/linux/netfilter/xt_sctp.h of the macro:
>
> ...
> #define SCTP_CHUNKMAP_COPY(destmap, srcmap)                     \
>         do {                                                    \
>                 int i;                                          \
>                 for (i = 0; i < ELEMCOUNT(chunkmap); i++)       \
                                            ^^^^^^^^
                                            srcmap??

quoted text>                         destmap[i] = srcmap[i];                 \
>         } while (0)
> ...
>

whoops, i take it back ... isn't this just a flat-out error, where the
macro should be written with the correction above?

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] removes array_size duplicates, roel, (Thu Sep 27, 6:51 pm)

Re: [PATCH] removes array_size duplicates, Andrew Morton, (Mon Oct 1, 5:26 am)

Re: [PATCH] removes array_size duplicates, Robert P. J. Day, (Mon Oct 1, 5:48 am)

Re: [PATCH] removes array_size duplicates, Robert P. J. Day, (Mon Oct 1, 5:55 am)

Re: [PATCH] removes array_size duplicates, Geert Uytterhoeven, (Mon Oct 1, 5:33 am)

Re: [PATCH] removes array_size duplicates, Andrew Morton, (Mon Oct 1, 5:39 am)


linux-kernel:
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Amit K. Arora	[RFC] Heads up on sys_fallocate()
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
git:

linux-netdev:
David Miller	[GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc:

Re: [PATCH] removes array_size duplicates

Online users