Re: [PATCH] include/linux/slab.h: new KFREE() macro.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Valdis.Kletnieks
Date: Tuesday, January 9, 2007 - 3:57 pm

On Tue, 09 Jan 2007 11:02:35 PST, Amit Choudhary said:

char *broken() {
	char *x, *y;
	x = kmalloc(100);
	y = x;
	kfree(x);
	x = NULL;
	return y;
}

Setting x to NULL doesn't do anything to fix the *real* bug here, because
the problematic reference is held in y, not x.  So you never get a crash
because somebody dereferences x.
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Sun Jan 7, 1:46 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Christoph Hellwig, (Sun Jan 7, 3:24 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Sun Jan 7, 3:43 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Vadim Lobanov, (Sun Jan 7, 4:22 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Sun Jan 7, 5:02 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Vadim Lobanov, (Sun Jan 7, 7:35 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Sun Jan 7, 9:09 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Vadim Lobanov, (Mon Jan 8, 12:04 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Mon Jan 8, 12:29 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Pekka Enberg, (Mon Jan 8, 1:00 am)
RE: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Mon Jan 8, 1:05 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Vadim Lobanov, (Mon Jan 8, 1:15 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Mon Jan 8, 1:31 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Sumit Narayan, (Mon Jan 8, 1:39 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Robert P. J. Day, (Mon Jan 8, 1:44 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Pekka Enberg, (Mon Jan 8, 1:45 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Mon Jan 8, 1:47 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Mon Jan 8, 1:56 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Mon Jan 8, 2:06 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Pekka Enberg, (Mon Jan 8, 2:26 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Jesper Juhl, (Mon Jan 8, 4:10 am)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Valdis.Kletnieks, (Mon Jan 8, 3:43 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Tue Jan 9, 12:02 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Randy Dunlap, (Tue Jan 9, 12:19 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Valdis.Kletnieks, (Tue Jan 9, 3:57 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Tue Jan 9, 5:00 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Valdis.Kletnieks, (Tue Jan 9, 7:43 pm)
Re: [PATCH] include/linux/slab.h: new KFREE() macro., Amit Choudhary, (Tue Jan 9, 9:57 pm)