Home » Mailing list archives » linux-kernel » 2007 » January » 8

Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton <akpm@...>
To: Oleg Nesterov <oleg@...>
Cc: <vatsa@...>, David Howells <dhowells@...>, Christoph Hellwig <hch@...>, Ingo Molnar <mingo@...>, Linus Torvalds <torvalds@...>, <linux-kernel@...>, Gautham shenoy <ego@...>
Subject: Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;worklist
Date: Monday, January 8, 2007 - 7:54 pm

Just a sad little note that I've utterly lost the plot on the workqueue
changes.

schedule_on_each_cpu-use-preempt_disable.patch
reimplement-flush_workqueue.patch
implement-flush_work.patch
implement-flush_work-sanity.patch
implement-flush_work_keventd.patch
flush_workqueue-use-preempt_disable-to-hold-off-cpu-hotplug.patch
flush_cpu_workqueue-dont-flush-an-empty-worklist.patch
aio-use-flush_work.patch
kblockd-use-flush_work.patch
relayfs-use-flush_keventd_work.patch
tg3-use-flush_keventd_work.patch
e1000-use-flush_keventd_work.patch
libata-use-flush_work.patch
phy-use-flush_work.patch
#bridge-avoid-using-noautorel-workqueues.patch
#
extend-notifier_call_chain-to-count-nr_calls-made.patch
extend-notifier_call_chain-to-count-nr_calls-made-fixes.patch
extend-notifier_call_chain-to-count-nr_calls-made-fixes-2.patch
define-and-use-new-eventscpu_lock_acquire-and-cpu_lock_release.patch
define-and-use-new-eventscpu_lock_acquire-and-cpu_lock_release-fix.patch
eliminate-lock_cpu_hotplug-in-kernel-schedc.patch
eliminate-lock_cpu_hotplug-in-kernel-schedc-fix.patch
handle-cpu_lock_acquire-and-cpu_lock_release-in-workqueue_cpu_callback.patch
fix-flush_workqueue-vs-cpu_dead-race.patch

I don't know which of these are good, bad or indifferent.

Furthermore I don't know which of these need to be tossed overboard if/when
we get around to using the task freezer for CPU hotplug synchronisation. 
Hopefully, a lot of them.  I don't really understand why we're continuing
to struggle with the existing approach before that question is settled.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [PATCH, RFC] reimplement flush_workqueue(), Srivatsa Vaddagiri, (Thu Jan 4, 7:32 am)
Re: [PATCH, RFC] reimplement flush_workqueue(), Oleg Nesterov, (Thu Jan 4, 10:29 am)
Re: [PATCH, RFC] reimplement flush_workqueue(), Srivatsa Vaddagiri, (Thu Jan 4, 11:56 am)
Re: [PATCH, RFC] reimplement flush_workqueue(), Oleg Nesterov, (Thu Jan 4, 12:31 pm)
Re: [PATCH, RFC] reimplement flush_workqueue(), Srivatsa Vaddagiri, (Thu Jan 4, 12:57 pm)
Re: [PATCH, RFC] reimplement flush_workqueue(), Andrew Morton, (Thu Jan 4, 1:18 pm)
[PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Sat Jan 6, 11:10 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Sat Jan 6, 11:45 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Sat Jan 6, 12:30 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Sat Jan 6, 12:38 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Sat Jan 6, 1:34 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Sun Jan 7, 6:43 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Sun Jan 7, 8:56 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Sun Jan 7, 12:21 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Sun Jan 7, 1:09 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Sun Jan 7, 10:22 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Sun Jan 7, 12:43 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Sun Jan 7, 1:18 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Sun Jan 7, 1:01 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Sun Jan 7, 1:33 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Sun Jan 7, 10:42 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Andrew Morton, (Sat Jan 6, 3:11 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Sun Jan 7, 7:00 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Andrew Morton, (Sun Jan 7, 3:59 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Mon Jan 8, 11:37 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Sun Jan 7, 5:51 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Mon Jan 8, 11:22 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Mon Jan 8, 11:56 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Mon Jan 8, 12:31 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Mon Jan 8, 1:06 pm)
RE: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Pallipadi, Venkatesh, (Mon Jan 8, 2:37 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Mon Jan 8, 9:11 pm)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Srivatsa Vaddagiri, (Tue Jan 9, 12:39 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Oleg Nesterov, (Tue Jan 9, 10:38 am)
[PATCH] flush_cpu_workqueue: don't flush an empty -&gt;worklist, Oleg Nesterov, (Sun Jan 7, 5:01 pm)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty ->w..., Andrew Morton, (Mon Jan 8, 7:54 pm)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Srivatsa Vaddagiri, (Tue Jan 9, 1:04 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Andrew Morton, (Tue Jan 9, 1:26 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Oleg Nesterov, (Tue Jan 9, 11:07 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Srivatsa Vaddagiri, (Tue Jan 9, 11:59 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Oleg Nesterov, (Tue Jan 9, 12:38 pm)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Srivatsa Vaddagiri, (Tue Jan 9, 12:46 pm)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Oleg Nesterov, (Tue Jan 9, 12:56 pm)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Oleg Nesterov, (Sun Jan 14, 7:54 pm)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Srivatsa Vaddagiri, (Mon Jan 15, 12:33 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Oleg Nesterov, (Mon Jan 15, 8:54 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Srivatsa Vaddagiri, (Mon Jan 15, 12:18 pm)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Oleg Nesterov, (Mon Jan 15, 9:08 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Srivatsa Vaddagiri, (Tue Jan 9, 5:33 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Ingo Molnar, (Tue Jan 9, 5:44 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Andrew Morton, (Tue Jan 9, 5:51 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Srivatsa Vaddagiri, (Tue Jan 9, 6:09 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Andrew Morton, (Tue Jan 9, 6:15 am)
Re: [PATCH] flush_cpu_workqueue: don't flush an empty -&gt;w..., Ingo Molnar, (Tue Jan 9, 2:56 am)
Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update, Ingo Molnar, (Sat Jan 6, 3:13 pm)
Re: [PATCH, RFC] reimplement flush_workqueue(), Srivatsa Vaddagiri, (Fri Jan 5, 4:56 am)
Re: [PATCH, RFC] reimplement flush_workqueue(), Oleg Nesterov, (Fri Jan 5, 8:42 am)
Re: [PATCH, RFC] reimplement flush_workqueue(), Srivatsa Vaddagiri, (Sat Jan 6, 11:11 am)
Re: [PATCH, RFC] reimplement flush_workqueue(), Oleg Nesterov, (Thu Jan 4, 2:09 pm)
Re: [PATCH, RFC] reimplement flush_workqueue(), Andrew Morton, (Thu Jan 4, 2:31 pm)
Re: [PATCH, RFC] reimplement flush_workqueue(), Srivatsa Vaddagiri, (Fri Jan 5, 5:03 am)
Re: [PATCH, RFC] reimplement flush_workqueue(), Oleg Nesterov, (Fri Jan 5, 10:07 am)
Re: [PATCH, RFC] reimplement flush_workqueue(), Srivatsa Vaddagiri, (Sat Jan 6, 11:24 am)