| From | Subject | Date |
|---|---|---|
| Ioan Ionita | Re: PATA_SIS and SIS 5513
Sorry for the delay. Here's the full dmesg as requested. Please don't
take into account the nvidia module, as this occurs with or without it
loaded. Thanks
| Jan 7, 4:52 pm 2007 |
| Robert P. J. Day | [PATCH] Remove a couple final references to obsolete ver ...
Remove a couple final references to the obsolete verify_area() call,
which was long ago replaced by access_ok().
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
---
it *appears* that these last two references can be removed, unless
there's something really strange i'm not seeing here.
include/asm-avr32/checksum.h | 2 +-
include/asm-avr32/uaccess.h | 6 ------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/include/asm-avr32/checksum.h ...
| Jan 7, 4:43 pm 2007 |
| David Chinner | Re: xfslogd-spinlock bug?
Different corruption in RBX here. Looks like semi-random garbage there.
I wonder - what's the mac and ip address(es) of your machine and nbd
servers?
(i.e. I suspect this is a nbd problem, not an XFS problem)
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
| Jan 7, 4:14 pm 2007 |
| Mikael Pettersson | Re: [PATCH libata #promise-sata-pata] sata_promise: 2037 ...
Update: SATAPI works on first-generation chips, but only in PIO mode.
To verify that DMA doesn't work I also tried Promise's pdc-ultra
driver for their first-generation chips. It doesn't want to support
ATAPI without an explicit option. Enabling that option makes it
recognise ATAPI devices, but even a simple "eject" command triggers
command timeouts and eventually a kernel oops due to the NMI watchdog.
So I'm fairly sure that DMA simply doesn't work.
This patch enables ATAPI on 20319 and ...
| Jan 7, 3:39 pm 2007 |
| Philippe De Muyter | Re: RTC subsystem and fractions of seconds
That is true if kernel's idea of an RTC's precision is 1 second. With better
RTC's (e.g. m41t81) this delay can be reduced to 0.01 second, which is
acceptable IMHO in the boot phase. That needs however changes in the kernel
interface to RTC's :
- read_time should take a new parameter *nsec (or struct rtc_time should
contain a new nsec field, so that the RTC can report its complete time
information to the kernel.
- struct rtc_device (or rtc_class_ops with another name) ...
| Jan 7, 3:31 pm 2007 |
| public | Preemption patches available in main stream
Hello,
sorry to ask, will the preemption patches of Ingo Molnar come into the
mainstream kernel? Or is this already the case?
Gtx
Carl.
-
| Jan 7, 2:58 pm 2007 |
| Jan Engelhardt | [announce] chaostables 0.4
[Not sure if netfilter/nmap-dev bounce when you are not subscribed,
remove if in doubt.]
Hello lists,
chaostables 0.4 has been released. This is a package containing some
netfilter modules to work against nmap and port scans. 'portscan' can
match on stealth, syn, connect scans, also finds FIN-connect scans and
simple banner grabbing. 'DELUDE' works like TARPIT, making it look like
the port is open, but actually does not hold the connection like TARPIT,
hence should not fill up ...
| Jan 7, 12:55 pm 2007 |
| Jesse Barnes | Re: [PATCH] update MMConfig patches w/915 support
For reference, here's the probe routine I tried for 965, probably something
dumb wrong with it that I'm not seeing atm.
static __init const char *pci_mmcfg_intel_965(void)
{
u64 pciexbar, mask = 0, len = 0;
u32 lo, hi;
pci_mmcfg_config_num = 1;
pci_conf1_read(0, 0, PCI_DEVFN(0,0), 0x60, 4, &lo);
pci_conf1_read(0, 0, PCI_DEVFN(0,0), 0x64, 4, &hi);
pciexbar = ((u64)hi << 32) | lo;
/* Enable bit */
if (!(pciexbar & 1))
pci_mmcfg_config_num = 0;
/* Size bits */
switch ...
| Jan 7, 12:44 pm 2007 |
| Jesse Barnes | [PATCH] update MMConfig patches w/915 support
This patch updates Oliver's MMConfig bridge detection patches with support
for 915G bridges. It seems to work ok on my 915GM laptop.
I also tried adding 965 support, but it doesn't work (at least not on my
G965 box). When I enable MMConfig support when the register value is
0xf00000003 (should be a 256M enabled window at 0xf0000000) the box hangs
at boot, so I'm not sure what I'm doing wrong...
The routines could probably be consolidated into a single probe_intel_9xx
routine or something, ...
| Jan 7, 12:42 pm 2007 |
| Linus Torvalds | Re: How git affects kernel.org performance
Won't help. ext3 does NO readahead at all. It doesn't use the general VFS
helper routines to read data (because it doesn't use the page cache), it
just does the raw buffer-head IO directly.
(In the non-indexed case, it does do some read-ahead, and it uses the
generic routines for it, but because it does everything by physical
address, even the generic routines will decide that it's just doing random
reading if the directory isn't physically contiguous - and stop reading ...
| Jan 7, 12:35 pm 2007 |
| Johnicholas Hines | a lttng success story
Hi.
I was really pleased to find an intermittent timing problem using
lttng, and maybe an example of how it can be used would be helpful to
people considering adopting it.
The system is a veterinary testing machine running Linux on an ARM
board (specifically the applied data systems sphere).
The symptom was that, under a certain workload, intermittently, a
timing constraint was being violated. Setting the processes to debug
mode (spitting out lots of messages) was too slow - many ...
| Jan 7, 11:25 am 2007 |
| saeed bishara | Re: using splice/vmsplice to improve file receive performance
I found that when doing free to the buffer after the vmsplice and
befaore the splice syscall, the page is really moved without any
memcpy, this means the flow of my application should be:
- malloc aligned buffer
- fill the buffer with the desired data
- vmsplice
- free the buffer
- call splice.
but I still don't get I improvements, and when profing the kernel I
see _clear_user_page() too often, I guess this function called to
clean the new buffers allocated by the user, for securty and ...
| Jan 7, 11:16 am 2007 |
| Alan Stern | Kwatch patch available for 2.6.20?
Has the kwatch patch (hardware watchpooint debugging for x86) been updated
to the current kernel? Is it available anywhere?
Thank you,
Alan Stern
-
| Jan 7, 11:00 am 2007 |
| Andreas Hartmann | [2.6.18.2] ide_core oops
Hello,
the following oops appears, after these actions took place:
1. Booting the notebook.
2. Loading ide_core with putting in a USB stick and mounting the
filesystem onto it.
3. Remove securely the usb stick.
4. suspend the machine.
5. resume the machine.
6. Do a modprobe ide_core again. Afterwards you can see this oops:
notebook1:~ # ksymoops <oops
ksymoops 2.4.11 on i686 2.6.18.2-34-default. Options used
-V (default)
-k /proc/kallsyms (default)
-l /proc/modules ...
| Jan 7, 11:01 am 2007 |
| Andreas Hartmann | [2.6.18.2] ide_core bug: kobject_add failed for ide ...
Hello,
ide_core is loaded (while putting in an USB stick) as module the first
time after reboot - all works fine. The USB stick got mounted and a ls
is done to show the files on the root of the filesystem of the stick.
Afterwards, the stick is securely removed from the system.
Afterwards, ide_core is unloaded with rmmod (after usb-storage has been
unloaded) - ok.
Next step is to load ide_core again. Now, the following error can be
found in /var/log/messages:
Jan 7 11:48:18 notebook1 ...
| Jan 7, 10:44 am 2007 |
| Lee Revell | Re: [2.6.18.2] ide_core bug: kobject_add failed for ide ...
You seem to be running a SuSE kernel - please report the issue to them.
It's probably useful to repeat your test but run "find /sys/module >
sys1" before loading ide_core the first time, then "find /sys/module >
sys2" after "rmmod ide_core", and save the output of "diff sys1 sys2".
Lee
-
| Jan 7, 12:05 pm 2007 |
| Dave Jones | Re: page_mapcount(page) went negative
On Tue, Dec 19, 2006 at 04:20:37PM +1100, Nick Piggin wrote:
> Dave Jones wrote:
>
> > Eeek! page_mapcount(page) went negative! (-2)
>
> Hmm, probably happened once before, too.
>
> > page->flags = 404
>
> What's that? PG_referenced|PG_reserved? So I'd say it is likely
> that some driver has got its refcounting wrong.
>
> Unfortunately, this debugging output is almost useless when it
> comes to trying to track down the problem any further.
>
> And I see we've got ...
| Jan 7, 10:36 am 2007 |
| Daniel Walker | crash on CONFIG_CFAG12864B=y in 2.6.20-rc3-mm1
(forgot to CC LKML)
The options,
CONFIG_CFAG12864B=y
CONFIG_CFAG12864B_RATE=20
causes a crash at boot in 2.6.20-rc3-mm1. I don't have the hardware
associated with the options. It looks like it just doesn't have guards
to detect if the hardware doesn't exists.
Here is the crash,
ks0108: ERROR: parport didn't find 888 port
BUG: unable to handle kernel NULL pointer dereference at virtual address 0000004 printing eip:
c02dbff9
*pde = 00000000
Oops: 0000 [#1]
PREEMPT SMP
last sysfs ...
| Jan 7, 9:55 am 2007 |
| Malte | 2.6.20-rc4 BUG: at mm/truncate.c:60 cancel_dirty_page()
--Boundary-01=_YSSoF0U4ckRLd3h
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Hello,
I just saw this in my syslog:
[ 1302.877455] BUG: at mm/truncate.c:60 cancel_dirty_page()
[ 1302.877563] [<c0137371>] cancel_dirty_page+0x45/0x7b
[ 1302.877673] [<df944b18>] reiserfs_cut_from_item+0x7cc/0x7fd [reiserfs]
[ 1302.878000] [<c01e5eba>] __kfree_skb+0x9b/0xf7
[ 1302.878097] [<df9316a0>] make_cpu_key+0x3f/0x46 ...
| Jan 7, 9:49 am 2007 |
| James Bottomley | [GIT PATCH] scsi bug fixes for 2.6.20-rc4
This is mainly bug fixes, although there are a few harmless updates
(like email addresses and driver PCI IDs). The patch is available here:
master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6
The Short Changelog is:
adam radford (1):
3ware 8000 serialize reset code
Adrian Bunk (1):
qla2xxx: make qla2x00_reg_remote_port() static
Akinobu Mita (1):
iscsi: fix crypto_alloc_hash() error check
Andrew Vasquez (9):
qla2xxx: Update version number ...
| Jan 7, 9:04 am 2007 |
| Lee Revell | Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac ...
You should be able to identify the problematic driver by removing each
driver manually before suspending.
Lee
-
| Jan 7, 11:23 am 2007 |
| Tino Keitel | Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac ...
I can not reproduce it anymore, resume now works. I really hope that it
will stay so.
Regards,
Tino
-
| Jan 7, 1:04 pm 2007 |
| Tino Keitel | 2.6.20-rc3 regression: suspend to RAM broken on Mac mini ...
Hi folks,
I tried 2.6.20-rc3 and suspend to RAM is now broken. The screen stays
dark after resume, the same with the network link. It worked with
2.6.18 (I skipped 2.6.19 because of a regression in the sky2 driver).
I enabled pm_trace and did a echo mem > /sys/power/state in single user
mode.
After the reboot, all I got from pm_trace is this:
ACPI: (supports S0 S3 S4 S5)
Magic number: 0:798:636
hash matches drivers/base/power/resume.c:46
Freeing unused kernel memory: 228k ...
| Jan 7, 8:17 am 2007 |
| Tino Keitel | Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac ...
It didn't. It looks like it is unusable, becuase it isn't reliable in
2.6.20-rc3.
Regards,
Tino
-
| Jan 7, 3:27 pm 2007 |
| Adrian Bunk | Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac ...
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
| Jan 7, 4:44 pm 2007 |
| Yitzchak Eidus | controling on witch cpu part of module code exectue
i am writing a module that have to make use in the vmx operations,
to enable vmx operations i have to set bit 13 (vmxe bit) in the
control registetr cr4 to 1.
doing so in a uni cpu platform is not a problem, the question is what
to do when working on smp system?
to make all the cpus in the smp system support the vmx operations i
have to set the that bit in cr4 in each one of them to 1.
running the code servel times might always run on just one cpu and
therefor not set any other cpu cr4 register ...
| Jan 7, 8:11 am 2007 |
| Jindrich Makovicka | lp.c - runaway loop modprobe
I encountered rather weird behavior of the printer driver (lp.c) when
it is compiled into the kernel, and used with initramfs. When the
initramfs does not contain the /lib/linux-*/modules.dep file, as in
Debian sid, where it is created in the /init script, /sbin/modprobe
fails with the "FATAL: Cannot load modules.dep" message, and the kernel
runs into a runaway loop, repeatedly probing for net-pf-1.
This all happens before the kernel even calls the initramfs /init.
---
Linux version ...
| Jan 7, 7:59 am 2007 |
| Fabio Comolli | Re: [PATCH 1/1] MMC: new version of the TI Flash Media c ...
Hi.
I just wanted to let you know that I tested the version found in
git-mmc.patch (from latest -mm kernel) with kernel version
2.6.20-rc3-g6a4306b3 (2 or 3 days ago Linus' GIT tree).
No problems so far: the driver seems pretty stable: it survived
various suspend-to-ram and suspend-to-disk attempts without a single
problem, even with the card inserted and filesystem mounted.
Tests were performed with a 2GB SD card, a 512MB MMC card and with a
256 mini-SD.
Best regards,
Fabio
-
| Jan 7, 7:56 am 2007 |
| Stephen Rothwell | Re: [PATCH] Common compat_sys_sysinfo (v2)
Hi Kyle,
Looks good. Just one nit and one comment.
.
.
^
People have complined before that this adds a whole stack frame to the
"normal" syscall path. Personally I don't care, but it has been
mentioned.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
| Jan 7, 4:43 pm 2007 |
| Matthew Wilcox | Re: [PATCH] Common compat_sys_sysinfo
It's not BE that is the problem -- drepper thought of that.
What he fundamentally missed was the calling convention where 64-bit
arguments have to be 64-bit aligned, even when they're passed through
registers. So:
int foo(int, long long);
takes its arguments in arg0, arg2 and arg3, but glibc passes the syscall
arguments in arg0, arg1 and arg2.
I think the Right Way to fix this is for some gcc hacker to implement an
__attribute__((packed_args)) that changes the calling convention ...
| Jan 7, 8:18 am 2007 |
| Christoph Hellwig | Re: [PATCH] Common compat_sys_sysinfo
Please always put prototypes for functions with external linkage in
No need for the cast here.
Btw, in case you have some spare time there are some other syscalls
that want similar treatment. sendfile(64) come to mind as these
could use a do_sendfile helper aswell, the various stat and readdir/getdents
variants could do with some unification, the various timing calls
like alarm and get/settimeofday are common across architectures,
sysctl should be the same everywhere, the uid/git ...
| Jan 7, 8:13 am 2007 |
| Kyle McMartin | [PATCH] Common compat_sys_sysinfo
While tracking a bug for Thibaut Varene, I noticed that almost all
architectures implemented exactly the same sys32_sysinfo... except
parisc, where a bug was to be found in handling of the uptime. So
let's remove a whole whack of code for fun and profit. Cribbed
compat_sys_sysinfo from x86_64's implementation, since I figured
it would be the best tested.
This patch incorporates Arnd's suggestion of not using set_fs/get_fs,
but instead extracting out the common code from sys_sysinfo.
Tested ...
| Jan 7, 7:48 am 2007 |
| Kyle McMartin | Re: [PATCH] Common compat_sys_sysinfo
Ah, crud, I stuck that there to reduce the number of patched files when I let
Heh. :)
Cheers,
Kyle
-
| Jan 7, 8:22 am 2007 |
| Kyle McMartin | [PATCH] Common compat_sys_sysinfo (v2)
diff --git a/arch/ia64/ia32/ia32_entry.S b/arch/ia64/ia32/ia32_entry.S
index a32cd59..0a76de0 100644
--- a/arch/ia64/ia32/ia32_entry.S
+++ b/arch/ia64/ia32/ia32_entry.S
@@ -326,7 +326,7 @@ ia32_syscall_table:
data8 sys_ni_syscall
data8 compat_sys_wait4
data8 sys_swapoff /* 115 */
- data8 sys32_sysinfo
+ data8 compat_sys_sysinfo
data8 sys32_ipc
data8 sys_fsync
data8 sys32_sigreturn
diff --git a/arch/ia64/ia32/sys_ia32.c b/arch/ia64/ia32/sys_ia32.c
index 957681c..d430d36 ...
| Jan 7, 8:40 am 2007 |
| Arkadiusz Patyk | Re: [announce] Squashfs 3.2 released
Nice ;)
Where can I found it?
Regards,
--
Arkadiusz Patyk [areq<>pld-linux:org] [http://rescuecd.pld-linux.org/]
[IRC:areq skype:arekpatyk GG:1383 jid:arek<>patyk:net]
-
| Jan 7, 8:55 am 2007 |
| Andrey Borzenkov | Re: [announce] Squashfs 3.2 released
I have patches for 3.0, 3.1 and (not yet finished) 3.2. As far as I can
tell:
src/squashfs3.2/squashfs-tools/lzma/README:
=======
This directory contains some source files from the
7z archive utility. (www.7-zip.org)
All the files in this directory was originally released
with the LGPL license.
=======
Now "originally released" is somewhat interesting form of expression, but I
do not think you can change license post factum.
The patches are for "personal use" but I am happy to work ...
| Jan 7, 7:39 am 2007 |
| Anders Karlsson | D-Link DFE-580TX adapter problems
--=-y4iuWL+CQijn0irQJBAV
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Hi there,
I am having problems getting a network adapter going. I should see
eth1-eth4 from this adapter, but they do not show up with 'ifconfig -a'.
'alta-diag' and 'lspci' show the four NICs, which is what confuses me. I
even added some printk's in sundance.c to find out what happens, and as
far as I can see, the NICs get enabled - so why don't they show up for
ifconfig? I've tried both ...
| Jan 7, 6:39 am 2007 |
| Pekka Enberg | Re: Oops with 2.6.29.1 (slab_get_obj,free_block,journal_ ...
Looks like someone corrupted slab->free with 0x55555555. If possible,
try running with CONFIG_SLAB_DEBUG enabled to catch the offender.
-
| Jan 7, 8:02 am 2007 |
| Sebastian | Re: Oops with 2.6.29.1 (slab_get_obj,free_block,journal_ ...
didn't attach .config.. here it is..
| Jan 7, 7:47 am 2007 |
| Sebastian | Oops with 2.6.29.1 (slab_get_obj,free_block,journal_writ ...
Hi,
while running "shred /dev/hda3" this night I got the following oops. The
keyboard is no longer working, but the machine is up and running.
If you need any other information, please let me know, as I will reboot
this machine in ~24hours.
BUG: unable to handle kernel paging request at virtual address 1b1ca570
printing eip:
c014c3b1
*pde = 00000000
Oops: 0000 [#1]
Modules linked in:
CPU: 0
EIP: 0060:[<c014c3b1>] Not tainted VLI
EFLAGS: 00010807 (2.6.19.1 #1)
EIP is at ...
| Jan 7, 7:17 am 2007 |
| Avi Kivity | [ANNOUNCE] kvm-10 release
Changes from kvm-9:
- more hypercall work
- cleanup irq handling
- shadow page table caching
- migration fixes
- stabilization fixes
This release is significantly faster than previous releases; upgrading
is recommended.
http://kvm.sourceforge.net
--
error compiling committee.c: too many arguments to function
-
| Jan 7, 6:17 am 2007 |
| Martin Schwidefsky | [S390] don't call handle_mm_fault() if in an atomic context.
From: Heiko Carstens <heiko.carstens@de.ibm.com>
[S390] don't call handle_mm_fault() if in an atomic context.
There are several places in the futex code where a spin_lock is held
and still uaccesses happen. Deadlocks are avoided by increasing the
preempt count. The pagefault handler will then not take any locks
but will immediately search the fixup tables.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
...
| Jan 7, 3:44 am 2007 |
| Martin Schwidefsky | [S390] Fix vmalloc area size calculation.
From: Heiko Carstens <heiko.carstens@de.ibm.com>
[S390] Fix vmalloc area size calculation.
setup_memory_end() uses VMALLOC_END instead of VMALLOC_END_INIT to
calculate the maximum supported size of physical memory. Since
VMALLOC_END is zero, this will cause a crash on 31 bit systems.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
arch/s390/kernel/setup.c | 2 +-
1 files changed, 1 insertion(+), 1 ...
| Jan 7, 3:44 am 2007 |
| Martin Schwidefsky | [S390] memory detection misses 128k.
From: Hongjie Yang <hongjie@us.ibm.com>
[S390] memory detection misses 128k.
Fix a memory leak problem in the memory detection routines. A memory leak
of 128k occurs when we have a contiguous memory with mixed access-mode
(read or write) ranges.
Signed-off-by: Hongjie Yang <hongjie@us.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
arch/s390/kernel/head31.S | 12 +++++++++++-
arch/s390/kernel/head64.S | 12 +++++++++++-
2 files changed, 22 insertions(+), 2 ...
| Jan 7, 3:43 am 2007 |
| Martin Schwidefsky | [S390] Fix cpu hotplug (missing 'online' attribute).
From: Heiko Carstens <heiko.carstens@de.ibm.com>
[S390] Fix cpu hotplug (missing 'online' attribute).
72486f1f8f0a2bc828b9d30cf4690cf2dd6807fc inverts the logic if an
'online' attribute in /sys/devices/system/cpu/cpuX should appear.
So we end up with no hotpluggable cpus at all...
Set the hotpluggable value to one to make sure the online
attribute appears again.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
...
| Jan 7, 3:43 am 2007 |
| Martin Schwidefsky | [S390] cio: use barrier() in stsch_reset.
From: Heiko Carstens <heiko.carstens@de.ibm.com>
[S390] cio: use barrier() in stsch_reset.
Use barrier() in stsch_reset() instead of duplicating the stsch()
inline assembly and adding "memory" to the clobberlist.
Pointed out by Chuck Ebbert.
Real fix would be to add a fixup section to the stsch() and extend the
basic program check handler so it searches the exception tables in case
of a program check.
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin ...
| Jan 7, 3:43 am 2007 |
| Martin Schwidefsky | Please pull git390 'for-linus' branch
Please pull from 'for-linus' branch of
git://git390.osdl.marist.edu/pub/scm/linux-2.6.git for-linus
to receive the following updates:
arch/s390/kernel/head31.S | 12 +++++++++++-
arch/s390/kernel/head64.S | 12 +++++++++++-
arch/s390/kernel/setup.c | 2 +-
arch/s390/kernel/smp.c | 5 ++++-
arch/s390/lib/uaccess_pt.c | 3 +++
arch/s390/lib/uaccess_std.c | 3 ---
drivers/s390/cio/cio.c | 12 ++++--------
include/asm-s390/futex.h | 2 ++
8 files ...
| Jan 7, 3:44 am 2007 |
| TAKADA | i386,2.6 cyrix.c cann't found companion chip
Hi. I use MediaGX with kernel 2.6.19.
cirix.c try to find companion chip (CS5510 and CS5520) with
pci_devPresent().
However, cyrix.c cannot find a companion chip because a list of
pci_devices is not yet initialized when __cpuinit is called.
Therefore, Search functions such as the 2.4 kernel which pci_devices
list is needless is necessary.
How will it be good?
--
TAKADA <takada@mbf.nifty.com>
-
| Jan 7, 2:47 am 2007 |
| Alan | Re: i386,2.6 cyrix.c cann't found companion chip
Fortunately we have pci functions for early pci accesses. I will take a
look at this as I still have a CS5520 board.
-
| Jan 7, 3:20 pm 2007 |
| Hiroshi Miura | Re: i386,2.6 cyrix.c cann't found companion chip
Hi Takada-san,
It is obviously bad.
These part is added several years ago by my post.
A cyrix.c try to find chip because of chip hardware bug affected
to timer which has started early.
Now, these chips have already been obsolete.
There are 2 options. One is simply remove these functionality.
The other is to move it to compile time ifdef that is off by default.
For user who use in embbeded environment,
I wanna change it to ifdef.
Thank you for report!
Hiroshi
-
| Jan 7, 9:00 am 2007 |
| Akula2 | Re: Multi kernel tree support on the same distro?
I am planning in this fashion:-
gcc-3.4.x (latest in that tree) to build 2.4.34 kernel
gcc-4.1.x (latest in that tree) to build 2.6.20 kernel (once released)
And, all the required utils for these kernels.
There is no other option for me (this is fairly I can call as an
Experimental work, but this effort would add a lots for my work in the
> http://lunar-linux.org/
This am not so sure (totally new for me), but I shall really try
Lunar...thanks :-)
This time am looking to work with ...
| Jan 7, 2:13 am 2007 |
| Robert P. J. Day | [PATCH] Numerous fixes to kernel-doc info in source files.
A variety of (mostly) innocuous fixes to the embedded kernel-doc
content in source files, including:
* make multi-line initial descriptions single line
* denote some function names, constants and structs as such
* change erroneous opening '/*' to '/**' in a few places
* reword some text for clarity
Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
---
this should give randy something to do.
include/asm-i386/atomic.h | 4 ++--
include/asm-i386/bitops.h | 4 ...
| Jan 7, 1:56 am 2007 |
| Nathan Lynch | [PATCH 2.6.20] tasks cannot run on cpus onlined after boot
Commit 5c1e176781f43bc902a51e5832f789756bff911b ("sched: force
/sbin/init off isolated cpus") sets init's cpus_allowed to a subset of
cpu_online_map at boot time, which means that tasks won't be scheduled
on cpus that are added to the system later.
Make init's cpus_allowed a subset of cpu_possible_map instead. This
should still preserve the behavior that Nick's change intended.
Thanks to Giuliano Pochini for reporting this and testing the ...
| Jan 7, 1:49 am 2007 |
| Ingo Molnar | Re: [PATCH 2.6.20] tasks cannot run on cpus onlined after boot
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
-
| Jan 7, 8:48 am 2007 |
| Vadim Lobanov | Re: [PATCH] include/linux/slab.h: new KFREE() macro.
Because it looks really STRANGE(tm). Consider the following function,
which is essentially what you're proposing in macro-ized form:
void foobar(void)
{
void *ptr;
ptr = kmalloc(...);
// actual work here
kfree(ptr);
ptr = NULL;
}
Reading code like that makes me say "wtf?", simply because 'ptr' is not
used thereafter, so setting it to NULL is both pointless and confusing
(it looks out-of-place, and therefore makes me wonder if there's
something stupidly tricky going ...
| Jan 7, 4:22 pm 2007 |
| Amit Choudhary | Re: [PATCH] include/linux/slab.h: new KFREE() macro.
Any strong reason why not? x has some value that does not make sense and can create only problems.
And as I explained, it can result in longer code too. So, why keep this value around. Why not
re-initialize it to NULL.
If x should not be re-initialized to NULL, then by the same logic, we should not even initialize
local variables. And all of us know that local variables should be initialized.
I would like to know a good reason as to why x should not be set to ...
| Jan 7, 3:43 pm 2007 |
| Amit Choudhary | Re: [PATCH] include/linux/slab.h: new KFREE() macro.
Well, I am not proposing this as a debugging aid. The idea is about correct programming, atleast
from my view. Ideally, if you kfree(x), then you should set x to NULL. So, either programmers do
it themselves or a ready made macro do it for them.
In my opinion, the programmers may welcome the macro that does it for them.
There is another good part about it that results in better programming and shorter code.
Consider an array x[10]. I allocate memory for all of them and then kfree them - ...
| Jan 7, 1:46 am 2007 |
| Christoph Hellwig | Re: [PATCH] include/linux/slab.h: new KFREE() macro.
No, you should not. I suspect that's the basic point you're missing.
-
| Jan 7, 3:24 am 2007 |
| Chuck Ebbert | Re: Linux 2.6.16.37
In-Reply-To: <20070104222517.GL20714@stusta.de>
Sorry, my Web access is broken for now so I can't check, but I believe
that CVE number is for a different, older problem.
So AFAIK there are no CVE numbers for anything I sent (but there
probably should be.) Generic Linux kernel developers don't have
a CVE representative, so we depend on vendors to assign numbers
and sometimes they don't.
--
"That's the problem with non-representational art:
you can't tell which part offends you."
...
| Jan 7, 1:35 am 2007 |
| Rene Herman | Re: [DISCUSS] Making system calls more portable.
True I guess. But do you want to live in a software environment where as
a matter of course every distribution out there puts its "value-add" in
custom system calls and creating a $DISTRIBUTION-only userspace? After
all, if nothing uses their shiny new custom syscall, they might as well
not add it. This would fragment Linux quite horribly and IMO cases where
this happens should be _dis_ couraged, not encouraged by making it less
problematic to survive the resulting mess.
Rene.
-
| Jan 7, 2:16 am 2007 |
| Jan Engelhardt | Re: [DISCUSS] Making system calls more portable.
For example? Do you plan on using "syscall strings" instead of
syscall numbers? I would not go for it. Comparing strings takes much
Umm, like with Internet addresses, you can't just reserve yourself
one you like. Including MACs on the local ethernet segment. Though
the MAC space is large with 2^48 or more, you can ARP spoof and
hinder the net.
In other words, if the vendor, or you, are going to use a
non-standard 301, you are supposed to run into problems, sooner or
later [Murphy's Law or ...
| Jan 7, 4:03 am 2007 |
| Theodore Tso | Re: [DISCUSS] Making system calls more portable.
So the vendor is doing something bad, and his customers will pay the
price, and they will switch to another vendor who isn't doesn't create
traps for their customers. What's the problem? :-)
Serious,y you got into trouble in your second sentence --- and not
just by the use of the passive voice: "the way chosen is to implement
(a) new system call". Don't do that.
There are plenty of other ways of requesting kernel services; you can
create your own device driver and pass string commands ...
| Jan 7, 6:59 am 2007 |
| Amit Choudhary | [DISCUSS] Making system calls more portable.
Hi,
I wanted to know if there is any inclination towards making system calls more portable. Please let
me know if this discussion has happened before.
Well, system calls today are not portable mainly because they are invoked using a number and it
may happen that a number 'N' may refer to systemcall_1() on one system/kernel and to
systemcall_2() on another system/kernel. This problem may surface if you compile your program
using headers from version_1 of the kernel, and then install another ...
| Jan 7, 1:15 am 2007 |
| Amit Choudhary | Re: [DISCUSS] Making system calls more portable.
I will come to the main issue later but I just wanted to point out that we maintain information at
two separate places - mapping between the name and the number in user space and kernel space.
Shouldn't this duplication be removed.
Now, let's say a vendor has linux_kernel_version_1 that has 300 system calls. The vendor needs to
give some extra functionality to its customers and the way chosen is to implement new system call.
The new system call number is 301. The customer gets this custom ...
| Jan 7, 2:07 am 2007 |
| Vadim Lobanov | Re: [DISCUSS] Making system calls more portable.
Your argument has a built-in assumption that, whereas syscall numbers do
collide, syscall names will not. This assumption is not true; people
will quite often pick the same name for something independent of each
other.
Additionally, the proposed solutions will require a dramatic increase in
memory, to store a static string name for each syscall, and a marked
increase in CPU usage, to do string hashing and matching for each
syscall invocation (and these can occur very often). This overhead ...
| Jan 7, 2:33 am 2007 |
| Rene Herman | Re: [DISCUSS] Making system calls more portable.
If we're limited to Linux kernels, this seems to not be the case. Great
care is taken in keeping this userspace ABI stable -- new system calls
are given new numbers. Old system calls may disappear (after a long
grace period) but even then I don't believe the number is ever recycled.
If your discussion is not limited to Linux kernels, then sure, but being
Some, but your supposition seems unclear.
Rene
-
| Jan 7, 1:25 am 2007 |
| Atsushi Nemoto | Re: [announce] Squashfs 3.2 released
It is for PREFETCH issue reported on this mail, right?
http://sourceforge.net/mailarchive/message.php?msg_id=37687166
MIPS memcpy is no longer abuse PREFETCH. The "fix" was done on Oct
2005. So if the "workaround" had any bad side effects, it can be
reverted.
---
Atsushi Nemoto
-
| Jan 7, 7:30 am 2007 |
| Arkadiusz Patyk | Re: [announce] Squashfs 3.2 released
What about lzma and squashfs ?
Cheers,
--
Arkadiusz Patyk [areq<>pld-linux:org] [http://rescuecd.pld-linux.org/]
[IRC:areq skype:arekpatyk GG:1383 jid:arek<>patyk:net]
-
| Jan 7, 5:54 am 2007 |
| Phillip Lougher | [announce] Squashfs 3.2 released
Hi,
I'm pleased to announce the release of Squashfs 3.2. NFS exporting
is now supported, and the kernel code has been hardened against
accidently or maliciously corrupted filesystems. The new release
correctly handles all corrupted filesystems generated by the fsfuzzer
tool (written by LMH/Steve Grubb) without oopsing the kernel. This
in particular fixes the MOKB (Month of Kernel Bugs) report raised
against Squashfs.
Squashfs can be dowloaded from ...
| Jan 6, 10:33 pm 2007 |
| Jeff Garzik | Re: ATA streaming feature support
If you pass SG_IO addresses, they become DMA scatter/gather tables.
Jeff
-
| Jan 7, 1:25 am 2007 |
| Manish Regmi | ATA streaming feature support
Hi all,
First of all sorry for bringing this topic again.
As discussed in --> http://lkml.org/lkml/2006/5/5/47
The ATA Streaming feature set is not necessary to be in Kernel Space
(IDE driver). There is a suggestion creating user space library.
But how is the user space apps going to use the commands like READ
STREAM DMA EXT (0x2A). Shouldn't there be some support in kernel which
setups up PRD tables and all.
It doesn't seem to be possible.... is it?
Does it sound normal if we have ...
| Jan 6, 11:40 pm 2007 |
| Randy Dunlap | [PATCH] math-emu/setcc: avoid gcc extension
From: Randy Dunlap <randy.dunlap@oracle.com>
setcc() in math-emu is written as a gcc extension statement expression
macro that returns a value. However, it's not used that way and it's
not needed like that, so just make it a do-while non-extension macro
so that we don't use an extension when it's not needed.
All 4 .c files that use setcc() produce the same code after this patch.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/i386/math-emu/status_w.h | 5 ...
| Jan 6, 11:19 pm 2007 |
| Randy Dunlap | Re: [PATCH] math-emu/setcc: avoid gcc extension
Not really. That should be a different patch IMO.
---
~Randy
-
| Jan 7, 12:30 pm 2007 |
| Christoph Hellwig | Re: [PATCH] math-emu/setcc: avoid gcc extension
Is there any reason you this shouldn't be an inline function?
-
| Jan 7, 12:58 pm 2007 |
| Randy Dunlap | Re: [PATCH] math-emu/setcc: avoid gcc extension
That would be OK in theory, so I just tried it.
I don't get the same object files produced with an inline function
(for arch/i386/math-emu/fpu_etc.o), so I don't feel that it's quite
as safe without digging deeping into the .o file and its changes.
The 3 other .o files that use setcc() were the same when using
the inline patch version.
---
From: Randy Dunlap <randy.dunlap@oracle.com>
setcc() in math-emu is written as a gcc extension statement expression
macro that returns a value. ...
| Jan 7, 2:07 pm 2007 |
| Segher Boessenkool | Re: [PATCH] math-emu/setcc: avoid gcc extension
closing brace on the "while" line, please.
Segher
-
| Jan 7, 6:27 am 2007 |
| Segher Boessenkool | Re: [PATCH] math-emu/setcc: avoid gcc extension
I meant fix all the wrongly indented lines in that file (there
are only a few, and all around where you're patching anyway).
Care for one extra time? :-)
Segher
-
| Jan 7, 12:29 pm 2007 |
| Segher Boessenkool | Re: [PATCH] math-emu/setcc: avoid gcc extension
There's an extra tab in that last line. Could you also
please fix the indenting (use a tab, not spaces) -- I know
it was there originally, but since there are only a few
lines in that file like that... :-)
[You must be tired of me by now, heh]
Thanks,
Segher
-
| Jan 7, 12:12 pm 2007 |
| Robert P. J. Day | Re: [PATCH] math-emu/setcc: avoid gcc extension
is that the proposed coding style for macros? if it returns a value,
use "({ })"? if not, use the "do ... while" notation?
rday
-
| Jan 7, 12:22 pm 2007 |
| Randy Dunlap | Re: [PATCH] math-emu/setcc: avoid gcc extension
how's this one?
---
From: Randy Dunlap <randy.dunlap@oracle.com>
setcc() in math-emu is written as a gcc extension statement expression
macro that returns a value. However, it's not used that way and it's
not needed like that, so just make it a do-while non-extension macro
so that we don't use an extension when it's not needed.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/i386/math-emu/status_w.h | 5 +++--
---
arch/i386/math-emu/status_w.h | 7 ...
| Jan 7, 12:19 pm 2007 |
| Randy Dunlap | Re: [PATCH] math-emu/setcc: avoid gcc extension
---
From: Randy Dunlap <randy.dunlap@oracle.com>
setcc() in math-emu is written as a gcc extension statement expression
macro that returns a value. However, it's not used that way and it's
not needed like that, so just make it a do-while non-extension macro
so that we don't use an extension when it's not needed.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/i386/math-emu/status_w.h | 5 +++--
---
arch/i386/math-emu/status_w.h | 5 +++--
1 file changed, ...
| Jan 7, 11:45 am 2007 |
| Russell King | Re: Linux 2.6.20-rc4
See the thread "kernel.org lies about latest -mm kernel" on this mailing
list.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
| Jan 7, 5:55 am 2007 |
| Robin Rosenberg | Re: OT: character encodings (was: Linux 2.6.20-rc4)
söndag 07 januari 2007 20:17 skrev Russell King:
They don't. Git doesn't convert, with the exception of two mail-related tools,
which is the reason the commit being discussed ended up as UTF-8
in GIT. The mail containing the patch was in ISO-8859-1. All other git tools
just store whatever byte sequence they are fed, be ut ISO-latin, utf-8 or
something (to westeners) more exotic.
-- robin
-
| Jan 7, 12:58 pm 2007 |
| Dave Jones | Re: OT: character encodings (was: Linux 2.6.20-rc4)
On Sun, Jan 07, 2007 at 07:17:30PM +0000, Russell King wrote:
> commit 24ebead82bbf9785909d4cf205e2df5e9ff7da32
> tree 921f686860e918a01c3d3fb6cd106ba82bf4ace6
> parent 264166e604a7e14c278e31cadd1afb06a7d51a11
> author Rafa³ Bilski <rafalbilski@interia.pl> 1167691774 +0100
> committer Dave Jones <davej@redhat.com> 1167799119 -0500
>
> and looking at that "author" closer with od:
>
> 0000140 74 68 6f 72 20 52 61 66 61 b3 20 42 69 6c 73 6b
> t h o r R a f ...
| Jan 7, 1:05 pm 2007 |
| Willy Tarreau | Re: Linux 2.6.20-rc4
There are distro mirrors on kernel.org, and the most famous ones
are downloaded by huge number of people on their release day. What
John explained is that the cumulated downloads during the 12 first
hours after FC6 releases totalized 13 TB of data sent to the net,
which is indeed 2 gig links at full load. Impressive !
Willy
-
| Jan 7, 6:53 am 2007 |
| Adrian Bunk | Re: OT: character encodings (was: Linux 2.6.20-rc4)
I doubt doing this would really be worth the effort.
Only if MUAs have broken charset support or don't set a correct
"charset" header in the mails they are sending.
If some software still can't handle UTF-8 correctly more than 10 years
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - ...
| Jan 7, 4:37 pm 2007 |
| Xavier Bestel | Re: OT: character encodings (was: Linux 2.6.20-rc4)
IIRC LANG is a superset for all LC_* - i.e. if only LANG is defined, it
sets all your locales, but you can individually set the charset, numeric
format, date format, etc.
Xav
-
| Jan 7, 2:07 pm 2007 |
| Alan | Re: Linux 2.6.20-rc4
On Sun, 7 Jan 2007 11:56:01 +0100 (MET)
Git tree is fine, Linus has a wonky mailer (that or a problem between
keyboard and chair 8)) that sends UTF-8 data in ISO 8859-1 marked email.
-
| Jan 7, 6:23 am 2007 |
| David Woodhouse | Re: OT: character encodings (was: Linux 2.6.20-rc4)
Indeed. If you take arbitrary content and send it out to the world
labelled as ISO8859-1, of _course_ you're likely to be corrupting it.
Far from being the cause of the problem, UTF-8 actually offers the
chance of a _solution_. Because once the Luddites catch up, it'll
largely eliminate the need for using the multitude of legacy character
sets and converting between them -- and the problem of mislabelling will
fairly much go away.
--
dwmw2
-
| Jan 7, 8:13 am 2007 |
| Russell King | Re: Linux 2.6.20-rc4
That is an å if you look at the raw message in UTF-8. However, Linus
sends mail in with a charset of ISO-8859-1, and if you place UTF-8
encoded text in such a message body, you will see A¥.
Welcome to the mess which the UTF-8 charset creates.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
| Jan 7, 4:44 am 2007 |
| Alan | Re: OT: character encodings (was: Linux 2.6.20-rc4)
Net ASCII is 7bit and is 1:1 mapped with UTF-8 unicode. It's just old
broken 8bit encodings that are problematic.
The kernel maintainers/help/config pretty consistently use UTF8
-
| Jan 7, 11:21 am 2007 |
| Sean | Re: OT: character encodings (was: Linux 2.6.20-rc4)
On Sun, 7 Jan 2007 15:05:53 -0500
Dave Jones <davej@redhat.com> wrote:
-
| Jan 7, 1:15 pm 2007 |
| Jan Engelhardt | Re: OT: character encodings (was: Linux 2.6.20-rc4)
I've seen a lot of places that don't do so. Want a patch?
-`J'
--
-
| Jan 7, 12:12 pm 2007 |
| Akula2 | Re: Linux 2.6.20-rc4
Linus,
I can't find 2.6.20-rc4 on the kernel.org home page. Latest shows as:-
The latest prepatch for the stable Linux kernel tree is: 2.6.20-rc3
2007-01-01 01:15 UTC
~Akula2
-
| Jan 7, 5:15 am 2007 |
| Akula2 | Re: Linux 2.6.20-rc4
Russell,
I have read the thread, big thanks to you for the inputs.
Honestly I didn't understand much about the git internal working
except getdents () @ HPA & Linus replies. This is incredible indeed.
I didn't understand these lines posted by John 'Warthog9' Hawley:-
"On average we are moving anywhere from 400-600mbps between the two
machines, on release days we max both of the connections at 1gpbs each
and have seen that draw last for 48hours. For instance when FC6 was
released in the ...
| Jan 7, 6:38 am 2007 |
| Jan Engelhardt | Re: Linux 2.6.20-rc4
On Jan 6 2007 22:19, Linus Torvalds wrote:
>Leonard Norrg
| Jan 7, 3:56 am 2007 |
| Linus Torvalds | Linux 2.6.20-rc4
There's absolutely nothing interesting here, unless you want to play with
KVM, or happened to be bitten by the bug with really old versions of the
linker that made parts of entry.S just go away.
But check it out anyway, and the shortlog gives more details on the
various minor fixes that have accumulated this week. Mostly in random
device drivers.
Linus
---
Adam Megacz (1):
Add AFS_SUPER_MAGIC to magic.h
Adrian Bunk (2):
[NET] drivers/net/loopback.c: convert to ...
| Jan 6, 11:19 pm 2007 |
| Russell King | Re: OT: character encodings (was: Linux 2.6.20-rc4)
$ git log | head -n 1000 | tail -n 200 > o
$ file -i o
o: text/plain; charset=us-ascii
$ git log | head -n 1000 | tail -n 300 > o
$ file -i o
o: text/plain; charset=us-ascii
$ git log | head -n 1000 | tail -n 400 > o
$ file -i o
o: text/plain; charset=utf-8
(and you know what charset the file is thought to have with all 1000
lines in it.)
The same thing actually happens when I look at it via:
$ git log | head -n 1000 | less
but in this case the output is always interpreted by ...
| Jan 7, 10:06 am 2007 |
| Gene Heskett | Re: Linux 2.6.20-rc4
Running on FC6, all uptodate as of yesterday, using LVM on an XP-2800
Athlon & a gig of ram.
First boot of 2.6.20-rc4 here, in the messages scrolling by, the nptd
startup failed. But after fully booting and x was started, a restart
worked, albeit it took several seconds for the startup phase. NDI if it
means anything or not.
And maybe I'm seeing the effects of this ext3 bug that's hurting
kernel.org here, it seems the x startup has everything 100% serialized
now and that's slow as ...
| Jan 7, 2:22 pm 2007 |
| Willy Tarreau | Re: OT: character encodings (was: Linux 2.6.20-rc4)
The stupidity from the start up with those character sets is that they
consider that a whole file is written with a given set. In fact, the
charset should apply to characters themselves. At least, the
quoted-printable, non-human friendly, encoding was the least stupid.
Now that UTF8 comes everywhere, everyone receives tons of mangled mails,
and even mailers which correctly support UTF8 and use it by default manage
to shoot themselves in the foot when they reply to, or forward a mail. ...
| Jan 7, 1:48 pm 2007 |
| Peter Osterlund | Re: Linux 2.6.20-rc4
I also see an annoying side effect of this bug. When the panic
happens, the caps lock LED starts to blink, and the kernel prints this
on the console once every second (or more often, don't know exactly):
printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
"Some program might be trying access hardware directly.\n",
data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
This makes the actual crash information disappear before you have a
chance to read it.
--
Peter Osterlund ...
| Jan 7, 2:04 pm 2007 |
| Jan Engelhardt | Re: OT: character encodings (was: Linux 2.6.20-rc4)
I am inclined to say that "file" does not count, because it tries to guess an
ambiguous mapping from bytes to character set. Even more, file should be
_unable at all_ to distinguish an iso-8859-1 from an iso-8859-2 (or worse: 15)
file. This program is soo... forget it, it's not an argument. It works well for
headerful files, but text files don't really contain one. The next best thing
would be html, with a proper <meta http-equiv=Content> tag.
-`J'
--
-
| Jan 7, 12:11 pm 2007 |
| Peter Osterlund | Re: Linux 2.6.20-rc4
I get kernel panics when doing large ethernet transfers. A loop doing
continuous scp transfers of some large (>100MB) files makes the kernel
crash after a few minutes. scp runs on a different machine and copies
data from the machine that crashes. (The first crash did not happen
when scp was used, but scp is an easy way to reproduce the problem.)
I've seen this crash also with 2.6.20-rc2-git-something. Previously I
ran these kernels quite a lot and used a ppp link without problems.
Today I ...
| Jan 7, 1:57 pm 2007 |
| Tilman Schmidt | Re: OT: character encodings
What the "file" command thinks is hardly relevant here. "file" just
attempts to guess what the contents of a file might be, by applying
a simple set of heuristics. Your results only highlight the actual
problem: "git" is apparently unable to handle character sets properly
For software with proper multilingual support, that should have been
enough to make sure that all its output would be in iso-8859-1, too.
The loss has happened long before you run that command, when the
The problem is ...
| Jan 7, 12:29 pm 2007 |
| David Woodhouse | Re: OT: character encodings (was: Linux 2.6.20-rc4)
No, that's a different problem; not the one you were referring to above.
That's a real problem, yes -- but it was a problem long before UTF-8 was
added to the collection of character sets in use. Even within the UK, we
Only if you are making different assumptions about the _same_ set of
files, on the _same_ system. But that would be silly.
If I suddenly "assume" that my laptop has a Dvorak keyboard layout
despite that blatantly not being true, I'll get the same kind of
confusion. That ...
| Jan 7, 9:29 am 2007 |
| Akula2 | Re: Linux 2.6.20-rc4
Hmm got you. If that's the case can't we do away with the distro
mirrors since we have many mirrors & torrents? In this fashion we can
reduce huge loads I guess.
Or, is it sentimental to have a distro mirror on kernel.org because
~Akula2
-
| Jan 7, 7:23 am 2007 |
| Russell King | Re: OT: character encodings (was: Linux 2.6.20-rc4)
As I've tried to point out, that's not universally true. For instance:
commit 24ebead82bbf9785909d4cf205e2df5e9ff7da32
tree 921f686860e918a01c3d3fb6cd106ba82bf4ace6
parent 264166e604a7e14c278e31cadd1afb06a7d51a11
author Rafa³ Bilski <rafalbilski@interia.pl> 1167691774 +0100
committer Dave Jones <davej@redhat.com> 1167799119 -0500
and looking at that "author" closer with od:
0000140 74 68 6f 72 20 52 61 66 61 b3 20 42 69 6c 73 6b
t h o r R a f a ³ B ...
| Jan 7, 12:17 pm 2007 |
| Alan | Re: OT: character encodings (was: Linux 2.6.20-rc4)
I think that would be a good idea - and add it to the coding/docs specs
that documentation is UTF-8. Code should IMHO say 7bit though.
Alan
-
| Jan 7, 3:30 pm 2007 |
| Linus Torvalds | Re: Linux 2.6.20-rc4
That's
and $0xf,%dl
movzbl %dl,%edx
lea (%ecx,%edx,4),%edx
movzbl %bl,%eax
mov %eax,(%esp)
mov %esi,%ecx
mov %edi,%eax
mov 0xfffffff0(%ebp),%ebx
** call *0x68(%ebx) **
add $0x8,%esp
pop %ebx
pop %esi
pop %edi
pop %ebp
ret
which is ipv4_conntrack_help():
return help->helper->help(pskb,
(*pskb)->nh.raw - (*pskb)->data
+ (*pskb)->nh.iph->ihl*4,
ct, ctinfo);
and that call instruction is the one that oopses because ...
| Jan 7, 3:50 pm 2007 |
| Russell King | Re: OT: character encodings (was: Linux 2.6.20-rc4)
Wrong. The problem is partly caused by not everything understanding
multi-byte character encodings, and text files containing absolutely
_no_ information about their character encodings.
When a text file is stored on disk, there's no way to tell what
character set the characters in that file belong to. As a result,
ISO-8859-1 folk assume that all text files are ISO-8859-1 encoded.
UTF-8 folk assume all text files are UTF-8 encoded. This leads to
utter confusion.
To see what I mean, try ...
| Jan 7, 8:38 am 2007 |
| Russell King | Re: OT: character encodings (was: Linux 2.6.20-rc4)
You're discarding a perfectly reasonable argument - file itself obviously
is not good at guessing the charset, but inspecting the resulting file
manually and identifying *both* ISO-8859 and UTF-8 character sequences
in there is pretty conclusive. As I did indeed do prior to sending
that message.
In this case, 'file' was doing a remarkably accurate job.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
| Jan 7, 12:20 pm 2007 |
| Tilman Schmidt | OT: character encodings (was: Linux 2.6.20-rc4)
Russell King schrieb:
Only if the mechanism used for placing it there ignores the different
The problem of different character encodings coexisting on the same
platform, and the resulting occasional messing-up, far predates Unicode.
I distinctly remember one case of being bitten by this myself in 1977
when Unicode wasn't even on the horizon yet, and I don't think that was
the first time.
Tilman
-
| Jan 7, 6:06 am 2007 |
| Jan Engelhardt | Re: OT: character encodings (was: Linux 2.6.20-rc4)
No, LC_CTYPE defines what charset you use. (I may be wrong, though.)
-`J'
--
-
| Jan 7, 1:40 pm 2007 |
| Shawn O. Pearce | Re: How git affects kernel.org performance
Latest Git does this. If the server is later than 1.4.3.3 then
the receive-pack process can actually store the pack file rather
than unpacking it into loose objects. The downside is that it will
copy any missing base objects onto the end of a thin pack to make
it not-thin.
There's actually a limit that controls when to keep the pack and when
not to (receive.unpackLimit). In 1.4.3.3 this defaulted to 5000
objects, which meant all but the largest pushes will be exploded
into loose objects. ...
| Jan 7, 1:31 pm 2007 |
| Andrew Morton | Re: How git affects kernel.org performance
On Sun, 7 Jan 2007 09:55:26 +0100
Yeah, slowly-growing directories will get splattered all over the disk.
Possible short-term fixes would be to just allocate up to (say) eight
blocks when we grow a directory by one block. Or teach the
directory-growth code to use ext3 reservations.
Longer-term people are talking about things like on-disk rerservations.
But I expect directories are being forgotten about in all of that.
-
| Jan 7, 2:15 am 2007 |
| Nigel Cunningham | Re: [KORG] Re: kernel.org lies about latest -mm kernel
Hi.
Cool. I'll have a play :)
Thanks!
Nigel
-
| Jan 6, 9:47 pm 2007 |
| Jeff Garzik | Re: [KORG] Re: kernel.org lies about latest -mm kernel
It's highly useful but poorly documented method of referencing
repository B's objects from repository A.
When you clone locally
git clone --reference linus-2.6 linus-2.6 nigel-2.6
it will create nigel-2.6 with zero objects, and an alternatives file
pointing to 'linus-2.6' local repository. When you commit, only the
objects not already in linus-2.6 will be found in nigel-2.6.
It's far better "git clone -l ..." because you don't even have the
additional hardlinked inodes, and don't ...
| Jan 6, 9:10 pm 2007 |
| Linus Torvalds | Re: How git affects kernel.org performance
Btw, this isn't the test-case, but it's a half-way re-creation of
something like it. It's _really_ stupid, but here's what you can do:
- compile and run this idiotic program. It creates a directory called
"throwaway" that is ~44kB in size, and if I did things right, it should
not be totally contiguous on disk with the current ext3 allocation
logic.
- as root, do "echo 3 > /proc/sys/vm/drop_caches" to get a cache-cold
schenario.
- do "time ls throwaway > ...
| Jan 7, 12:13 pm 2007 |
| H. Peter Anvin | Re: How git affects kernel.org performance
Changing filesystems would mean about a week of downtime for a server.
It's painful, but it's doable; however, if we get a traffic spike during
that time it'll hurt like hell.
However, if there is credible reasons to believe XFS will help, I'd be
inclined to try it out.
-hpa
-
| Jan 7, 1:58 am 2007 |
| Rene Herman | Re: How git affects kernel.org performance
I wish people would just talk about de2fsrag... ;-\
Rene
-
| Jan 7, 2:38 am 2007 |
| H. Peter Anvin | Re: [KORG] Re: kernel.org lies about latest -mm kernel
Use the -s option to git clone.
-hpa
-
| Jan 7, 2:30 pm 2007 |
| Linus Torvalds | Re: How git affects kernel.org performance
"getdents()" is totally serialized by the inode semaphore. It's one of the
most expensive system calls in Linux, partly because of that, and partly
because it has to call all the way down into the filesystem in a way that
almost no other common system call has to (99% of all filesystem calls can
be handled basically at the VFS layer with generic caches - but not
getdents()).
So if there are concurrent readdirs on the same directory, they get
serialized. If there is any file ...
| Jan 6, 10:39 pm 2007 |
| H. Peter Anvin | Re: [KORG] Re: kernel.org lies about latest -mm kernel
Just a minor correction; it's the "alternates" file
(objects/info/alternates).
-hpa
-
| Jan 6, 10:17 pm 2007 |
| Greg KH | Re: [KORG] Re: kernel.org lies about latest -mm kernel
Well, I create my repos by doing a:
git clone -l --bare
which makes a hardlink from Linus's tree.
But then it gets copied over to the public server, which probably severs
that hardlink :(
Any shortcut to clone or set up a repo using "alternatives" so that we
don't have this issue at all?
thanks,
greg k-h
-
| Jan 7, 1:11 pm 2007 |
| Linus Torvalds | Jan 6, 9:29 pm 2007 | |
| J.H. | Re: How git affects kernel.org performance
With my gitweb caching changes this isn't as big of a deal as the front
page is only generated once every 10 minutes or so (and with the changes
I'm working on today that timeout will be variable)
- John
-
| Jan 7, 12:12 pm 2007 |
| Linus Torvalds | Re: How git affects kernel.org performance
The sad part is that this is a long-standing issue, and the directory
reading code in ext3 really _should_ be able to do ok.
A year or two ago I did a totally half-assed code for the non-hashed
readdir that improved performance by an order of magnitude for ext3 for a
test-case of mine, but it was subtly buggy and didn't do the hashed case
AT ALL. Andrew fixed it up so that it at least wasn't subtly buggy any
more, but in the process it also lost all capability of doing fragmented ...
| Jan 7, 11:17 am 2007 |
| Jeff Garzik | Re: [KORG] Re: kernel.org lies about latest -mm kernel
Would kernel hackers be amenable to having their trees auto-repacked,
and linked via alternatives to Linus's linux-2.6.git?
Looking through kernel.org, we have a ton of repositories, however
packed, that carrying their own copies of the linux-2.6.git repo.
Also, I wonder if "git push" will push only the non-linux-2.6.git
objects, if both local and remote sides have the proper alternatives set up?
Jeff
-
| Jan 6, 9:22 pm 2007 |
| Willy Tarreau | Re: How git affects kernel.org performance
The problem is that I have no sufficient FS knowledge to argument why
it helps here. It was a desperate attempt to fix the problem for us
and it definitely worked well.
Hmmm I'm thinking about something very dirty : would it be possible
to reduce the current FS size to get more space to create another
FS ? Supposing you create a XX GB/TB XFS after the current ext3,
you would be able to mount it in some directories with --bind and
slowly switch some parts to it. The problem with this approach ...
| Jan 7, 2:03 am 2007 |
| Jan Engelhardt | Re: How git affects kernel.org performance
Much better: rsync from /oldfs to /newfs, stop all ftp uploads, rsync
again to catch any new files that have been added until the ftp
upload was closed, then do _one_ (technically two) mountpoint moves
(as opposed to Willy's idea of "some directories") in a mere second
along the lines of
mount --move /oldfs /older; mount --move /newfs /oldfs.
let old transfers that still use files in /older complete (lsof or
fuser -m), then disconnect the old volume. In case /newfs (now
/oldfs) is a ...
| Jan 7, 3:50 am 2007 |
| Jan Engelhardt | Re: How git affects kernel.org performance
I don't know that acronym, but if you ask me when it should happen:
_Before_ the next big thing is released, e.g. before 2.6.20-final.
Reason: You never know how long they're chewing [downloading] on 2.6.20.
Excluding other projects on kernel.org from my hypothesis, I'd suppose the
lowest bandwidth usage the longer no new files have been released. (Because
everyone has them then more or less.)
-`J'
--
-
| Jan 7, 12:07 pm 2007 |
| Randy Dunlap | Re: How git affects kernel.org performance
Sorry, it means Linux.conf.au (Australia):
http://lca2007.linux.org.au/
ISTM that Linus is trying to make 2.6.20-final before LCA. We'll see.
---
~Randy
-
| Jan 7, 12:28 pm 2007 |
| Krzysztof Halasa | Re: How git affects kernel.org performance
Hmm... Perhaps it should be possible to push git updates as a pack
file only? I mean, the pack file would stay packed = never individual
files and never 256 directories?
People aren't doing commit/etc. activity there, right?
--
Krzysztof Halasa
-
| Jan 7, 8:06 am 2007 |
| Randy Dunlap | Re: How git affects kernel.org performance
---
~Randy
-
| Jan 7, 11:49 am 2007 |
| Linus Torvalds | Re: How git affects kernel.org performance
No. Hopefully "final -rc" before LCA, but I'll do the actual 2.6.20
release afterwards. I don't want to have a merge window during LCA, as I
and many others will all be out anyway. So it's much better to have LCA
happen during the end of the stabilization phase when there's hopefully
not a lot going on.
(Of course, often at the end of the stabilization phase there is all the
"ok, what about regression XyZ?" panic)
Linus
-
| Jan 7, 12:37 pm 2007 |
| Willy Tarreau | Re: How git affects kernel.org performance
Ok. Do you too think it might help (or even solve) the problem on
kernel.org ?
Willy
-
| Jan 7, 3:52 am 2007 |
| Christoph Hellwig | Re: How git affects kernel.org performance
XFS does rather efficient btree directories, and it does sophisticated
readahead for directories. I suspect that's what is helping you there.
-
| Jan 7, 3:28 am 2007 |
| Willy Tarreau | Re: How git affects kernel.org performance
At work, we had the same problem on a file server with ext3. We use rsync
to make backups to a local IDE disk, and we noticed that getdents() took
about the same time as Peter reports (0.2 to 2 seconds), especially in
maildir directories. We tried many things to fix it with no result,
including enabling dirindexes. Finally, we made a full backup, and switched
over to XFS and the problem totally disappeared. So it seems that the
filesystem matters a lot here when there are lots of entries in ...
| Jan 7, 1:55 am 2007 |
| H. Peter Anvin | How git affects kernel.org performance
Some more data on how git affects kernel.org...
During extremely high load, it appears that what slows kernel.org down
more than anything else is the time that each individual getdents() call
takes. When I've looked this I've observed times from 200 ms to almost
2 seconds! Since an unpacked *OR* unpruned git tree adds 256
directories to a cleanly packed tree, you can do the math yourself.
I have tried reducing vm.vfs_cache_pressure down to 1 on the kernel.org
machines in order to ...
| Jan 6, 10:24 pm 2007 |
| Nigel Cunningham | Re: [KORG] Re: kernel.org lies about latest -mm kernel
Hi.
Sorry for the slow reply, and the ignorance... what's an alternatives
file? I've never heard of them before.
Regards,
Nigel
-
| Jan 6, 8:35 pm 2007 |
| Robert Fitzsimons | Re: How git affects kernel.org performance
> Some more data on how git affects kernel.org...
I have a quick question about the gitweb configuration, does the
$projects_list config entry point to a directory or a file?
When it is a directory gitweb ends up doing the equivalent of a 'find
$project_list' to find all the available projects, so it really should
be changed to a projects list file.
Robert
-
| Jan 7, 7:57 am 2007 |
| dean gaudet | [patch] faster vgetcpu using sidt
below is a patch which improves vgetcpu latency on all x86_64
implementations i've tested.
Nathan Laredo pointed out the sgdt/sidt/sldt instructions are
userland-accessible and we could use their limit fields to tuck away a few
bits of per-cpu information.
vgetcpu generally uses lsl at present, but all of sgdt/sidt/sldt are
faster than lsl on all x86_64 processors i've tested. on p4 processers
lsl tends to be 150 cycles whereas the s*dt instructions are 15 cycles or
less. lsl ...
| Jan 6, 7:41 pm 2007 |
| Stelian Pop | Re: sonypi not for 64bit?
Frankly I don't recall anymore. The 64 bit restriction wasn't there from
the beginning, it was added by a patch from someone 2 or 3 years ago.
git doesn't seem to have the history for that, maybe old bk does...
--
Stelian Pop <stelian@popies.net>
-
| Jan 7, 4:09 am 2007 |
| Jan Engelhardt | sonypi not for 64bit?
Hi sonypi (ex-)maintainers ;-)
drivers/char/Kconfig lists SONYPI as being !64BIT, however, there seem
to be sony users with x86_64 [1] around. Is it just caution (it's also
marked EXPERIMENTAL) or is it definitely known to break on 64bit?
-`J'
[1] (a german forum) http://www.linux-club.de/viewtopic.php?t=74400&highlight=sonypi
-
| Jan 6, 7:21 pm 2007 |
| Tom Lanyon | Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file c ...
I've been following this thread for a while now as I started
experiencing file corruption in rtorrent when I upgraded to 2.6.19. I
am using reiserfs.
--
Tom Lanyon
-
| Jan 6, 7:06 pm 2007 |
| Tom Lanyon | Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file c ...
However, moving to 2.6.20-rc3 does indeed seem to fix the issue thus far...
--
Tom Lanyon
-
| Jan 6, 10:58 pm 2007 |
| Andrew Morton | Re: [PATCH] mm: fix page_mkclean_one (was: 2.6.19 file c ...
On Sun, 7 Jan 2007 12:36:18 +1030
reiserfs defaults to data=ordered, so it's quite possibly the same bug.
-
| Jan 6, 11:05 pm 2007 |
| CIJOML | BUG in inotify.c
Hi,
today I got following bug on my 2.6.20-rc3 vanilla kernel:
BUG: at fs/inotify.c:172 set_dentry_child_flags()
[<c0179b74>] set_dentry_child_flags+0x5e/0x149
[<c0179cb2>] remove_watch_no_event+0x53/0x5f
[<c0179da0>] inotify_remove_watch_locked+0x12/0x3e
[<c0179ee2>] inotify_rm_wd+0x6c/0x89
[<c017a58a>] sys_inotify_rm_watch+0x38/0x4f
[<c0102cc8>] syscall_call+0x7/0xb
[<c02d0033>] fib_validate_source+0x1d8/0x22d
=======================
BUG: at fs/inotify.c:172 ...
| Jan 6, 5:16 pm 2007 |
| J.A. | Question on ALSA intel8x0
Hi...
I have a curious issue with snd_intel8x0 ALSA driver:
Jan 7 01:14:27 werewolf-wl kernel: ACPI: PCI interrupt for device 0000:00:1f.5 disabled
Jan 7 01:14:27 werewolf-wl kernel: ACPI: PCI Interrupt 0000:00:1f.5[B] -> GSI 17 (level, low) -> IRQ 21
Jan 7 01:14:27 werewolf-wl kernel: PCI: Setting latency timer of device 0000:00:1f.5 to 64
Jan 7 01:14:27 werewolf-wl kernel: AC'97 0 analog subsections not ready
Jan 7 01:14:27 werewolf-wl kernel: intel8x0_measure_ac97_clock: measured 50136 ...
| Jan 6, 5:29 pm 2007 |
| Jiri Slaby | Re: Experimental driver for Ricoh Bay1Controller SD Card ...
- pci_find_device is no go today. Use pci_get_device (+ pci_dev_get, _put).
- ioremap->pci_iomap
- iobase should be __iomem.
- codingstyle (char* buffer, for(loop, if(data){, ...)
regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
-
| Jan 7, 2:56 am 2007 |
| Zachary Amsden | Re: + spin_lock_irq-enable-interrupts-while-spinning-i38 ...
Yep, that lipstick makes the cat shine.
Zach
-
| Jan 7, 8:17 am 2007 |
| Andrew Morton | Re: + spin_lock_irq-enable-interrupts-while-spinning-i38 ...
On Sun, 07 Jan 2007 05:24:45 -0800
bah.
--- a/include/asm-i386/spinlock.h~spin_lock_irq-enable-interrupts-while-spinning-i386-implementation-fix-fix
+++ a/include/asm-i386/spinlock.h
@@ -14,6 +14,7 @@
#define STI_STRING "sti"
#define CLI_STI_CLOBBERS
#define CLI_STI_INPUT_ARGS
+#define __CLI_STI_INPUT_ARGS
#endif /* CONFIG_PARAVIRT */
/*
_
-
| Jan 7, 1:05 pm 2007 |
| Ravikiran G Thirumalai | Re: + spin_lock_irq-enable-interrupts-while-spinning-i38 ...
Sunday morning hangovers !! spin_lock_irq is not inlined so there is just one
version even with CONFIG_PARAVIRT.
Thanks,
Kiran
-
| Jan 7, 2:27 pm 2007 |
| Daniel Walker | Re: + spin_lock_irq-enable-interrupts-while-spinning-i38 ...
Now it fails with CONFIG_PARAVIRT off .
scripts/kconfig/conf -s arch/i386/Kconfig
CHK include/linux/version.h
CHK include/linux/compile.h
CHK include/linux/utsrelease.h
UPD include/linux/compile.h
CC arch/i386/kernel/asm-offsets.s
In file included from include/linux/spinlock.h:88,
from include/linux/module.h:10,
from include/linux/crypto.h:22,
from arch/i386/kernel/asm-offsets.c:8:
include/asm/spinlock.h: In ...
| Jan 7, 6:24 am 2007 |
| Zachary Amsden | Re: + spin_lock_irq-enable-interrupts-while-spinning-i38 ...
Now it compiles both ways. Or at least asm-offsets.c does. Testing
full build...
Zach
| Jan 7, 7:39 am 2007 |
| Ravikiran G Thirumalai | Re: + spin_lock_irq-enable-interrupts-while-spinning-i38 ...
Apologies for the broken patch and thanks for the fix,
But, the above is needed to fix the build even with CONFIG_PARAVIRT!!!
Apparently because arch/i386/mm/boot_ioremap.c undefs CONFIG_PARAVIRT.
Question is, now we have 2 versions of spin_locks_irq implementation
with CONFIG_PARAVIRT -- one with regular cli sti and other with virtualized
CLI/STI -- sounds odd!
Thanks,
Kiran
-
| Jan 7, 2:06 pm 2007 |
| Andrew Morton | Re: + spin_lock_irq-enable-interrupts-while-spinning-i38 ...
On Sat, 06 Jan 2007 14:35:53 -0800
diff -puN include/asm-i386/spinlock.h~spin_lock_irq-enable-interrupts-while-spinning-i386-implementation-fix include/asm-i386/spinlock.h
--- a/include/asm-i386/spinlock.h~spin_lock_irq-enable-interrupts-while-spinning-i386-implementation-fix
+++ a/include/asm-i386/spinlock.h
@@ -86,17 +86,19 @@ static inline void __raw_spin_lock_flags
static inline void __raw_spin_lock_irq(raw_spinlock_t *lock)
{
asm volatile("\n1:\t"
- LOCK_PREFIX " ; decb ...
| Jan 7, 12:26 am 2007 |
| Adrian Bunk | Re: 2.6.20-rc3: known unfixed regressions (v4)
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
| Jan 7, 4:49 pm 2007 |
| Randy Dunlap | Re: [KORG] Re: kernel.org lies about latest -mm kernel
Hi,
I'm sure that all of this ext3fs etc. discussion is good,
but let me clarify: I would be much happier if the kernel.org
main page and the finger_banner info were updated at the same
time that new tarballs were put onto kernel.org.
Now someone may say that this is still the rsync/load problem,
---
~Randy
-
| Jan 7, 12:52 pm 2007 |
| H. Peter Anvin | Re: [KORG] Re: kernel.org lies about latest -mm kernel
If we did that, we'd get thousands of "this link doesn't work".
-
| Jan 7, 4:56 pm 2007 |
| Bartlomiej Zolnierki ... | Re: libata error handling
some were backported directly from libata driver and few were
-
| Jan 7, 1:38 pm 2007 |
| Kasper Sandberg | Jan 7, 1:07 pm 2007 | |
| Jesper Juhl | Re: [PATCH 2.6.20-rc3] DAC960: kmalloc->kzalloc/Casting ...
Sending the patch to LKML and Cc'ing Andrew and KJ would be my approach.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
| Jan 6, 7:48 pm 2007 |
| Ahmed S. Darwish | Re: [PATCH 2.6.20-rc3] DAC960: kmalloc->kzalloc/Casting ...
Should Kernel janitors then care of cleaning orphaned files ?.
If so, I should forward it to Andrew Morton without CCing LKML again, right ?
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
| Jan 6, 7:00 pm 2007 |
| Randy Dunlap | Re: [PATCH 2.6.20-rc3] DAC960: kmalloc->kzalloc/Casting ...
Kernel janitors could do that (IMO). It's up to you where you want
I would expect that Andrew has seen the patch. Anyway, you should
always send the patch to a mailing list and usually to a specific
maintainer also (like Andrew or a subsystem maintainer or the KJ
maintainer). [except for some security-related patches]
---
~Randy
-
| Jan 6, 7:31 pm 2007 |
| Alan | Re: [PATCH 2.6.20-rc3] DAC960: kmalloc->kzalloc/Casting ...
> Should Kernel janitors then care of cleaning orphaned files ?.
If you have the hardware to run tests then yes, if not then they are best
handled with caution. Working is preferred to pretty.
Alan
-
| Jan 6, 7:38 pm 2007 |
| Jesper Juhl | Re: [PATCH 2.6.20-rc3] DAC960: kmalloc->kzalloc/Casting ...
Sending the patch to LKML and Cc'ing Andrew and KJ would be my approach.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
| Jan 6, 7:49 pm 2007 |
| Roman Zippel | Re: qconf handling NULL pointers
Hi,
The code isn't really supposed to deal with it, at most they could be replaced
with a variant that prints an error message and exits.
bye, Roman
-
| Jan 6, 7:23 pm 2007 |
| Bartlomiej Zolnierki ... | Re: [PATCH 3/3] atiixp.c: add cable detection support fo ...
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
[ the one is also line wrapped, please resend them ]
-
| Jan 6, 7:16 pm 2007 |
| Bartlomiej Zolnierki ... | Re: [PATCH 2/3] atiixp.c: sb600 ide only has one channel
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
[ but the patch is line wrapped ]
-
| Jan 6, 7:14 pm 2007 |
| Bartlomiej Zolnierki ... | Re: [PATCH 1/3] atiixp.c: remove unused code
This one?
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ab1744...
Doesn't it break existing setups without giving ANY warning?
theoretical (I don't have hardware in question) scenario:
- user uses atiixp and has modular libata/ahci (or no libata/ahci et all)
- user does kernel upgrade
- boot fails
- ...
If this is true please add something like
printk(KERN_WARNING "PCI: setting SB600 SATA to AHCI mode"
" (please use ...
| Jan 6, 7:12 pm 2007 |
| Philippe De Muyter | Re: RTC subsystem and fractions of seconds
That would require changing the interface provided by the rtc class, but
--
-
| Jan 7, 3:02 am 2007 |
| Hugh Dickins | Re: RTC subsystem and fractions of seconds
Perhaps I'm muddled - I was thinking of this and its associates:
commit 63732c2f37093d63102d53e70866cf87bf0c0479
Author: Matt Mackall <mpm@selenic.com>
Date: Tue Mar 28 01:55:58 2006 -0800
[PATCH] RTC: Remove RTC UIP synchronization on x86
Reading the CMOS clock on x86 and some other arches currently takes up to one
second because it synchronizes with the CMOS second tick-over. This delay
shows up at boot time as well a resume time.
This is the currently ...
| Jan 7, 2:43 am 2007 |
| Hugh Dickins | Re: RTC subsystem and fractions of seconds
If you're thinking of going that way, it'd be courteous to CC Matt,
who devoted some effort to removing just that loop in 2.6.17 ;)
Hugh
-
| Jan 6, 6:11 pm 2007 |
| Philippe De Muyter | Re: RTC subsystem and fractions of seconds
One usefull addition for my needs and with a m41t81 is the support of
the calibration of the rtc. However this can perhaps be hidden in the
.set_mmss function.
Philippe
--
-
| Jan 7, 3:14 am 2007 |
| David Brownell | Re: RTC subsystem and fractions of seconds
Hmm ... "git whatchanged drivers/rtc/hctosys.c" shows no such change.
So I can't find any record of such a change or its rationale.
- dave
-
| Jan 6, 7:54 pm 2007 |
| David Chinner | Re: BUG: warning at mm/truncate.c:60/cancel_dirty_page()
Only when you are doing direct I/O. XFS does direct writes without
the i_mutex held, so it has to invalidate the range of cached pages
while holding it's own locks to ensure direct I/O cache semantics are
Ok, so we are punching a hole in the middle of the address space
because we are doing direct I/O on it and need to invalidate the
cache.
How are you supposed to invalidate a range of pages in a mapping for
this case, then? invalidate_mapping_pages() would appear to be the
candidate (the ...
| Jan 7, 3:23 pm 2007 |
| Andrew Morton | Re: BUG: warning at mm/truncate.c:60/cancel_dirty_page()
On Mon, 8 Jan 2007 09:23:41 +1100
That would be conventional.
-
| Jan 7, 3:48 pm 2007 |
| Sami Farin | Re: BUG: warning at mm/truncate.c:60/cancel_dirty_page()
BUG does not happen if I do not do "strace cinfo dtfile" with O_DIRECT
test file. It's easy to reproduce.
Without strace BUG does not happen.
Now I got it again, with also the mincore patch applied:
01:48:42.831060 mincore(0x37ff1000, 2147254272, ^[
2007-01-07 01:48:51.480531500 <4>BUG: warning at mm/truncate.c:60/cancel_dirty_page()
2007-01-07 01:48:51.480532500 <4> [<c0103cff>] dump_trace+0x215/0x21a
2007-01-07 01:48:51.480557500 <4> [<c0103da7>] ...
| Jan 6, 6:24 pm 2007 |
| David Chinner | Re: BUG: warning at mm/truncate.c:60/cancel_dirty_page()
/me looks at how it's used in invalidate_inode_pages2_range() and
.... in that case the following patch should fix the warning:
---
fs/xfs/linux-2.6/xfs_fs_subr.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_fs_subr.c
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_fs_subr.c 2006-12-12 12:05:17.000000000 +1100
+++ ...
| Jan 7, 4:04 pm 2007 |
| Dave Hansen | Re: [PATCH] Fix sparsemem on Cell (take 3)
You are right, I think it does.
Here's an updated patch to replace the earlier one. I had to move the
enum definition over to a different header because ia64 evidently has a
different include order.
---
The following patch fixes an oops experienced on the Cell architecture
when init-time functions, early_*(), are called at runtime. It alters
the call paths to make sure that the callers explicitly say whether the
call is being made on behalf of a hotplug even, or happening ...
| Jan 7, 1:58 am 2007 |
| Arnd Bergmann | Re: [PATCH] Fix sparsemem on Cell (take 3)
I can't test it here, since I'm travelling at the moment, but
Acked-by: Arnd Bergmann <arndb@de.ibm.com>
-
| Jan 7, 5:07 am 2007 |
| Christoph Hellwig | Re: [patch] paravirt: isolate module ops
Even better we can actualy avid most of the page table walks completely.
First there is a number of places that can never have the vmalloc case
an may use ioremap/iounmap directly. Secondly drm_core_ioremap/
drm_core_ioremapfree already have the right drm_map to check wich kind
of mapping we have - we just need to use it instead of discarding that
information! The only leaves direct drm_ioremapfree in i810_dma.c and
i830_dma.c which I don't quite manage to follow. Maybe Dave has an
idea how ...
| Jan 7, 11:39 am 2007 |
| Rusty Russell | Re: [patch] paravirt: isolate module ops
Yes, but this is simply from experience. Several modules wrote msrs
Several modules implement alternate halt loops. I guess being in a
module for specific CPUs makes sense...
Cheers!
Rusty.
-
| Jan 6, 6:09 pm 2007 |
| Ingo Molnar | Re: [patch] paravirt: isolate module ops
agreed. I think there's an important side-observation here as well:
having inlined functions uninlined and exported puts them under a lot
more scrutiny. Hence individual exports instead of the global
paravirt_ops export is a big plus.
Ingo
-
| Jan 7, 11:43 am 2007 |
| Zachary Amsden | Re: [patch] paravirt: isolate module ops
Several in tree, GPL'd modules did so. I'm not aware of out of tree
modules that do that, and if they do, they are misbehaving.
Reprogramming MTRR memory regions under the kernel's nose is not a
proper way to behave, and this is the most benign use I can think of for
write access to MSRs. If this really breaks any code out there, then
there should be a proper, controlled API to do this so the kernel can
Yes, but halting is a behavior that can easily introduce critical, grind
to a ...
| Jan 7, 7:07 am 2007 |
| Rusty Russell | Re: [patch] paravirt: isolate module ops
Thanks Christoph, that patch looks great to me! I didn't know about
vmalloc_to_page...
Want to produce a signed-off version?
Thanks,
Rusty.
-
| Jan 6, 10:35 pm 2007 |
| Michael Ellerman | Re: [PATCH] increment pos before looking for the next ca ...
Guilty as charged :/
cheers
--=20
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
| Jan 7, 4:37 pm 2007 |
| gregkh | patch pci-increment-pos-before-looking-for-the-next-cap- ...
This is a note to let you know that I've just added the patch titled
Subject: PCI: increment pos before looking for the next cap in __pci_find_next_ht_cap
to my gregkh-2.6 tree. Its filename is
pci-increment-pos-before-looking-for-the-next-cap-in-__pci_find_next_ht_cap.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
| Jan 6, 11:54 pm 2007 |
| Tom Lanyon | Re: runaway loop modprobe binfmt-0000
Thanks for the reply, Andrew.
How interesting... added that to kmod.c, rebuilt without change to
config, reboot.... machine booted perfectly!
I'm going to leave it for now, but I'll leave the dump_stack() call in
there in case further issues arise.
Regards
--
Tom Lanyon
-
| Jan 7, 3:19 pm 2007 |
| Hollis Blanchard | Re: [kvm-devel] [announce] [patch] KVM paravirtualizatio ...
Strongly agreed. One of the major problems we had with the PowerPC Xen
port was that Xen passes virtual addresses (even userspace virtual
addresses!) to the hypervisor. Performing a MMU search on PowerPC is far
more convoluted than x86's table walk and is not feasible in software.
I'm anxious to avoid the same mistake wherever possible.
Of course, even with physical addresses, data structures that straddle
page boundaries prevent the hypervisor from mapping contiguous physical
pages to ...
| Jan 7, 10:42 am 2007 |
| Avi Kivity | Re: [announce] [patch] KVM paravirtualization for Linux
Very impressive! The gain probably comes not only from avoiding the
vmentry/vmexit, but also from avoiding the flushing of the global page
This is a little too good to be true. Were both runs with the same
KVM_NUM_MMU_PAGES?
I'm also concerned that at this point in time the cr3 optimizations will
only show an improvement in microbenchmarks. In real life workloads a
context switch is usually preceded by an I/O, and with the current sorry
Well, you did say it was ad-hoc. For ...
| Jan 7, 5:20 am 2007 |
| Ingo Molnar | Re: [announce] [patch] KVM paravirtualization for Linux
90% of the win comes from the avoidance of the VM exit. To quantify this
more precisely i have added an artificial __flush_tlb_global() call to
after switch_to(), just to see how much impact an extra global flush has
on the native kernel. Context-switch cost went from 1.11 usecs to 1.65
usecs. Then i added a __flush_tlb(), which made the cost go to 1.75,
yes, both had the same elevated KVM_NUM_MMU_PAGES of 2048. The 'trunk'
run should have been labeled as: 'cr3 tree with paravirt ...
| Jan 7, 10:44 am 2007 |
| Christoph Hellwig | Re: [announce] [patch] KVM paravirtualization for Linux
After all the Novell Marketing Hype you'll probably have to keep Xen ;-)
Except for that I suspect a paravirt kvm or lhype might be the better
hypervisor choice in the long term.
-
| Jan 7, 11:29 am 2007 |
| Dave Jones | Re: [PATCH 1/2 v3] sysrq: showBlockedTasks is sysrq-W
On Sat, Jan 06, 2007 at 02:04:24PM -0800, Randy Dunlap wrote:
> + .help_msg = "showBlockedTasks(W)",
Why not the same scheme as the existing help msgs..
shoWblockedtasks ?
Dave
--
http://www.codemonkey.org.uk
-
| Jan 6, 5:09 pm 2007 |
| Randy Dunlap | [PATCH 1/2 v4] sysrq: showBlockedTasks is sysrq-W
Would shoW-blocked-tasks be OK?
---
From: Randy Dunlap <randy.dunlap@oracle.com>
Change SysRq showBlockedTasks from sysrq-X to sysrq-W and show that
in the Help message.
It was previously done via X, but X is already used for Xmon
on ppc & powerpc platforms and this collision needs to be avoided.
All callers of register_sysrq_key() are now marked in the
sysrq op/key table. I didn't mark 'h' as Help because Help
is just printed for any unknown key, such as '?'.
Added some omitted ...
| Jan 6, 7:36 pm 2007 |
| Dave Jones | Re: [PATCH 1/2 v4] sysrq: showBlockedTasks is sysrq-W
On Sat, Jan 06, 2007 at 06:36:28PM -0800, Randy Dunlap wrote:
> On Sat, 6 Jan 2007 19:09:45 -0500 Dave Jones wrote:
>
> > On Sat, Jan 06, 2007 at 02:04:24PM -0800, Randy Dunlap wrote:
> >
> > > + .help_msg = "showBlockedTasks(W)",
> >
> > Why not the same scheme as the existing help msgs..
>
> Yes. Thanks.
>
> > shoWblockedtasks ?
>
> Would shoW-blocked-tasks be OK?
Works for me.
thanks,
Dave
--
http://www.codemonkey.org.uk
-
| Jan 6, 7:41 pm 2007 |
| Russell King | Re: [patch 2.6.20-rc3 1/3] rtc-cmos driver
Woody will be using a Netwinder (he's part of the original development
team.) So no sleep states and therefore no wakeup.
There's various other ARM-based systems using the PC RTC, but none of
them have sleep or wakeup abilities afaik.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
| Jan 7, 2:02 am 2007 |
| Randy Dunlap | Re: [PATCH] Discuss a couple common errors in kernel-doc ...
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
---
~Randy
-
| Jan 6, 9:00 pm 2007 |
| Pavel Machek | Re: [PATCH] Discuss a couple common errors in kernel-doc ...
Can we shout a bit less?
Pavel
--
Thanks for all the (sleeping) penguins.
-
| Jan 7, 4:36 am 2007 |
| Mark M. Hoffman | Re: [-mm patch] drivers/pci/quirks.c: cleanup
Hi Jean, Adrian, et. al.:
It's just cruft from the original quirk. The "compatible" printk could have
had value as a diagnostic in case the new quirk didn't work for some reason,
but I never saw any complaints about it (apart from the link order problem,
which is something different.) It's safe to remove by now.
Regards,
--
Mark M. Hoffman
mhoffman@lightlink.com
-
| Jan 7, 8:40 am 2007 |
| Mark M. Hoffman | Re: [-mm patch] drivers/pci/quirks.c: cleanup
It is fragile for this code to depend on link order; Adrian's obvious and
trivial cleanups broke it. Not only that, but some FC kernels had/have the
link order reversed such that this quirk is broken anyway.
I sent a patch for this back in May:
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-May/016113.html
There was some discussion on the linux-pci mailing list as well; can't seem to
find an archive of that though. Basically, it was not understood how the FC
kernels could have a ...
| Jan 7, 8:44 am 2007 |
| Jean Delvare | Re: [-mm patch] drivers/pci/quirks.c: cleanup
Hi Adrian,
I noticed this too in April 2006, see:
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-April/016016.html
Quoting myself back then:
"The whole sis_96x_compatible stuff looks superfluous now. It was used
before 2.6.0-test10, but we could certainly get rid of it now."
I do not think there is a bug here, or someone would have complained by
now. Note though that I do not have a SiS-based motherboard to test on.
Mark may be able to help with testing.
Thanks,
--
Jean ...
| Jan 7, 4:30 am 2007 |
| Valdis.Kletnieks | Re: 2.6.20-rc3-mm1 - reiser4-sb_sync_inodes.patch causes ...
Confirming that reiser4-sb_sync_inodes-fix.patch fixes my problem.
| Jan 6, 5:28 pm 2007 |
| Valdis.Kletnieks | Re: 2.6.20-rc3-mm1 - rewrite-lock-in-cpufreq-to-eliminat ...
Yes, that fixes the problem. Thanks.
| Jan 6, 5:29 pm 2007 |
| Mauro Carvalho Chehab | Re: 2.6.20-rc3-git4 oops on suspend: __drain_pages
This fixed for me too with kernel 2.6.19.1. On my machine, every second
trial to unplug the second CPU core were generating OOPS, and breaking
hibernation. I've opened a bugzilla (#7786).
There is a remain stuff to be fixed, related to cpuhotplug: kernel with
debug options enabled shows that there is a circular locking dependency
(http://bugzilla.kernel.org/attachment.cgi?id=10020&action=view):
=======================================================
[ INFO: possible circular locking ...
| Jan 7, 3:34 pm 2007 |
| Pekka Enberg | Jan 7, 9:33 am 2007 | |
| Justin Rosander | Re: PROBLEM: LSIFC909 mpt card fails to recognize devices
Hi Eric,
I tried recompiling the kernel per your instructions, but I got a
failure here:
CC [M] drivers/message/fusion/mptbase.o
drivers/message/fusion/mptbase.c: In function ‘mpt_resume’:
drivers/message/fusion/mptbase.c:1526: warning: ignoring return value of ‘pci_enable_device’, declared with attribute warn_unused_result
CC [M] drivers/message/fusion/mptscsih.o
drivers/message/fusion/mptscsih.c: In function ‘mptscsih_initTarget’:
...
| Jan 7, 11:07 am 2007 |
| Willy Tarreau | Re: Multi kernel tree support on the same distro?
[ CC list trimmed since I'm repeating myself ]
As I already explained in another mail, 2.4.34 builds with gcc-4.1 on x86
and a few other archs. I also explained how to do this :
$ make CC=gcc-4.1
I don't know how I can explain it to you an easier way, but what I'm sure
about is that if you are having such big trouble understanding simple
commands like this, you will certainly encounter many more when building
That's what I understood and the need I replied too the first ...
| Jan 7, 7:32 am 2007 |
| Willy Tarreau | Re: Multi kernel tree support on the same distro?
I don't see which libs you are talking about. The compiler you build your
kernel with is totally independant on the compiler you build your apps with.
A few years ago, some distros even shipped a compiler just for the kernel
(they called the binary "kgcc").
So you just have to build 2 different GCC, one for 2.4, one for 2.6 and
you use them to build your kernels. If you want yet another compiler for
your apps, simply do it, it's not a problem. For instance, look on my
system when I type gcc- ...
| Jan 7, 6:20 am 2007 |
| Akula2 | Re: Multi kernel tree support on the same distro?
I have understood that, it seems I have confused (and myself too) with
Thanks a lots for your inputs. I shall post more questions once I
~Akula2
-
| Jan 7, 10:52 am 2007 |
| Akula2 | Re: Multi kernel tree support on the same distro?
That's correct about gcc-3.4.x & gcc-4.1.x about 2.6 tree support.
This means 2.6 supports both gcc versions. Here are the binaries I do
use:-
http://download.fedora.redhat.com/pub/fedora/linux/core/3/i386/os/Fedora/RPMS/gcc-3.4....
http://download.fedora.redhat.com/pub/fedora/linux/core/3/i386/os/Fedora/RPMS/kernel-2...
Now issue remains with 2.4 tree. Is it possible to build/install
gcc-4.1.x along with gcc-3.4.x? This is what am trying to figure by
few tests ...
| Jan 7, 6:11 am 2007 |
| Akula2 | Re: Multi kernel tree support on the same distro?
Sorry for the typo & confusion caused. I meant in that example as:-
myArmWireless app. compiled with gcc-3.4.x, NOT gcc-4.1.x compiler on
say 2.4.34 kernel (assuming I can build 4.1.x on 2.4.34 kernel).
Now, I've got it about this app funda. Ok! Am coming closer now. I
have these 2 tasks:-
a) Since 2.6 kernel has no issues with gcc-3.4.x, gcc-4.1.x. So I will
build them. No probs here.
b) 2.4 kernel has no issues with gcc-3.4.x to my understanding, but am
not sure about compiling it ...
| Jan 7, 7:19 am 2007 |
| Willy Tarreau | Re: Multi kernel tree support on the same distro?
2.4 was designed for gcc 2.95.3 and supports gcc up to 3.4 on all platforms,
and up to 4.1 on x86, x86_64, ppc and sparc64. Recent gcc 3.4 produces good
code on 2.4, and is able to efficiently optimize for size (-Os) without too
Hmm, I think you did it the *hard* way. Gcc has been supporting
multi-version for years. You just have to compile it with --suffix=-3.4
or --suffix=4.1 to have a whole collection of gcc versions on your host.
If you don't want to recompile gcc, simply rename the ...
| Jan 7, 2:30 am 2007 |
| Pavel Pisa | Re: [PATCH 2.6.19] mmc: Fix handling of response types i ...
Hello Philip,
I have tested your patch.
Kernel builds. I have not found much time for testing.
But I would not like to block changes and I am going
for next week to project meeting in Spain, so there is
my reply.
I have 2.6.19 + realtime-patches rt14 on the hand.
I have been able to mount and use some cards, but it
I have observed some problems probably related to timing
when I have tried to change CPU frequency.
I need to find time to do more checking on vanilla and RT kernels
when I ...
| Jan 7, 10:34 am 2007 |
| Oleg Nesterov | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
How about:
CPU_DEAD does nothing. After __cpu_disable() cwq->thread runs on
all CPUs and becomes idle when it flushes cwq->worklist: nobody
will add work_struct on that list.
CPU_UP:
if (!cwq->thread)
create_workqueue_thread();
else
set_cpus_allowed(newcpu);
flush_workqueue:
for_each_possible_cpu() // NOT online!
if (cwq->thread)
flush_cpu_workqueue()
Oleg.
-
| Jan 7, 7:22 am 2007 |
| Oleg Nesterov | [PATCH] flush_cpu_workqueue: don't flush an empty ->worklist
Now when we have ->current_work we can avoid adding a barrier and waiting for
its completition when cwq's queue is empty.
Note: this change is also useful if we change flush_workqueue() to also check
the dead CPUs.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- mm-6.20-rc3/kernel/workqueue.c~1_opt 2007-01-07 23:15:50.000000000 +0300
+++ mm-6.20-rc3/kernel/workqueue.c 2007-01-07 23:26:45.000000000 +0300
@@ -405,12 +405,15 @@ static void wq_barrier_func(struct work_
...
| Jan 7, 2:01 pm 2007 |
| Srivatsa Vaddagiri | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
How would this provide a stable access to cpu_online_map in functions
that need to block while accessing it (as flush_workqueue requires)?
--
Regards,
vatsa
-
| Jan 7, 4:00 am 2007 |
| Oleg Nesterov | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
But cwq->thread is not bound to the dead CPU at this point, it was aleady
I guess you misunderstood me, I meant CPU_DEAD does nothing only in
workqueue.c:workqueue_cpu_callback().
Oleg.
-
| Jan 7, 10:18 am 2007 |
| Srivatsa Vaddagiri | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
I guess you could have cwq->thread flush only it's cpu's workqueue by
running on another cpu, which will avoid the need to synchronize
between worker threads. I am not 100% sure if that breaks workqueue
model in any way (since we could have two worker threads running on the
same CPU, but servicing different queues). Hopefully it doesnt.
--
Regards,
vatsa
-
| Jan 7, 10:01 am 2007 |
| Srivatsa Vaddagiri | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
If run_workqueue() takes a lock_cpu_hotplug() successfully, then we shouldnt
even reach till this point, as it will block writers (cpu_down/up) until it
completes.
run_workqueue()
---------------
try_again:
rc = lock_cpu_hotplug_interruptible();
if (rc && kthread_should_stop())
return;
if (rc != 0)
goto try_again;
/* cpu_down/up shouldnt happen now untill we call unlock_cpu_hotplug */
while (!list_empty(..))
work->func();
unlock_cpu_hotplug();
If ...
| Jan 7, 9:21 am 2007 |
| Andrew Morton | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
On Sun, 7 Jan 2007 16:30:13 +0530
If a thread simply blocks, that will not permit a cpu plug/unplug to proceed.
The thread had to explicitly call try_to_freeze(). CPU plug/unplug will
not occur (and cpu_online_map will not change) until every process in the
machine has called try_to_freeze()).
So the problem which you're referring to will only occur if a workqueue
callback function calls try_to_freeze(), which would be mad.
Plus flush_workqueue() is on the way out. We're slowly ...
| Jan 7, 12:59 pm 2007 |
| Oleg Nesterov | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
This mean that every work->func() which may sleep delays cpu_down/up unpredictable,
not good. What about work->func which sleeps then re-queues itself? I guess we can
solve this, but this is what I said "other changes".
Also, lock_cpu_hotplug() should be per-cpu, otherwise we have livelock.
Not that I am against lock_cpu_hotplug (I can't judge), but its usage in run_workqueue
looks like complication to me. I may be wrong. But the main problem we don't have it :)
Oleg.
-
| Jan 7, 10:09 am 2007 |
| Oleg Nesterov | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
Also, we can add cpu_workqueue_struct->should_exit_after_flush flag, but
-
| Jan 7, 7:42 am 2007 |
| Oleg Nesterov | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
So. If we can forget about the race we have - fine. Otherwise, how about the
patch below? It is untested and needs a review. I can't suggest any simpler
now.
Change flush_workqueue() to use for_each_possible_cpu(). This means that
flush_cpu_workqueue() may hit CPU which is already dead. However in that
case
if (!list_empty(&cwq->worklist) || cwq->current_work != NULL)
means that CPU_DEAD in progress, it will do kthread_stop() + take_over_work()
so we can proceed and insert a barrier. We ...
| Jan 7, 2:51 pm 2007 |
| Oleg Nesterov | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
Srivatsa, I'm completely new to cpu-hotplug, so please correct me if I'm
wrong (in fact I _hope_ I am wrong) but as I see it, the hotplug/workqueue
interaction is broken by design, it can't be fixed by changing just locking.
Once again. CPU dies, CPU_DEAD calls kthread_stop() and sleeps until
cwq->thread exits. To do so, this thread must at least complete the
currently running work->func().
work->func() calls flush_workque(WQ), it does lock_cpu_hotplug() or
_whatever_. Now the question, ...
| Jan 7, 5:56 am 2007 |
| Oleg Nesterov | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
please see the previous message.
Srivatsa, I don't claim my idea is the best. Actually I still hope somebody
else will suggest something better and simpler :)
Oleg.
-
| Jan 7, 10:33 am 2007 |
| Srivatsa Vaddagiri | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
^^^
If CPU_DEAD does nothing, then the dead cpu's workqueue list may be
non-empty. How will it be flushed, given that no thread can run on the
dead cpu?
We could consider CPU_DEAD moving over work atleast (and not killing
worker threads also). In that case, cwq->thread can flush its work,
however it now requires serialization among worker threads, since more
than one worker thread can now be servicing the same CPU's workqueue
list (this will beat the very purpose of maintaining per-cpu ...
| Jan 7, 9:43 am 2007 |
| Srivatsa Vaddagiri | Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
Well ..a lock_cpu_hotplug() in run_workqueue() and support for recursive
calls to lock_cpu_hotplug() by the same thread will avoid the problem
you mention. This will need changes to task_struct to track the
recursion depth. Alternately this can be supported w/o changes to
task_struct by 'biasing' readers over writers as I believe Gautham's
patches [1] do.
1. http://lkml.org/lkml/2006/10/26/65
--
Regards,
vatsa
-
| Jan 7, 3:43 am 2007 |
| Mauro Carvalho Chehab | Re: [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()
Hmm... there are some discussions currently on v4l ML about the need to
add some standards to support some digital streams, like those used on
webcams. Depending on the result of those discussions, we can need to
use more bits. So, I think it is not worth right now to replace video
std on every place it occurs.
Ok, I've wrote such patch. I should send today or tomorrow to Linus,
Cheers,
Mauro.
-
| Jan 7, 4:44 am 2007 |
| Jeff Garzik | Re: kernel + gcc 4.1 = several problems
Yep, a ton of work by Roger Sayle, among others, really matured the gcc
str*/mem* builtins in the 4.x series. They are definitely worth another
look.
Jeff
-
| Jan 6, 10:26 pm 2007 |
| Linus Torvalds | Re: kernel + gcc 4.1 = several problems
Yeah. For a more relevant case, look at the hoops we used to jump through
to get "memcpy()" to generate ok code for trivial fixed-sized cases.
(That said, I think __builtin_memcpy() does a reasonable job these days
with gcc, and we might drop the crap one day when we can trust the
compiler to do ok. It didn't use to, and we continued using our
ridiculous macro/__builtin_constant_p misuses just because it works with
_all_ relevant gcc versions).
Linus
-
| Jan 6, 9:45 pm 2007 |
| Segher Boessenkool | Re: kernel + gcc 4.1 = several problems
i686-linux-gcc (GCC) 4.2.0 20060410 (experimental)
movl $4, %ecx #, tmp65
cld
movl $v, %esi #, tmp63
movl $.LC0, %edi #, tmp64
repz
cmpsb
sete %al #, tmp68
Still not perfect, but better already. If you have any
specific examples that you'd like to have compiled to
better code, please report them in GCC bugzilla (with a
self-contained testcase, please).
Segher
-
| Jan 7, 8:10 am 2007 |
| Denis Vlasenko | Re: kernel + gcc 4.1 = several problems
I'd say "care about obvious, safe optimizations which we still not do".
I want this:
char v[4];
...
memcmp(v, "abcd", 4) == 0
compile to single cmpl on i386. This (gcc 4.1.1) is ridiculous:
.LC0:
.string "abcd"
.text
...
pushl $4
pushl $.LC0
pushl $v
call memcmp
addl $12, %esp
testl %eax, %eax
There are tons of examples where you can improve code generation.
--
vda
-
| Jan 6, 9:25 pm 2007 |
| David Woodhouse | Re: useless asm/page.h exported to userspace for some ar ...
I think we can kill off <asm/elf.h> too -- the only interesting parts
are in <asm/auxvec.h>, aren't they?
--
dwmw2
-
| Jan 7, 8:29 am 2007 |
| David Chinner | Re: xfs_file_ioctl / xfs_freeze: BUG: warning at kernel/ ...
Oh, that still hasn't been fixed? Generic bug, not XFS - the global
semaphore->mutex cleanup converted the bd_mount_sem to a mutex, and
mutexes complain loudly when a the process unlocking the mutex is
not the process that locked it.
Basically, the generic code is broken - the bd_mount_mutex needs to
be reverted back to a semaphore because it is locked and unlocked
by different processes. The following patch does this....
BTW, Sami, can you cc xfs@oss.sgi.com on XFS bug reports in ...
| Jan 7, 2:37 pm 2007 |
| Roman Zippel | Re: [UPDATED PATCH] fix memory corruption from misinterp ...
Hi,
PPS: I still don't like it. It fixes a rather theoretical problem with
absolutely no practical relevance.
PPPS: type safety is also possible with container_of(), the prototype
patch below demonstrates how to check that the signature matches and
additionally it doesn't require to convert everything at once. More
sophisticated checks can be done by putting this information into a
separate section, from where it can be extracted at compile/run time.
bye, Roman
---
...
| Jan 6, 7:14 pm 2007 |
| Tejun Heo | Re: PROBLEM: sata_sil24 lockups under heavy i/o
Hello,
Mark Wagner wrote:
It seems like your system is falling apart. Timeouts are occurring
everywhere. Either IRQ routing went wrong or your powersupply is not
providing enough power. Adding two more disks to sil24 doesn't change
anything about IRQ routing. If the system functioned okay w/ two disks
attached to sil24, give your system a better power supply or rewire
power cables such that each power lane is more equally loaded.
--
tejun
-
| Jan 6, 11:27 pm 2007 |
| Pavel Machek | Re: kernel + gcc 4.1 = several problems
stupid idea... perhaps gcc-4.1 generates bigger stackframe somewhere,
and stack overflows?
that hw monitoring thingie... I'd turn it off. Its interactions with
acpi are non-trivial and dangerous.
Pavel
--
Thanks for all the (sleeping) penguins.
-
| Jan 6, 5:36 pm 2007 |
| Alistair John Strachan | Re: kernel + gcc 4.1 = several problems
On Sunday 07 January 2007 00:36, Pavel Machek wrote:
The primary reason it's not 4KSTACKS already is that I run multiple XFS
partitions on top of an md RAID 1. LVM isn't involved, however, and I'm not
using any other filesystem overlays like dm.
I'm fairly sceptical that it's a stack overflow, but I'll be sure to enable
Well, GCC 3.4 kernels seem to run fine with it, but as I said to Linus I'll be
sure to turn this and the sound drivers off in the next build.
-- ...
| Jan 6, 5:57 pm 2007 |
| Jeremy Fitzhardinge | Re: [PATCH] romsignature/checksum cleanup
Well, I was wondering about all the uses of __get_user; why not
probe_kernel_address() everywhere?
I think its reasonable to assume that if the signature is mapped and
correct, then everything else is mapped. That's certainly the case for
Xen, which is why I added it. If you think this is unclear, then I
think a comment to explain this rather than code changes is the
appropriate fix.
J
-
| Jan 7, 3:20 am 2007 |
| Rene Herman | Re: [PATCH] romsignature/checksum cleanup
How is it for efficiency? I thought it was for correctness. romsignature
is using probe_kernel_adress() while all other accesses to the ROMs
there aren't.
If nothing else, anyone reading that code is likely to ask himself the
very same question -- why the one, and not the others.
Rene.
-
| Jan 7, 2:02 am 2007 |
| Jeremy Fitzhardinge | Re: [PATCH] romsignature/checksum cleanup
I don't think this is worthwhile. Its hardly a performance-critical
piece of code, and I think its better to use the straightforward
interface rather than complicating it for some nominal extra efficiency.
J
-
| Jan 7, 1:59 am 2007 |
| Jeremy Fitzhardinge | Re: [PATCH] romsignature/checksum cleanup
Why? It's a bit of a performance hit, but that doesn't matter here.
probe_kernel_address() is semantically the right thing to be using;
open-coding its contents to avoid a few fairly cheap operations is a
My point is that "__get_user" doesn't make much semantic sense here:
we're not talking about usermode pages. We used to use it quite often
for cases where an access may or may not fault, but now we spell that
I don't strongly object to using probe_kernel_address() for all ROM
memory ...
| Jan 7, 11:07 am 2007 |
| Rene Herman | Re: [PATCH] romsignature/checksum cleanup
It's just a manual version of probe_kernel_adress():
#define probe_kernel_address(addr, retval) \
({ \
long ret; \
mm_segment_t old_fs = get_fs(); \
\
set_fs(KERNEL_DS); \
pagefault_disable(); \
ret = ...
| Jan 7, 3:47 am 2007 |
| Pavel Pisa | [PATCH] DocBook/HTML: correction of recursive A tags in ...
The malformed HTML was generated after switch to XSLTPROC
from SGML tools. The reference title
<refentrytitle><phrase id="API-struct-x">struct x</phrase></refentrytitle>
is converted into two recursive <a> tags
<a href="re02.html"><span><a id="API-struct-x"></a>struct x</span></a>
There is more possible solutions for this problem.
One can be found at
http://darkk.livejournal.com/
The proposed solution is based on suggestion provided by Jiri Kosek.
Signed-off-by: Pavel Pisa ...
| Jan 7, 1:23 pm 2007 |
| Berthold Cogel | Re: Regression in kernel linux-2.6.20-rc1/2: Problems wi ...
Hi Alex!
I did what you suggested. First I replaced ec.c in linux-2.6.20-rc2 (see
attached dmesg-2.6.20-rc2.ec.txt) with the version from linux-2.6.19.1
and in a second step I also replaced i2c_ec.c and i2c_ec.h
(dmesg-2.6.20-rc2.i2c_ec.txt).
In both cases the only result I can see is the absence of the 'ACPI: EC:
evaluating' messages in the logs. The system is still rebooting instead
of doing a clean shutdown.
Regards,
Berthold
| Jan 7, 11:37 am 2007 |
| James Bottomley | Re: fuse, get_user_pages, flush_anon_page, aliasing cach ...
OK, so the bottom line we seem to have reached is that we can't manage
the user coherency in the DMA API. Does this also mean you can't do it
for non-DMA cases (kmap_atomic would seem to be a likely problem)? in
which case the only coherency kmap would control would be kernel
coherency?
James
-
| Jan 7, 9:09 am 2007 |
| Russell King | Re: fuse, get_user_pages, flush_anon_page, aliasing cach ...
It will only work if we can walk the VMA lists associated with the
page from IRQ context. By that I mean the address_space vma lists
If that's all that kmap could do, it would solve the issues with PIO,
but not things like fuse and the other users of get_user_pages() with
the current context. All those would remain potential sources of data
corruption.
My current attempt at solving this (following David's advice for anon
pages in flush_dcache_page()) is as follows (which involves ...
| Jan 7, 9:30 am 2007 |
| Ken Moffat | Re: x86 instability with 2.6.1{8,9}
I eventually found it ("Local APIC support on uniprocessors") in
menuconfig. In the meantime, I'd moved my 32-bit activity to a
different box (also athlon64, but a bit faster) and I had one oops
on that. At least, I assume it was an oops - the caps and scroll
LEDs flashed, but I couldn't do anything with MagicSysrq, not even
force a reboot. Ran diff on the various configs, changed to IO-APIC
plus an unrelated change to use libata for the cdrom. The faster box
_seems_ stable (used for a ...
| Jan 7, 7:26 am 2007 |
| previous day | today | next day |
|---|---|---|
| January 6, 2007 | January 7, 2007 | January 8, 2007 |
