Home » Mailing list archives » linux-kernel » 2007 » January » 4

Re: [2.6 patch] the scheduled find_trylock_page() removal

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Nick Piggin <nickpiggin@...>
To: Adrian Bunk <bunk@...>
Cc: Nick Piggin <npiggin@...>, <linux-kernel@...>, Linux Memory Management <linux-mm@...>
Subject: Re: [2.6 patch] the scheduled find_trylock_page() removal
Date: Thursday, January 4, 2007 - 12:53 am

Adrian Bunk wrote:

I guess I don't have a problem with this going into -mm and making its way
upstream sometime after the next release.

I would normally say it is OK to stay for another year because it is so
unintrusive, but I don't like the fact it doesn't give one an explicit ref
on the page -- it could be misused slightly more easily than find_lock_page
or find_get_page.

Anyone object? Otherwise:

Acked-by: Nick Piggin <npiggin@suse.de>

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[2.6 patch] the scheduled find_trylock_page() removal, Adrian Bunk, (Tue Jan 2, 5:57 pm)
Re: [2.6 patch] the scheduled find_trylock_page() removal, Nick Piggin, (Thu Jan 4, 12:53 am)
Re: [2.6 patch] the scheduled find_trylock_page() removal, Christoph Hellwig, (Thu Jan 4, 11:52 am)