Home » Mailing list archives » linux-kernel » 2007 » January » 31

[patch] update for (kbuild: correctly skip tilded backups in localversion files)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Oleg Verych <olecom@...>
To: LKML <linux-kernel@...>
Cc: Roman Zippel <zippel@...>, Bastian Blank <bastian@...>, Sam Ravnborg <sam@...>, Andrew Morton <akpm@...>
Subject: [patch] update for (kbuild: correctly skip tilded backups in localversion files)
Date: Wednesday, January 31, 2007 - 5:35 am

kbuild: finally correctly skip tilded backups in localversion files


Signed-off-by: Oleg Verych <olecom@flower.upol.cz>
---

 Final addition. Why i want to maximize usage of shell, rather, than
 `make'? Just because i think, it's more portable, clear way.

 Thanks.

--- linux-2.6.20-rc6/Makefile~4tilde-backups~	2007-01-31 07:46:18.696404500 +0100
+++ linux-2.6.20-rc6/Makefile	2007-01-31 10:19:18.406100500 +0100
@@ -788,10 +788,10 @@ $(vmlinux-dirs): prepare scripts
 # scripts/setlocalversion and add the appropriate checks as needed.
 
-localversion = $(objtree)/localversion	    $(srctree)/localversion
-ext_versions = $(objtree)/localversion[^~]* $(srctree)/localversion[!~]*
-versions = $(localversion) $(ext_versions)
-localver = $(subst $(space),, \
-	   $(shell cat /dev/null $(sort $(wildcard $(versions)))) \
-	   $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
+pattern = ".*/localversion[^~]*"
+string  = $(shell cat /dev/null \
+	   `find $(objtree) $(srctree) -maxdepth 1 -regex $(pattern) | sort`)
+
+localver = $(subst $(space),, $(string) \
+			      $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
 
 # If CONFIG_LOCALVERSION_AUTO is set scripts/setlocalversion is called
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] kbuild: correctly skip tilded backups in localversio..., Oleg Verych, (Wed Jan 31, 3:11 am)
Re: [patch] kbuild: correctly skip tilded backups in localve..., Andrew Morton, (Wed Jan 31, 7:56 pm)
Re: [patch] kbuild: correctly skip tilded backups in localve..., Oleg Verych, (Wed Jan 31, 10:37 pm)
Re: [patch] kbuild: correctly skip tilded backups in localve..., Andrew Morton, (Wed Jan 31, 10:43 pm)
Re: [patch] kbuild: correctly skip tilded backups in localve..., Oleg Verych, (Sun Feb 4, 10:01 am)
2.6.20-rc7 (Re: [patch] kbuild: correctly skip tilded backup..., Oleg Verych, (Thu Feb 1, 11:59 am)
[patch] update for (kbuild: correctly skip tilded backups in..., Oleg Verych, (Wed Jan 31, 5:35 am)