Home » Mailing list archives » linux-kernel » 2007 » January » 3

[2.6 patch] drivers/ata/: make 4 functions static

Previous thread: [2.6 patch] arch/i386/kernel/alternative.c should #include <asm/bugs.h> by Adrian Bunk on Wednesday, January 3, 2007 - 4:09 pm. (1 message)

Next thread: [2.6 patch] drivers/isdn/sc/: proper prototypes by Adrian Bunk on Wednesday, January 3, 2007 - 4:09 pm. (1 message)
[view original message]
From: Adrian Bunk
Subject: [2.6 patch] drivers/ata/: make 4 functions static
Date: Wednesday, January 3, 2007 - 4:09 pm

This patch makes the following needlessly global functions static:
- libata-core.c: ata_qc_complete_internal()
- libata-scsi.c: ata_scsi_qc_new()
- libata-scsi.c: ata_dump_status()
- libata-scsi.c: ata_to_sense_error()

Signed-off-by: Adrian Bunk &lt;bunk@stusta.de&gt;

---

 drivers/ata/libata-core.c |    2 +-
 drivers/ata/libata-scsi.c |   12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

--- linux-2.6.20-rc2-mm1/drivers/ata/libata-core.c.old	2007-01-03 23:06:04.000000000 +0100
+++ linux-2.6.20-rc2-mm1/drivers/ata/libata-core.c	2007-01-03 23:06:12.000000000 +0100
@@ -1160,7 +1160,7 @@
 		ata_port_printk(ap, KERN_DEBUG, &quot;%s: EXIT\n&quot;, __FUNCTION__);
 }
 
-void ata_qc_complete_internal(struct ata_queued_cmd *qc)
+static void ata_qc_complete_internal(struct ata_queued_cmd *qc)
 {
 	struct completion *waiting = qc-&gt;private_data;
 
--- linux-2.6.20-rc2-mm1/drivers/ata/libata-scsi.c.old	2007-01-03 23:06:35.000000000 +0100
+++ linux-2.6.20-rc2-mm1/drivers/ata/libata-scsi.c	2007-01-03 23:07:52.000000000 +0100
@@ -397,9 +397,9 @@
  *	RETURNS:
  *	Command allocated, or %NULL if none available.
  */
-struct ata_queued_cmd *ata_scsi_qc_new(struct ata_device *dev,
-				       struct scsi_cmnd *cmd,
-				       void (*done)(struct scsi_cmnd *))
+static struct ata_queued_cmd *ata_scsi_qc_new(struct ata_device *dev,
+					      struct scsi_cmnd *cmd,
+					      void (*done)(struct scsi_cmnd *))
 {
 	struct ata_queued_cmd *qc;
 
@@ -435,7 +435,7 @@
  *	LOCKING:
  *	inherited from caller
  */
-void ata_dump_status(unsigned id, struct ata_taskfile *tf)
+static void ata_dump_status(unsigned id, struct ata_taskfile *tf)
 {
 	u8 stat = tf-&gt;command, err = tf-&gt;feature;
 
@@ -610,8 +610,8 @@
  *	LOCKING:
  *	spin_lock_irqsave(host lock)
  */
-void ata_to_sense_error(unsigned id, u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc,
-			u8 *ascq, int verbose)
+static void ata_to_sense_error(unsigned id, u8 drv_stat, u8 drv_err, u8 *sk,
+			       u8 *asc, u8 *ascq, int ...
[ message continues ]
[view original message]
From: Jeff Garzik
Subject: Re: [2.6 patch] drivers/ata/: make 4 functions static
Date: Tuesday, January 9, 2007 - 3:42 am

applied


-


[ message continues ]
Previous thread: [2.6 patch] arch/i386/kernel/alternative.c should #include <asm/bugs.h> by Adrian Bunk on Wednesday, January 3, 2007 - 4:09 pm. (1 message)

Next thread: [2.6 patch] drivers/isdn/sc/: proper prototypes by Adrian Bunk on Wednesday, January 3, 2007 - 4:09 pm. (1 message)