Re: 2.6.20-rc6 pb_fnmode regression

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jiri Kosina
Date: Monday, January 29, 2007 - 2:55 am

On Sat, 27 Jan 2007, Soeren Sonnenburg wrote:


Hi Soeren,

I would probably not call this a regression, as this has been always 
there, as far as I can see.


Changing module parameter values through sysfs is not a very nice idea, 
because the change of the value is indeed silent - the driver is not 
notified in any way, that the value has changed. So the driver should take 
care of it by itself, which is not a nice thing.

The fact that during suspend/resume cycle it works is caused by the fact 
that all the hid devices are reinitialized, and therefore the 
hid->pb_fnmode is reassigned a new value, which has eventually been 
changed through sysfs.

I would rather be inclined to just make the 
/sys/module/usbhid/parameters/pb_fnmode read-only (which is what most of 
the drivers do anyway), to avoid this kind of confusion.

Do you have really any strong use-case, when setting the parameter during 
runtime would be much more useful than just do it during modprobe or 
rmmod/modprobe cycle?

Thanks,

-- 
Jiri Kosina
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.20-rc6 pb_fnmode regression, Soeren Sonnenburg, (Sat Jan 27, 6:29 am)
Re: 2.6.20-rc6 pb_fnmode regression, Jiri Kosina, (Mon Jan 29, 2:55 am)
Re: [linux-usb-devel] 2.6.20-rc6 pb_fnmode regression, Sergey Vlasov, (Mon Jan 29, 3:26 am)
Re: 2.6.20-rc6 pb_fnmode regression, Soeren Sonnenburg, (Mon Jan 29, 3:32 am)
Re: 2.6.20-rc6 pb_fnmode regression, Jiri Kosina, (Mon Jan 29, 3:40 am)
Re: 2.6.20-rc6 pb_fnmode regression, Jiri Kosina, (Mon Jan 29, 4:13 am)
Re: 2.6.20-rc6 pb_fnmode regression, Soeren Sonnenburg, (Mon Jan 29, 4:24 am)
Re: 2.6.20-rc6 pb_fnmode regression, Jiri Kosina, (Mon Jan 29, 4:45 am)
Re: 2.6.20-rc6 pb_fnmode regression, Soeren Sonnenburg, (Mon Jan 29, 8:12 am)