Home » Mailing list archives » linux-kernel » 2007 » January » 29

[PATCH] libata: fix translation for START STOP UNIT

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Robert Hancock
Subject: [PATCH] libata: fix translation for START STOP UNIT
Date: Sunday, January 28, 2007 - 6:29 pm

Applies to 2.6.20-rc6.

---

libata's SCSI translation for the SCSI START STOP UNIT command with the 
START bit clear (i.e. stopping the drive) appears to be incorrect. It 
sends an ATA STANDBY command with the time period set to 0, which the 
code comment says means "now", but the ATA standard says this means 
disable the standby timer, which effectively does nothing. Change this 
to issue a STANDBY IMMEDIATE command which will actually spin the drive 
down. The SAT (SCSI/ATA Translation) standard revision 9 concurs with 
this choice.

Signed-off-by: Robert Hancock <hancockr@shaw.ca>

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] libata: fix translation for START STOP UNIT, Robert Hancock, (Sun Jan 28, 6:29 pm)
Re: [PATCH] libata: fix translation for START STOP UNIT, Jeff Garzik, (Tue Jan 30, 7:24 am)
Re: [PATCH] libata: fix translation for START STOP UNIT, Robert Hancock, (Tue Jan 30, 7:36 am)
Re: [PATCH] libata: fix translation for START STOP UNIT, Jeff Garzik, (Tue Jan 30, 7:43 am)
Re: [PATCH] libata: fix translation for START STOP UNIT, Mark Lord, (Tue Jan 30, 5:38 pm)
Re: [PATCH] libata: fix translation for START STOP UNIT, Martin J. Bligh, (Wed Jan 31, 1:22 am)
Re: [PATCH] libata: fix translation for START STOP UNIT, Tejun Heo, (Wed Jan 31, 5:27 pm)
Re: [PATCH] libata: fix translation for START STOP UNIT, Mark Lord, (Wed Jan 31, 6:04 pm)