To: Christoph Hellwig <hch@...>, Peter Zijlstra <a.p.zijlstra@...>, <linux-kernel@...>, <linux-mm@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>
i'm sorry, but do you realize that files_lock is a global lock,
triggered by /every single/ file close?
" files_lock is a global lock and we touch it for every single
sys_close() system call that the system does. "
You really dont need to be a rocket scientist to see that it's a
globally bouncing cacheline that has a major effect on certain
VFS-intense workloads. Peter has worked hard to eliminate its effects
without having to couple this to an intrusive rewrite of the TTY layer.
( really, i personally find your dismissive style apalling and i think
such a reception of a nice patchset must be humiliating to Peter. I
certainly try to avoid to be involved with any VFS internals, due to
this unwelcoming tone of discussion. Had you been around when i
started contributing to the Linux kernel i'd probably not be hacking
the kernel today. You are a good hacker but the simultaneous
collateral damage you are causing is significantly reducing the net
benefit. )
( You are messing up the reply headers, everyone is listed in the 'To:'
field for any reply to your mail, instead of being added to the Cc:
list. )
Ingo
-
