'struct task_struct' has no member named 'mems_allowed' (was: Re: 2.6.20-rc4-mm1)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Sander
Date: Friday, January 12, 2007 - 3:52 am

Andrew Morton wrote (ao):



I had to revert this patch because of:

===
mm/mempolicy.c: In function 'sys_mbind':
mm/mempolicy.c:885: error: 'struct task_struct' has no member named 'mems_allowed'
make[1]: *** [mm/mempolicy.o] Error 1
make: *** [mm] Error 2
===

===
http://lkml.org/lkml/2007/1/9/375

Date	Tue, 9 Jan 2007 20:15:07 -0800 (PST)
From	Christoph Lameter <>
Subject	mbind: Restrict nodes to the currently allowed cpuset
Digg This

Currently one can specify an arbitrary node mask to mbind that includes nodes
not allowed. If that is done with an interleave policy then we will go around
all the nodes. Those outside of the currently allowed cpuset will be redirected
to the border nodes. Interleave will then create imbalances at the borders
of the cpuset.

This patch restricts the nodes to the currently allowed cpuset.

The RFC for this patch was discussed at
http://marc.theaimsgroup.com/?t=116793842100004&r=1&w=2
Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.19-mm1/mm/mempolicy.c
===================================================================
--- linux-2.6.19-mm1.orig/mm/mempolicy.c	2006-12-11 19:00:38.224610647 -0800
+++ linux-2.6.19-mm1/mm/mempolicy.c	2006-12-13 11:13:10.175294067 -0800
@@ -882,6 +882,7 @@ asmlinkage long sys_mbind(unsigned long 
 	int err;
 
 	err = get_nodes(&nodes, nmask, maxnode);
+	nodes_and(nodes, nodes, current->mems_allowed);
 	if (err)
 		return err;
 	return do_mbind(start, len, mode, &nodes, flags);
===

	With kind regards, Sander

-- 
Humilis IT Services and Solutions
http://www.humilis.net
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.20-rc4-mm1, Andrew Morton, (Thu Jan 11, 11:26 pm)
Early ACPI lockup (was Re: 2.6.20-rc4-mm1), Frederik Deweerdt, (Fri Jan 12, 3:20 am)
Re: 2.6.20-rc4-mm1, Mariusz Kozlowski, (Fri Jan 12, 3:25 am)
'struct task_struct' has no member named 'mems_allowed' ( ..., Sander, (Fri Jan 12, 3:52 am)
Re: spurious sparse warnings from linux/aio.h (was: 2.6.20 ..., Suparna Bhattacharya, (Fri Jan 12, 6:11 am)
Re: 2.6.20-rc4-mm1, Frederik Deweerdt, (Fri Jan 12, 6:18 am)
[-mm patch] remove tcp header from tcp_v4_check, Frederik Deweerdt, (Fri Jan 12, 6:33 am)
[-mm patch] remove tcp header from tcp_v4_check (take #2), Frederik Deweerdt, (Fri Jan 12, 6:55 am)
Re: 2.6.20-rc4-mm1, Mariusz Kozlowski, (Fri Jan 12, 8:13 am)
Re: 2.6.20-rc4-mm1, Michal Piotrowski, (Fri Jan 12, 8:16 am)
Re: 2.6.20-rc4-mm1, Mariusz Kozlowski, (Fri Jan 12, 9:12 am)
Re: spurious sparse warnings from linux/aio.h, Tilman Schmidt, (Fri Jan 12, 10:46 am)
Re: 'struct task_struct' has no member named 'mems_allowed ..., Christoph Lameter, (Fri Jan 12, 12:25 pm)
Re: 'struct task_struct' has no member named 'mems_allowed ..., Christoph Lameter, (Fri Jan 12, 2:28 pm)
Re: 'struct task_struct' has no member named 'mems_allowed ..., Christoph Lameter, (Fri Jan 12, 3:00 pm)
Re: Early ACPI lockup (was Re: 2.6.20-rc4-mm1), Len Brown, (Fri Jan 12, 3:53 pm)
Re: Early ACPI lockup (was Re: 2.6.20-rc4-mm1), Frederik Deweerdt, (Fri Jan 12, 4:10 pm)
Re: Early ACPI lockup (was Re: 2.6.20-rc4-mm1), Jiri Slaby, (Fri Jan 12, 4:36 pm)
Re: Early ACPI lockup (was Re: 2.6.20-rc4-mm1), Michal Piotrowski, (Fri Jan 12, 5:08 pm)
Re: Early ACPI lockup (was Re: 2.6.20-rc4-mm1), Jiri Slaby, (Fri Jan 12, 5:43 pm)
Re: Early ACPI lockup (was Re: 2.6.20-rc4-mm1), Frederik Deweerdt, (Fri Jan 12, 5:45 pm)
2.6.20-rc4-mm1: status of sn9c102_pas202bca?, Adrian Bunk, (Sat Jan 13, 12:27 am)
[-mm patch] make mmc_sysfs.c:mmc_key_type static, Adrian Bunk, (Sat Jan 13, 2:56 am)
[-mm patch] make gfs2_change_nlink_i() static, Adrian Bunk, (Sat Jan 13, 2:56 am)
Re: [-mm patch] make mmc_sysfs.c:mmc_key_type static, Pierre Ossman, (Sat Jan 13, 3:38 pm)
Re: 2.6.20-rc4-mm1, Thomas Gleixner, (Sun Jan 14, 2:48 am)
Re: 2.6.20-rc4-mm1, Thomas Gleixner, (Sun Jan 14, 3:46 am)
Re: 2.6.20-rc4-mm1, Thomas Gleixner, (Sun Jan 14, 7:40 am)
Re: 2.6.20-rc4-mm1, Jens Axboe, (Sun Jan 14, 3:05 pm)
Re: 2.6.20-rc4-mm1, Jens Axboe, (Sun Jan 14, 3:20 pm)
Re: 2.6.20-rc4-mm1, Jens Axboe, (Sun Jan 14, 3:30 pm)
Re: 2.6.20-rc4-mm1, Thomas Gleixner, (Sun Jan 14, 3:31 pm)
i810fb fails to load (was: 2.6.20-rc4-mm1), Tilman Schmidt, (Sun Jan 14, 4:52 pm)
Re: i810fb fails to load (was: 2.6.20-rc4-mm1), Andrew Morton, (Sun Jan 14, 5:22 pm)
Re: 2.6.20-rc4-mm1, Ingo Molnar, (Mon Jan 15, 1:22 am)
Re: [-mm patch] make gfs2_change_nlink_i() static, Steven Whitehouse, (Mon Jan 15, 3:31 am)
Re: 2.6.20-rc4-mm1: status of sn9c102_pas202bca?, Mauro Carvalho Chehab, (Mon Jan 15, 4:34 am)
Re: 2.6.20-rc4-mm1, Jens Axboe, (Mon Jan 15, 4:55 pm)
[-mm patch] fs/unionfs/: possible cleanups, Adrian Bunk, (Thu Jan 18, 2:55 pm)
[-mm patch] drivers/mtd/ubi/: possible cleanups, Adrian Bunk, (Fri Jan 19, 11:40 am)
Re: [-mm patch] fs/unionfs/: possible cleanups, Josef Sipek, (Sat Jan 20, 3:06 pm)
[-mm patch] oops in drivers/net/shaper.c, Frederik Deweerdt, (Sat Jan 20, 3:38 pm)
Re: [-mm patch] drivers/mtd/ubi/: possible cleanups, Artem Bityutskiy, (Sun Jan 21, 4:23 am)
Re: i810fb fails to load, Thomas Hellström, (Mon Jan 22, 6:42 am)
[-mm patch] drivers/firewire/: cleanups, Adrian Bunk, (Mon Jan 22, 11:17 am)
Re: i810fb fails to load, Tilman Schmidt, (Mon Jan 22, 11:30 am)
Re: [-mm patch] drivers/firewire/: cleanups, Kristian Høgsberg, (Mon Jan 22, 12:41 pm)
Re: [-mm patch] drivers/firewire/: cleanups, Adrian Bunk, (Mon Jan 22, 1:04 pm)
Re: [-mm patch] drivers/firewire/: cleanups, Kristian Høgsberg, (Mon Jan 22, 1:04 pm)
Re: [-mm patch] drivers/firewire/: cleanups, Stefan Richter, (Mon Jan 22, 1:44 pm)
Re: i810fb fails to load, Dave Airlie, (Mon Jan 22, 2:50 pm)
`make htmldocs` fails, Don Mullis, (Mon Jan 22, 11:02 pm)
Re: `make htmldocs` fails, Randy Dunlap, (Mon Jan 22, 11:22 pm)
Re: `make htmldocs` fails, Greg KH, (Mon Jan 22, 11:35 pm)
Re: `make htmldocs` fails -- 2.6.20-rc4-mm1, Don Mullis, (Mon Jan 22, 11:45 pm)
Re: i810fb fails to load, Thomas Hellström, (Tue Jan 23, 1:10 am)
Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error, Sergei Shtylyov, (Wed Jan 24, 7:12 am)
[-mm patch] MTD_CK804XROM must depend on PCI, Adrian Bunk, (Wed Jan 24, 3:36 pm)
Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error, Sergei Shtylyov, (Sat Feb 17, 12:26 pm)
Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error, Sergei Shtylyov, (Sat Feb 17, 12:32 pm)
Re: 2.6.20-rc4-mm1: PCI=n: drivers/net/3c59x.c compile error, Sergei Shtylyov, (Mon Feb 26, 6:22 am)
[PATCH] different values for OHCI_QUIRK_ZFMICRO, Randy Dunlap, (Tue May 8, 3:17 pm)
Re: [PATCH] different values for OHCI_QUIRK_ZFMICRO, David Brownell, (Tue May 8, 3:34 pm)