And - for an easier review - this is the diff between

radeonfb-atom-2.6.19-v6a.diff from Solomon and my patch (whitespace-only

changes not included).
---

 drivers/video/aty/radeon_base.c    |   26 +-

 drivers/video/aty/radeon_i2c.c     |    8

 drivers/video/aty/radeon_monitor.c |  347 ++++++++++++++++++-----------------

 3 files changed, 198 insertions(+), 183 deletions(-)
diff -wu linux-2.6/drivers/video/aty/radeon_base.c linux-2.6.git/drivers/video/aty/radeon_base.c

--- linux-2.6/drivers/video/aty/radeon_base.c	2007-01-01 22:31:14.000000000 +0100

+++ linux-2.6.git/drivers/video/aty/radeon_base.c	2007-01-01 19:38:54.000000000 +0100

@@ -287,7 +287,6 @@

 /*

  * globals

  */

-

 static char *mode_option;

 static char *monitor_layout;

 static int noaccel = 0;

@@ -663,21 +662,20 @@

 {

 #ifdef CONFIG_PPC_OF

 	  rinfo->is_atom_bios = 0;

-	  rinfo->get_pll_info = radeon_get_pll_info_openfirmware;

-	  rinfo->get_lvds_info = radeon_get_lvds_info_openfirmware;

+	rinfo->radeon_get_pll_info = radeon_get_pll_info_openfirmware;

+	rinfo->radeon_get_lvds_info = radeon_get_lvds_info_openfirmware;

 	  rinfo->radeon_get_tmds_info = NULL;

-	  rinfo->get_conn_info = radeon_get_conn_info_openfirmware;

+	rinfo->radeon_get_conn_info = radeon_get_conn_info_openfirmware;

 #else

 	  int tmp = rinfo->fp_bios_start + 4;

+	unsigned char sign[4];

+

+	sign[0] = BIOS_IN8(tmp);

+	sign[1] = BIOS_IN8(tmp + 1);

+	sign[2] = BIOS_IN8(tmp + 2);

+	sign[3] = BIOS_IN8(tmp + 3);
-	  if ((BIOS_IN8(tmp) == 'A' &&

-	       BIOS_IN8(tmp+1) == 'T' &&

-	       BIOS_IN8(tmp+2) == 'O' &&

-	       BIOS_IN8(tmp+3) == 'M') ||

-	      (BIOS_IN8(tmp) == 'M' &&

-	       BIOS_IN8(tmp+1) == 'O' &&

-	       BIOS_IN8(tmp+2) == 'T' &&

-	       BIOS_IN8(tmp+3) == 'A')) {

+	if (!memcmp(sign, "ATOM", 4) || !memcmp(sign, "MOTA", 4)) {

 		  rinfo->is_atom_bios = 1;
 		  rinfo->atom_data_start = BIOS_IN16(rinfo->fp_bios_start + 32)...
[ message continues ]

It looks good in this quick once-over..=20
Thanks for the rebase!
Acked-by:  Solomon Peachy <pizza@shaftnet.org>=20
 - Solomon

--=20

Solomon Peachy        		       pizza at shaftnet dot org	=20

Melbourne, FL                          ^^ (mail/jabber/gtalk) ^^

Quidquid latine dictum sit, altum viditur.          ICQ: 1318344

Ah good, what I was asking for :-) I'll try to get a new patch combining

everything out asap.
Ben.
-

Great, I didn't know you were working on this, I feared that the patch

had been forgotten.

I've a X850 (R480) here, feel free to send me any patch for testing.
Luca

-

Is there a list of cards this adds support for?  I'm waiting on support

for the X1600
	Gerhard
--

Gerhard Mack
gmack@innerfire.net
<>< As a computer I find your faith in technology amusing.

-

This is not supported, neither by radeonfb (patches or not) nor by

X.org. X1xxx cards have a new display engine and ATI refuses to provide

any specs for it.
Note: I wonder how much of that is related to M$ new Vista DRM that

basically forbids video or sound card vendors from providing specs or

doing open source or they get "revoked" and never get to see "HD"

content... 
Ben.
-

The patch is for the "old" generation, R400, R480 and their mobile

versions. Unfortunately the new engine used in X1xxx cards is very

different and no docs are available from ATI.
Luca

-