Home » Mailing list archives » linux-kernel » 1970 » January » 1

[patch 2/2] x86: watchdog - check for CPU is being supported

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Cyrill Gorcunov <gorcunov@...>
To: <tglx@...>, <mingo@...>, <hpa@...>, <macro@...>
Cc: <linux-kernel@...>, <gorcunov@...>
Subject: [patch 2/2] x86: watchdog - check for CPU is being supported
Date: Wednesday, December 31, 1969 - 8:00 pm

This patch does check if CPU is being recongnized
before call the unreserve(). Since enable_lapic_nmi_watchdog()
does have such a check the same is make sense here too
in a sake of code consistency (but nothing more).

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---

Index: linux-2.6.git/arch/x86/kernel/cpu/perfctr-watchdog.c
====================================================================
--- linux-2.6.git.orig/arch/x86/kernel/cpu/perfctr-watchdog.c	2008-06-03 20:48:26.000000000 +0400
+++ linux-2.6.git/arch/x86/kernel/cpu/perfctr-watchdog.c	2008-06-03 21:26:00.000000000 +0400
@@ -181,7 +181,9 @@ void disable_lapic_nmi_watchdog(void)
 		return;
 
 	on_each_cpu(stop_apic_nmi_watchdog, NULL, 0, 1);
-	wd_ops->unreserve();
+
+	if (wd_ops)
+		wd_ops->unreserve();
 
 	BUG_ON(atomic_read(&nmi_active) != 0);
 }

-- 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 2/2] x86: watchdog - check for CPU is being supported, Cyrill Gorcunov, (Wed Dec 31, 8:00 pm)
Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page..., Paul Mundt, (Mon Jan 1, 4:42 am)
Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page..., Randy Dunlap, (Mon Jan 1, 1:09 pm)