Re: RFC: SPI patch

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rodrigo Rubira Branco (BSDaemon)
Date: Tuesday, January 15, 2008 - 12:49 pm

Hello,

Sorry my delay in answer your mail, I'm really busy (like everyone I
think...).

The patch looks ok, but it's a good idea to not touch the ppc/ tree, just
the powerpc one...

Also, try to not use unsigned int and uint, choose one ;)

You missed an undef debug in your code.

Just as a hint, I have not really checked it, but careful with this kind of
operation:


Since resource.start can be bigger then resource.end, and because the type
are unsigned you get a big number instead of a small one, passing the checks
of -lt sizeof(struct...)

In your comments XXXX I agree with you in the returning of an -EINVAL error.

Please, split your patch in at least two, the first one directly related to
spi and the other one, not related but needed and send it as [PATCH 1/2] and
[PATCH 2/2] respectively...



cya, congrats and good luck with your first patch....


Rodrigo (BSDaemon).

--
http://www.kernelhacking.com/rodrigo

Kernel Hacking: If i really know, i can hack

GPG KeyID: 1FCEDEA1


--------- Mensagem Original --------
De: gary.jennejohn@freenet.de
Para: kernel-mentors@selenic.com <kernel-mentors@selenic.com>
Assunto: RFC: SPI patch
Data: 14/01/08 13:52

b/arch/powerpc/boot/dts/sequoia.dts
b/arch/ppc/platforms/4xx/ppc440epx.c
!defined(CONFIG_SPI_PPC4xx_MODULE)
!defined(CONFIG_SPI_PPC4xx_MODULE)
b/drivers/i2c/busses/i2c-ibm_of.c
it
published
*t)
spi_transfer *t)
cs-&gt;bpw);
%d)n&quot;, cdm,

________________________________________________
Message sent using UebiMiau 2.7.2

_______________________________________________
Kernel-mentors mailing list
Kernel-mentors@selenic.com
http://selenic.com/mailman/listinfo/kernel-mentors
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Equinox SST driver, Straub, Michael, (Mon Feb 6, 8:22 am)
Re: Equinox SST driver, Matt Mackall, (Mon Feb 6, 10:43 am)
Re: Equinox SST driver, Greg KH, (Mon Feb 6, 11:51 am)
[patch 00/19] chardev: pc8736x_gpio - intro, Jim Cromie, (Mon May 29, 11:12 pm)
[patch 07/19] chardev: pc8736x_gpio - , Jim Cromie, (Tue May 30, 12:15 am)
[patch 15/19] chardev: pc8736x_gpio - , Jim Cromie, (Tue May 30, 1:23 am)
Error in linux-kernel 2.6.16.28 on PCMCIA card removal, bhuvan.kumarmital, (Tue Sep 12, 3:11 am)
hello :), synapse, (Wed Nov 29, 5:30 am)
Re: hello :), Randy Dunlap, (Wed Nov 29, 11:06 pm)
Re: Patch on Comments, Dong Feng, (Sat Dec 23, 11:34 am)
Re: Patch on Comments, Arjan van de Ven, (Sat Dec 23, 12:44 pm)
Re: Patch on Comments, Dong Feng, (Sat Dec 23, 9:24 pm)
Re: Patch on Comments, Arjan van de Ven, (Sun Dec 24, 1:55 am)
Re: Patch on Comments, Dong Feng, (Sun Dec 24, 7:33 am)
Re: Patch on Comments, Arjan van de Ven, (Sun Dec 24, 7:57 am)
Re: Patch on Comments, Dong Feng, (Sun Dec 24, 8:55 am)
Re: Patch on Comments, Randy Dunlap, (Sun Dec 24, 10:37 am)
Re: Patch on Comments, Dong Feng, (Mon Dec 25, 6:19 am)
Why use volatile for socket state?, pradeep singh, (Mon May 14, 11:06 pm)
Re: Why use volatile for socket state?, Mulyadi Santosa, (Tue May 15, 1:25 am)
Help with patch formatting, Gilles Gigan, (Mon Oct 15, 7:10 pm)
Re: Help with patch formatting, Randy Dunlap, (Mon Oct 15, 7:42 pm)
Re: RFC: SPI patch, Rodrigo Rubira Branc ..., (Tue Jan 15, 12:49 pm)
Kernel Makefile, Alberich de megres, (Sun Sep 28, 1:49 pm)
Re: Kernel Makefile, Sam Ravnborg, (Sun Oct 26, 2:18 pm)
How to match hid device to our hid driver, guo jerry, (Thu May 28, 6:52 am)
Re: How to match hid device to our hid driver, Greg KH, (Thu May 28, 8:22 am)
Re: How to match hid device to our hid driver, guo jerry, (Thu May 28, 9:12 pm)
Re: How to match hid device to our hid driver, Greg KH, (Thu May 28, 11:08 pm)
Check out my photos on Facebook, Vivek J. Joshi, (Thu Jul 2, 3:03 am)
[No subject], Julien Maladrie, (Wed Sep 30, 12:22 pm)
Re: your mail, Greg KH, (Wed Sep 30, 12:37 pm)
LSM - Register my module, Julien Maladrie, (Thu Mar 4, 10:13 am)
Re: LSM - Register my module, Stephen Hemminger, (Thu Mar 4, 10:40 am)