Home » Mailing list archives » linux-kernel-mentors » 2006 » April » 14

Re: driver for review

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Peter Korsgaard
Subject: Re: driver for review
Date: Friday, April 14, 2006 - 11:07 am

>>>>> "Bahadir" == Bahadir Balban <bahadir.balban@gmail.com> writes:

Hi,

 Bahadir> I have attached an ethernet driver that I would like to submit for
 Bahadir> inclusion. It's the first that I will submit as such, so could you
 Bahadir> please comment on the code, in terms of coding style, or any
 Bahadir> conditions you think is unacceptable?

I would suggest you base your work on Dustin McIntire's driver instead
of the SMSC example.

http://thread.gmane.org/gmane.linux.ports.arm.kernel/23405/

Dustin: Any progress on pushing it to mainline?

-- 
Bye, Peter Korsgaard
_______________________________________________
Kernel-mentors mailing list
Kernel-mentors@selenic.com
http://selenic.com/mailman/listinfo/kernel-mentors
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Coding Style question - alignment of variables, Prarit Bhargava, (Thu Jan 26, 2:14 pm)
Re: Coding Style question - alignment of variables, Prarit Bhargava, (Thu Jan 26, 2:28 pm)
Re: Coding Style question - alignment of variables, Greg KH, (Thu Jan 26, 3:29 pm)
Re: Coding Style question - alignment of variables, Jim Cromie, (Thu Jan 26, 4:06 pm)
Re: Coding Style question - alignment of variables, Muli Ben-Yehuda, (Thu Jan 26, 4:11 pm)
Re: Coding Style question - alignment of variables, Greg KH, (Thu Jan 26, 4:22 pm)
driver for review, Bahadir Balban, (Thu Apr 13, 9:45 am)
Re: driver for review, Matt Mackall, (Thu Apr 13, 1:20 pm)
Re: driver for review, Peter Korsgaard, (Fri Apr 14, 11:07 am)
RE: driver for review, Dustin McIntire, (Mon Apr 17, 6:31 pm)
Re: driver for review, Bahadir Balban, (Tue Apr 18, 8:01 am)
Re: driver for review, Bahadir Balban, (Tue Apr 18, 8:17 am)
RE: driver for review, Dustin McIntire, (Tue Apr 18, 10:12 pm)
Re: driver for review, Peter Korsgaard, (Sun Apr 23, 11:54 am)
RE: driver for review, Dustin McIntire, (Sun Apr 23, 12:35 pm)
Diffenrence Completion and Semaphore, minchan Kim, (Thu May 18, 6:47 pm)
Re: Diffenrence Completion and Semaphore, Arjan van de Ven, (Thu May 18, 7:02 pm)
Re: Diffenrence Completion and Semaphore, Zach Brown, (Thu May 18, 7:32 pm)
Re: Diffenrence Completion and Semaphore, minchan Kim, (Thu May 18, 8:41 pm)
Re: Diffenrence Completion and Semaphore, Arjan van de Ven, (Fri May 19, 5:52 am)
Re: Diffenrence Completion and Semaphore, minchan Kim, (Fri May 19, 6:52 am)
Expertise required on building code for SMP, bhuvan.kumarmital, (Thu Jul 13, 12:42 am)
Re: Expertise required on building code for SMP, Arjan van de Ven, (Thu Jul 13, 12:45 am)
enthusiast looking for a mentor, Shobhit Jindal, (Thu Aug 24, 7:53 am)
Re: enthusiast looking for a mentor, Jim Cromie, (Thu Aug 24, 10:05 am)
Re: enthusiast looking for a mentor, Vivek Joshi, (Thu Aug 24, 11:13 pm)
Driver cfag12864b - Crystalfontz 128x64 2-color LCD Screen, Miguel Ojeda, (Sun Sep 10, 3:40 pm)
Re: Driver cfag12864b - Crystalfontz 128x64 2-color LCD Screen, Arjan van de Ven, (Mon Sep 11, 2:31 am)
Re: Driver cfag12864b - Crystalfontz 128x64 2-color LCD Screen, Miguel Ojeda, (Mon Sep 11, 3:45 pm)
Re: Driver cfag12864b - Crystalfontz 128x64 2-color LCD Screen, Greg KH, (Mon Sep 11, 8:39 pm)
Dynsched - dynamic cpu scheduler selection, Felix Obenhuber, (Sat Nov 18, 8:29 am)
Filesystem compression, kishore, (Sun Dec 10, 7:26 am)
Re: Filesystem compression, Phillip Lougher, (Sun Dec 10, 9:09 pm)
swap: which is the maximum size allowed?, Eriberto, (Sun Jan 28, 1:07 pm)
Re: swap: which is the maximum size allowed?, Tony Clayton, (Mon Jan 29, 12:24 am)
Re: swap: which is the maximum size allowed?, Arjan van de Ven, (Wed Jan 31, 3:38 am)
(no subject), chandrashekhar, (Wed Feb 21, 3:28 am)
Re: (no subject), Greg KH, (Wed Feb 21, 1:45 pm)
Re: (no subject), Randy Dunlap, (Wed Feb 21, 1:56 pm)
How can I join an active project?, Jiancong Xie, (Wed Apr 18, 1:40 am)
Re: How can I join an active project?, Felix Obenhuber, (Wed Apr 18, 9:41 am)
Re: How can I join an active project?, Arjan van de Ven, (Fri Apr 20, 11:20 am)
Re: [RFC]__sock_create() change, pradeep singh, (Mon May 14, 1:12 am)
Re: [RFC]__sock_create() change, Arjan van de Ven, (Mon May 14, 8:10 am)
Re: [RFC]__sock_create() change, Chris Wedgwood, (Mon May 14, 3:51 pm)
Re: [RFC]__sock_create() change, pradeep singh, (Mon May 14, 10:09 pm)
Hi - Need a mentor, Dheeraj Kandula, (Wed Jul 11, 2:22 pm)
Re: Hi - Need a mentor, Randy Dunlap, (Wed Jul 11, 6:55 pm)
[PATCH] char: Nano 7240 watchdog driver, Gilles GIGAN, (Fri Oct 5, 8:10 pm)
Re: [PATCH] char: Nano 7240 watchdog driver, Dave Jones, (Fri Oct 5, 9:02 pm)
Re: [PATCH] char: Nano 7240 watchdog driver, Randy Dunlap, (Fri Oct 5, 10:27 pm)
Re: [PATCH] char: Nano 7240 watchdog driver, Arjan van de Ven, (Sat Oct 6, 1:24 pm)
Build and test system for multiple kernels, François-Frédéric Ozog, (Thu Nov 22, 1:06 am)
Re: Build and test system for multiple kernels, Stjepan Gros, (Thu Nov 22, 6:41 am)
RFC: SPI patch, Gary Jennejohn, (Thu Jan 10, 6:46 am)
[resend and request for comments][PATCH 1/1] Removed depr ..., Jon Schindler, (Wed Feb 27, 9:16 pm)
jim.cromie has invited you to Spokeo, jim.cromie, (Tue Mar 25, 5:07 am)
HELP : taking up a kernel project, vibi sreenivasan, (Mon Jul 14, 6:16 am)
Re: HELP : taking up a kernel project, Ahmed S. Darwish, (Tue Jul 15, 5:32 am)
I need a mentor!, Joe moo, (Sun Aug 24, 2:18 pm)
Re: I need a mentor!, Ahmed S. Darwish, (Mon Aug 25, 6:09 am)
looking for mentor for creation of a new filesystem, santi, (Mon Nov 10, 10:39 am)
need help to merge (small) virtual scsi driver upstream., Henrik Stokseth, (Sun Jan 18, 9:38 pm)
Re: need help to merge (small) virtual scsi driver upstream., aboobacker vadakkumu ..., (Mon Jan 19, 2:52 pm)
Re: need help to merge (small) virtual scsi driver upstream., Matt Mackall, (Mon Jan 19, 3:07 pm)
Re: need help to merge (small) virtual scsi driver upstream., Henrik Stokseth, (Mon Jan 19, 3:17 pm)
Re: need help to merge (small) virtual scsi driver upstream., Henrik Stokseth, (Mon Jan 19, 3:33 pm)
Re: need help to merge (small) virtual scsi driver upstream., Matt Mackall, (Mon Jan 19, 3:37 pm)
Re: need help to merge (small) virtual scsi driver upstream., aboobacker vadakkumu ..., (Mon Jan 19, 4:04 pm)
Re: need help to merge (small) virtual scsi driver upstream., Matt Mackall, (Mon Jan 19, 4:21 pm)
Re: need help to merge (small) virtual scsi driver upstream., Greg KH, (Mon Jan 19, 5:10 pm)
Check out my photos on Facebook, Fawad Lateef, (Wed Mar 25, 5:40 am)
Debugging race conditions?, pradeep singh, (Tue May 26, 1:57 am)
Re: Debugging race conditions?, Mulyadi Santosa, (Tue May 26, 8:26 am)
X window don't read my input device automatically, guo jerry, (Fri Jun 19, 8:59 am)
Timeslice split in fork., Andy, (Thu Sep 17, 10:05 am)
Re: Timeslice split in fork., Mohammed Gamal, (Thu Sep 17, 10:09 am)
suggestion needed, Vengatesh Sundararajan, (Thu Feb 25, 12:05 am)
Re: suggestion needed, Luis R. Rodriguez, (Thu Feb 25, 1:29 am)
Re: suggestion needed, Vengatesh Sundararajan, (Thu Feb 25, 1:55 am)
Re: suggestion needed, Luis R. Rodriguez, (Thu Feb 25, 1:57 am)
Re: suggestion needed, Vengatesh Sundararajan, (Thu Feb 25, 2:05 am)
Re: suggestion needed, Luis R. Rodriguez, (Thu Feb 25, 2:14 am)
Re: suggestion needed, Vengatesh Sundararajan, (Thu Feb 25, 2:27 am)
Re: suggestion needed, Denis Kirjanov, (Thu Feb 25, 3:19 am)
RE: suggestion needed, Arun Dhananjayan (dh ..., (Thu Feb 25, 3:45 am)
Re: suggestion needed, Denis Kirjanov, (Thu Feb 25, 4:06 am)
Re: suggestion needed, Pulkit Goel, (Thu Feb 25, 8:33 am)
Re: suggestion needed, Luis R. Rodriguez, (Thu Feb 25, 10:50 am)
Re: suggestion needed, Denis Kirjanov, (Thu Feb 25, 10:52 am)
Re: suggestion needed, Luis R. Rodriguez, (Thu Feb 25, 10:52 am)
Re: suggestion needed, Luis R. Rodriguez, (Thu Feb 25, 10:59 am)