linux-kernel-janitors mailing list

From	Subject	Date
Sunil Mushran	Re: [patch -next] ocfs2/cluster: dereferencing before ch ... Acked-by: Sunil Mushran<sunil.mushran@oracle.com> -- [ message continues ]	Jan 3, 10:54 am 2011
Dan Carpenter	[patch -next] ocfs2/cluster: dereferencing before checki ... In the original code, we dereferenced "nst" before checking that it was non-NULL. I moved the check forward and pulled the code in an indent level. Signed-off-by: Dan Carpenter <error27@gmail.com> diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c index 61df89c..3a58359 100644 --- a/fs/ocfs2/cluster/netdebug.c +++ b/fs/ocfs2/cluster/netdebug.c @@ -133,36 +133,37 @@ static int nst_seq_show(struct seq_file seq, void v) spin_lock(&o2net_debug_lock); nst = ... [ message continues ]	Jan 2, 11:00 pm 2011
Dan Carpenter	[patch] [SCSI] scsi_dh: potential null dereference in sc ... We assumed "sdev" could be NULL ealier, so lets check it here as well. Signed-off-by: Dan Carpenter <error27@gmail.com> diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c index b837c5b..ff340e3 100644 --- a/drivers/scsi/device_handler/scsi_dh.c +++ b/drivers/scsi/device_handler/scsi_dh.c @@ -446,7 +446,7 @@ int scsi_dh_activate(struct request_queue q, activate_complete fn, void data) sdev->sdev_state == SDEV_CANCEL \|\| sdev->sdev_state == ... [ message continues ]	Jan 2, 10:48 pm 2011
Dan Carpenter	[patch 2/2] Staging: tm6000: silence Sparse warning "dub ... Bitwise and logical or are the equivalent here, so this doesn't affect runtime, but logical or was intended. The original code causes a warning in Sparse: "warning: dubious: !x \| !y" Signed-off-by: Dan Carpenter <error27@gmail.com> diff --git a/drivers/staging/tm6000/tm6000-input.c b/drivers/staging/tm6000/tm6000-input.c index aee5e85..dae2f1f 100644 --- a/drivers/staging/tm6000/tm6000-input.c +++ b/drivers/staging/tm6000/tm6000-input.c @@ -376,7 +376,7 @@ int tm6000_ir_init(struct ... [ message continues ]	Jan 2, 10:47 pm 2011
Dan Carpenter	[patch -next] ath5k: ath5k_eeprom_mode_from_channel() re ... ath5k_eeprom_mode_from_channel() returns -1 on error but we're storing the result in "ee_mode" which is an unsigned char. This breaks the error handling. This patch makes "ee_mode" an int. Signed-off-by: Dan Carpenter <error27@gmail.com> diff --git a/drivers/net/wireless/ath/ath5k/phy.c b/drivers/net/wireless/ath/ath5k/phy.c index 9306d5f..78c26fd 100644 --- a/drivers/net/wireless/ath/ath5k/phy.c +++ b/drivers/net/wireless/ath/ath5k/phy.c @@ -1916,7 +1916,8 @@ ... [ message continues ]	Jan 2, 10:46 pm 2011
Dan Carpenter	[patch 1/2] Staging: tm6000: check usb_alloc_urb() return usb_alloc_urb() can return NULL so check for that and return -ENOMEM if it happens. Signed-off-by: Dan Carpenter <error27@gmail.com> diff --git a/drivers/staging/tm6000/tm6000-input.c b/drivers/staging/tm6000/tm6000-input.c index 21e7da4..aee5e85 100644 --- a/drivers/staging/tm6000/tm6000-input.c +++ b/drivers/staging/tm6000/tm6000-input.c @@ -313,6 +313,8 @@ int tm6000_ir_int_start(struct tm6000_core *dev) return -ENODEV; ir->int_urb = usb_alloc_urb(0, GFP_KERNEL); + if ... [ message continues ]	Jan 2, 10:44 pm 2011
Dan Carpenter	Re: [PATCHv4 0/4] staging: keucr: Use memcmp() & memcpy( ... Looks good. v1 made me grumpy. v2 was ok. v4 is what all patches should look like. :) Acked-by: Dan Carpenter <error27@gmail.com> -- [ message continues ]	Jan 2, 10:34 pm 2011
Marcin Slusarz	Re: [PATCH 2/4] staging: keucr: Use memcpy() instead cus ... Now it looks good. Reviewed-by: Marcin Slusarz <marcin.slusarz@gmail.com> -- [ message continues ]	Jan 3, 9:11 am 2011
Dan Carpenter	Re: [patch -next] lockd: double unlock in next_host_state() No. for_each_host() is a nested for loop, so a break would only take you out of the inner most loop. regards, dan carpenter -- [ message continues ]	Jan 3, 9:34 am 2011
Chuck Lever	Re: [patch -next] lockd: double unlock in next_host_state() Would it also make sense to replace the "goto out;" with a "break;" ? -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- [ message continues ]	Jan 3, 8:59 am 2011

previous day	today	next day
January 2, 2011	January 3, 2011	January 4, 2011


linux-kernel:
Eberhard Moenkeberg	Re: OT: character encodings (was: Linux 2.6.20-rc4)
Andy Walls	Re: [PATCH 11/32] v4l/cx18: update workqueue usage
Thomas Gleixner	[patch -mm 19/28] x86_64: Use generic cmos update
Casey Schaufler	Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel
Pierre Ossman	Re: sdio: enhance IO_RW_EXTENDED support
git:
Mark Junker	git on MacOSX and files with decomposed utf-8 file names
Pat Thoyts	[PATCH] git-gui: use themed tk widgets with Tk 8.5
Michael Witten	Re: 'git gc --aggressive' effectively unusable
Petko Manolov	git and binary files
Dan Chokola	Re: how do you "force a pull"?
linux-netdev:
David Miller	Re: [PATCH 32/53] netns xfrm: finding policy in netns
Jean-Louis Dupond	Re: tg3 driver not advertising 1000mbit
Jan Engelhardt	[PATCH 1/3] net: tcp: make hybla selectable as default congestion module
Matt Mackall	Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Eric Dumazet	Re: HTB accuracy on 10GbE
freebsd-chat:
Kevin Kinsey	Re: I can't make world without the "games" group?
Dan Langille	Re: spotted in the wild...
Dag-Erling Smørgrav	Re: which port for this job?
Mark Picone	Re: Hard drive data recovery shops for FreeBSD partitions?
Zane C.B.	Re: ZFS ATA vs. ZFS CAM ATA performance on 8.1
dragonflybsd-commit:
Joerg Sonnenberger	cvs commit: src/lib/libc/stdlib getopt_long.c
Sepherosa Ziehau	cvs commit: src/sys/dev/netif/aue if_aue.c
Jeroen Ruigrok/asmodai	cvs commit: dfports/devel/imake-6 Makefile distinfo
Sascha Wildner	Re: cvs commit: src/test/test README
Simon 'corecode' Schubert	Re: cvs commit: src/bin/hostname hostname.1 src/bin/domainname domainname....