Home » Mailing list archives » linux-kernel-janitors » 2011 » January » 3

[patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dan Carpenter
Subject: [patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate()
Date: Sunday, January 2, 2011 - 10:48 pm

We assumed "sdev" could be NULL ealier, so lets check it here as well.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c
index b837c5b..ff340e3 100644
--- a/drivers/scsi/device_handler/scsi_dh.c
+++ b/drivers/scsi/device_handler/scsi_dh.c
@@ -446,7 +446,7 @@ int scsi_dh_activate(struct request_queue *q, activate_complete fn, void *data)
 	    sdev->sdev_state == SDEV_CANCEL ||
 	    sdev->sdev_state == SDEV_DEL)
 		err = SCSI_DH_NOSYS;
-	if (sdev->sdev_state == SDEV_OFFLINE)
+	if (sdev && sdev->sdev_state == SDEV_OFFLINE)
 		err = SCSI_DH_DEV_OFFLINED;
 	spin_unlock_irqrestore(q->queue_lock, flags);
 
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] [SCSI] scsi_dh: potential null dereference in scsi ..., Dan Carpenter, (Sun Jan 2, 10:48 pm)
RE: [patch] [SCSI] scsi_dh: potential null dereference in ..., Moger, Babu, (Tue Jan 4, 9:13 am)
RE: [patch] [SCSI] scsi_dh: potential null dereference in ..., James Bottomley, (Tue Jan 4, 9:24 am)
RE: [patch] [SCSI] scsi_dh: potential null dereference in ..., Moger, Babu, (Tue Jan 4, 12:50 pm)
RE: [patch] [SCSI] scsi_dh: potential null dereference in ..., James Bottomley, (Tue Jan 4, 12:58 pm)