Re: CONFIG_VFAT_FS_DUALNAMES regressions

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jan Engelhardt <jengelh@...>
Cc: OGAWA Hirofumi <hirofumi@...>, Theodore Tso <tytso@...>, Alan Cox <alan@...>, Rusty Russell <rusty@...>, Pavel Machek <pavel@...>, <john.lanza@...>, Linux Kernel Mailing List <linux-kernel@...>, <linux-fsdevel@...>, Dave Kleikamp <shaggy@...>, <corbet@...>, <jcm@...>
Date: Friday, July 3, 2009 - 8:24 am

Hi Jan,

> Right. That in itself is fine, but I'd still like to have readdir
> return lowercase names here then.

you are in luck!

It just so happens that this is what happens when we use the patch
that Hirofumi and I just agreed on (ie. the case handling part of my
patch from May, combined with the current patch).

I include it below. Can you please test it? It should be applied on
top of the previous patch. Note that you will not need to specify
shortname=winnt. In fact, if you don't specify any special options and
let the kernel default then you will get the behaviour you just
described.

Hirofumi-san, can you have a look at this too and see if it is how you
want to handle it? I built the patch against your fatfs-2.6 tree.

Cheers, Tridge

From 244a8ebe72288a261e68b5aea04a86793a2f11f4 Mon Sep 17 00:00:00 2001
From: Andrew Tridgell
Date: Fri, 3 Jul 2009 22:15:02 +1000
Subject: [PATCH] Force case handling when dualnames are disabled for greater compatibility

When CONFIG_VFAT_FS_DUALNAMES is not set and a 8.3 name is created,
force the use of the shortname=winnt option to allow for lowercase or
uppercase prefix and extensions without using a long name.

Signed-off-by: Andrew Tridgell
---
fs/fat/namei_vfat.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
index 894f44d..9555a46 100644
--- a/fs/fat/namei_vfat.c
+++ b/fs/fat/namei_vfat.c
@@ -317,6 +317,11 @@ static int vfat_create_shortname(struct inode *dir, struct nls_table *nls,
int sz = 0, extlen, baselen, i, numtail_baselen, numtail2_baselen;
int is_shortname;
struct shortname_info base_info, ext_info;
+ unsigned opts_shortname = opts->shortname;
+
+#ifndef CONFIG_VFAT_FS_DUALNAMES
+ opts_shortname = VFAT_SFN_CREATE_WINNT;
+#endif

is_shortname = 1;
INIT_SHORTNAME_INFO(&base_info);
@@ -429,9 +434,9 @@ static int vfat_create_shortname(struct inode *dir, struct nls_table *nls,
if (vfat_find_form(dir, name_res) == 0)
return -EEXIST;

- if (opts->shortname & VFAT_SFN_CREATE_WIN95) {
+ if (opts_shortname & VFAT_SFN_CREATE_WIN95) {
return (base_info.upper && ext_info.upper);
- } else if (opts->shortname & VFAT_SFN_CREATE_WINNT) {
+ } else if (opts_shortname & VFAT_SFN_CREATE_WINNT) {
if ((base_info.upper || base_info.lower) &&
(ext_info.upper || ext_info.lower)) {
if (!base_info.upper && base_info.lower)
--
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Pavel Machek, (Tue Jun 30, 2:31 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Pavel Machek, (Thu Jul 2, 6:00 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Pavel Machek, (Thu Jul 2, 6:41 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Boaz Harrosh, (Wed Jul 1, 7:48 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, James Bottomley, (Wed Jul 1, 11:44 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Jamie Lokier, (Mon Jul 6, 4:41 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Boaz Harrosh, (Tue Jul 7, 6:02 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Jamie Lokier, (Tue Jul 7, 7:25 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Boaz Harrosh, (Tue Jul 7, 7:48 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Pavel Machek, (Thu Jul 2, 6:03 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Alan Cox, (Wed Jul 1, 10:41 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, James Bottomley, (Thu Jul 2, 10:56 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, James Bottomley, (Thu Jul 2, 5:25 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Theodore Tso, (Thu Jul 2, 11:27 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Alan Cox, (Thu Jul 2, 12:56 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, OGAWA Hirofumi, (Thu Jul 2, 10:50 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Rusty Russell, (Wed Jul 1, 6:49 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Pavel Machek, (Thu Jul 2, 5:46 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Rusty Russell, (Thu Jul 2, 7:55 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Pavel Machek, (Thu Jul 2, 6:33 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Pavel Machek, (Thu Jul 2, 6:44 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Rusty Russell, (Thu Jul 2, 8:03 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Pavel Machek, (Wed Jul 8, 5:21 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, H. Peter Anvin, (Wed Jul 8, 12:46 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Paul E. McKenney, (Wed Jul 8, 10:25 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Paul E. McKenney, (Wed Jul 8, 6:14 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Paul E. McKenney, (Wed Jul 8, 7:59 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Rusty Russell, (Wed Jul 1, 8:34 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Theodore Tso, (Wed Jul 1, 10:05 am)
Re: CONFIG_VFAT_FS_DUALNAMES regression, Jan Engelhardt, (Thu Jul 2, 7:17 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Thu Jul 2, 7:46 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, OGAWA Hirofumi, (Thu Jul 2, 8:58 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Thu Jul 2, 9:50 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Thu Jul 2, 10:09 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Fri Jul 3, 5:40 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, , (Fri Jul 3, 8:24 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jamie Lokier, (Mon Jul 6, 4:04 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jamie Lokier, (Fri Jul 10, 5:44 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Mon Jul 6, 7:40 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Pavel Machek, (Tue Jul 7, 3:51 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Pavel Machek, (Fri Jul 10, 3:35 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Wed Jul 8, 6:27 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Thu Jul 9, 4:24 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Mon Jul 6, 2:55 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Mon Jul 6, 4:36 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Martin Steigerwald, (Tue Jul 7, 5:56 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Martin Steigerwald, (Wed Jul 8, 7:39 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jamie Lokier, (Fri Jul 10, 5:28 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jamie Lokier, (Fri Jul 10, 10:03 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Pavel Machek, (Fri Jul 10, 3:36 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jamie Lokier, (Fri Jul 10, 5:12 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Martin Steigerwald, (Thu Jul 9, 3:47 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Martin Steigerwald, (Thu Jul 9, 9:34 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jamie Lokier, (Wed Jul 8, 9:53 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jeremy Allison, (Wed Jul 8, 1:12 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Wed Jul 8, 6:04 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, James Bottomley, (Wed Jul 8, 11:27 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Wed Jul 8, 11:37 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, James Bottomley, (Wed Jul 8, 12:06 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Wed Jul 8, 12:18 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, OGAWA Hirofumi, (Thu Jul 9, 12:53 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, OGAWA Hirofumi, (Sun Jul 12, 3:39 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Pavel Machek, (Tue Jul 21, 6:31 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Pavel Machek, (Sat Aug 8, 8:19 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Boaz Harrosh, (Tue Jul 21, 5:16 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, John Lanza, (Tue Jul 21, 11:06 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, John Lanza, (Tue Jul 21, 3:38 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Tue Jul 21, 6:44 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Pavel Machek, (Tue Jul 21, 6:31 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Pavel Machek, (Tue Jul 21, 5:37 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, John Lanza, (Tue Jul 21, 11:08 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, John Lanza, (Tue Jul 21, 3:36 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Thu Jul 9, 5:53 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Thu Jul 9, 5:51 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, OGAWA Hirofumi, (Thu Jul 9, 1:27 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Pavel Machek, (Thu Jul 9, 3:21 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, David Newall, (Thu Jul 9, 3:34 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Wed Jul 8, 8:23 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Wed Jul 8, 8:02 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Wed Jul 8, 9:25 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Thu Jul 9, 5:42 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, James Bottomley, (Thu Jul 9, 9:59 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Thu Jul 9, 10:10 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Theodore Tso, (Thu Jul 9, 11:25 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Thu Jul 9, 8:09 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Christoph Hellwig, (Thu Jul 9, 1:15 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, David Newall, (Thu Jul 9, 4:57 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Martin Steigerwald, (Thu Jul 9, 6:23 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, David Newall, (Thu Jul 9, 9:45 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Martin Steigerwald, (Fri Jul 10, 2:49 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, David Newall, (Sun Jul 12, 4:52 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jonathan Corbet, (Fri Jul 10, 3:31 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Alan Cox, (Fri Jul 10, 5:14 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Bartlomiej Zolnierkiewicz..., (Fri Jul 10, 4:40 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jörn, (Sun Jul 12, 7:21 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Sun Jul 12, 7:27 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jamie Lokier, (Mon Jul 13, 6:20 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Mon Jul 13, 6:32 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Martin Steigerwald, (Tue Jul 7, 6:09 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jamie Lokier, (Mon Jul 6, 4:58 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Mon Jul 6, 5:08 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jamie Lokier, (Mon Jul 6, 6:24 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Tue Jul 7, 5:36 am)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jan Engelhardt, (Mon Jul 6, 4:42 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, David Newall, (Mon Jul 6, 12:17 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, Jamie Lokier, (Mon Jul 6, 3:33 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, OGAWA Hirofumi, (Fri Jul 3, 11:09 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regressions, OGAWA Hirofumi, (Fri Jul 3, 2:46 am)
Re: CONFIG_VFAT_FS_DUALNAMES regression, Jan Engelhardt, (Thu Jul 2, 8:11 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regression, Jan Engelhardt, (Thu Jul 2, 9:10 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regression, Jan Engelhardt, (Thu Jul 2, 9:58 pm)
Re: CONFIG_VFAT_FS_DUALNAMES regression, Jamie Lokier, (Fri Jul 10, 8:14 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Stefan Richter, (Wed Jul 1, 12:18 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Alan Cox, (Wed Jul 1, 10:17 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Jamie Lokier, (Mon Jul 6, 3:57 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Pavel Machek, (Thu Jul 2, 5:49 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Eric W. Biederman, (Sat Jun 27, 9:54 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Eric W. Biederman, (Sun Jun 28, 12:10 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, OGAWA Hirofumi, (Sun Jun 28, 2:25 am)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, OGAWA Hirofumi, (Mon Jun 29, 7:36 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, OGAWA Hirofumi, (Mon Jun 29, 8:55 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Eric W. Biederman, (Sun Jun 28, 3:51 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, James Bottomley, (Sun Jun 28, 4:13 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Eric W. Biederman, (Sun Jun 28, 4:45 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, James Bottomley, (Sun Jun 28, 5:45 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Jan Engelhardt, (Sat Jun 27, 1:21 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Jamie Lokier, (Sun Jun 28, 5:57 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Jan Engelhardt, (Sun Jun 28, 6:02 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Jamie Lokier, (Sun Jun 28, 6:05 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, OGAWA Hirofumi, (Fri Jun 26, 9:56 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, H. Peter Anvin, (Fri Jun 26, 5:40 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, OGAWA Hirofumi, (Fri Jun 26, 9:48 pm)
Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option, Jan Engelhardt, (Sat Jun 27, 1:26 pm)