Home » Mailing list archives » linux-fsdevel » 2008 » July » 10

[PATCH] partitions: Prefer strlcpy() over snprintf()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jean Delvare <khali@...>
To: Andries Brouwer <aeb@...>
Cc: <linux-fsdevel@...>
Subject: [PATCH] partitions: Prefer strlcpy() over snprintf()
Date: Thursday, July 10, 2008 - 7:30 am

Subject: partitions: Prefer strlcpy() over snprintf()

strlcpy is faster than snprintf when you don't use the returned value.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Andries Brouwer <aeb@cwi.nl>
---
This patch was already sent on:
 * 2008-05-09

 fs/partitions/check.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.26-rc1.orig/fs/partitions/check.c	2008-05-09 17:35:37.000000000 +0200
+++ linux-2.6.26-rc1/fs/partitions/check.c	2008-05-09 17:39:13.000000000 +0200
@@ -123,7 +123,7 @@ static int (*check_part[])(struct parsed
 char *disk_name(struct gendisk *hd, int part, char *buf)
 {
 	if (!part)
-		snprintf(buf, BDEVNAME_SIZE, "%s", hd->disk_name);
+		strlcpy(buf, hd->disk_name, BDEVNAME_SIZE);
 	else if (isdigit(hd->disk_name[strlen(hd->disk_name)-1]))
 		snprintf(buf, BDEVNAME_SIZE, "%sp%d", hd->disk_name, part);
 	else


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] partitions: Prefer strlcpy() over snprintf(), Jean Delvare, (Thu Jul 10, 7:30 am)
Re: [PATCH] partitions: Prefer strlcpy() over snprintf(), Andries E. Brouwer, (Thu Jul 10, 8:28 am)
Re: [PATCH] partitions: Prefer strlcpy() over snprintf(), Jean Delvare, (Thu Jul 10, 9:03 am)