login
Header Space

 
 

Re: nfs: infinite loop in fcntl(F_SETLKW)

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <bfields@...>
Cc: <trond.myklebust@...>, <miklos@...>, <eshel@...>, <neilb@...>, <akpm@...>, <linux-nfs@...>, <linux-kernel@...>, <linux-fsdevel@...>
Date: Sunday, April 13, 2008 - 4:28 am

> Apologies, that was indeed a behavioral change introduced in a commit

Another complaint about this series: using EINPROGRESS to signal
asynchronous locking looks really fishy.  How does the filesystem
know, that the caller wants to do async locking?  How do we make sure,
that the filesystem (like fuse or 9p, which "blindly" return the error
from the server) doesn't return EINPROGRESS even when it's _not_ doing
an asynchronous lock?

I think it would have been much cleaner to have a completely separate
interface for async locking, instead of trying to cram that into
f_op->lock().

Would that be possible to fix now?  Or at least make EINPROGRESS a
kernel-internal error value (>512), to make it that it has a special
meaning for the _kernel only_?

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
nfs: infinite loop in fcntl(F_SETLKW), Miklos Szeredi, (Thu Apr 10, 3:51 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), Trond Myklebust, (Thu Apr 10, 5:02 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), Trond Myklebust, (Thu Apr 10, 5:07 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), Trond Myklebust, (Thu Apr 10, 5:20 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), J. Bruce Fields, (Thu Apr 10, 5:54 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), Miklos Szeredi, (Sun Apr 13, 4:28 am)
Re: nfs: infinite loop in fcntl(F_SETLKW), J. Bruce Fields, (Mon Apr 14, 1:19 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), Miklos Szeredi, (Mon Apr 14, 5:15 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), J. Bruce Fields, (Tue Apr 15, 2:58 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), Miklos Szeredi, (Wed Apr 16, 12:28 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), J. Bruce Fields, (Thu Apr 17, 6:26 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), Miklos Szeredi, (Fri Apr 18, 8:47 am)
Re: nfs: infinite loop in fcntl(F_SETLKW), Miklos Szeredi, (Fri Apr 11, 3:12 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), J. Bruce Fields, (Sat Apr 12, 8:08 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), Miklos Szeredi, (Sun Apr 13, 4:13 am)
Re: nfs: infinite loop in fcntl(F_SETLKW), J. Bruce Fields, (Mon Apr 14, 1:07 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), J. Bruce Fields, (Fri Apr 11, 3:19 pm)
Re: nfs: infinite loop in fcntl(F_SETLKW), Miklos Szeredi, (Fri Apr 11, 3:22 pm)
speck-geostationary