This is no longer needed, as we don't have upper and lower pages. Plus this
was racy, requiring the unexported inode_lock variable.
Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
fs/unionfs/dentry.c | 11 -----------
fs/unionfs/super.c | 8 +++++---
2 files changed, 5 insertions(+), 14 deletions(-)
diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c
index 5e498c2..ee0da4f 100644
--- a/fs/unionfs/dentry.c
+++ b/fs/unionfs/dentry.c
@@ -273,17 +273,6 @@ static inline void purge_inode_data(struct inode *inode)
*/
}
-void purge_sb_data(struct super_block *sb)
-{
- struct inode *inode;
-
- list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
- if (inode->i_state & (I_FREEING|I_WILL_FREE))
- continue;
- purge_inode_data(inode);
- }
-}
-
/*
* Revalidate a single file/symlink/special dentry. Assume that info nodes
* of the dentry and its parent are locked. Assume that parent(s) are all
diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c
index 4cddc83..82b4045 100644
--- a/fs/unionfs/super.c
+++ b/fs/unionfs/super.c
@@ -747,10 +747,12 @@ out_no_change:
* function). This revalidation will happen lazily and
* incrementally, as users perform operations on cached inodes. We
* would like to encourage this revalidation to happen sooner if
- * possible, so we try to invalidate as many other pages in our
- * superblock as we can.
+ * possible, so we like to try to invalidate as many other pages in
+ * our superblock as we can. We used to call drop_pagecache_sb() or
+ * a variant thereof, but either method was racy (drop_caches alone
+ * is known to be racy). So now we let the revalidation happen on a
+ * per file basis in ->d_revalidate.
*/
- purge_sb_data(sb);
/* grab new lower super references; release old ones */
for (i = 0; i < new_branches; i++)
--
1.5.2.2
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
| holzheu | [RFC/PATCH] Documentation of kernel messages |
| Rafael J. Wysocki | [Bug #11865] WOL for E100 Doesn't Work Anymore |
| Lai Jiangshan | [PATCH 1/7] mm: introduce simple_malloc()/simple_free() |
| Ingo Molnar | [git pull] scheduler updates |
git: | |
| Tomash Brechko | Re: GIT vs Other: Need argument |
| freku045 | [PATCH 4/25] git-cherry: Print the usage message if we get an unknown option. |
| Adam Piątyszek | [PATCH] git-send-email.perl: check for lines longer than 998 characters |
| Elijah Newren | Trying to use git-filter-branch to compress history by removing large, obsolete bi... |
| GVG GVG | ssh_exchange_identification: Connection closed by remote host |
| Richard Stallman | Re: Real men don't attack straw men |
| Richard Stallman | Real men don't attack straw men |
| Julien TOUCHE | setting up ssh tunnel/vpn |
| Jim Winstead Jr. | Re: Root Disk/Book Disk Compatibility |
| Robert Blum | Re:help again and again |
| Drew Eckhardt | bootsector.S @X patch |
| Qi Xia | Re: inode limit ? |
| mmap write protection fail over coldfire 5475 | 35 minutes ago | Linux kernel |
| Kernel Panic when schedule is called | 4 hours ago | Linux kernel |
| VPN's on NetBSD | 17 hours ago | NetBSD |
| Why does uClinux 2.6.18 bootup block SuperIO UART IRQs that BIOS configured | 18 hours ago | Linux kernel |
| USB statistics | 20 hours ago | Linux kernel |
| Block Sub System query | 1 day ago | Linux kernel |
| kernel module to intercept socket creation | 1 day ago | Linux kernel |
| Image size changing during each build | 1 day ago | Linux kernel |
| Soft lock bug | 1 day ago | Linux kernel |
| sysctl - dynamic registration problem | 1 day ago | Linux kernel |
