On Wed, Feb 06, 2008 at 09:58:02PM +0100, Rasmus Rohde wrote:
quoted text
> > > +	dotdot.d_name.name = "..";
> > > +	dotdot.d_name.len = 2;
> > > +
> > > +	lock_kernel();
> > > +	if (!udf_find_entry(child->d_inode, &dotdot, &fibh, &cfi))
> > > +		goto out_unlock;
> >   Have you ever tried this? I think this could never work. UDF doesn't have
> > entry named .. in a directory. You have to search for an entry that has
> > in fileCharacteristics set bit FID_FILE_CHAR_PARENT. Maybe you could
> > hack-around udf_find_entry() to recognize .. dentry and do the search
> > accordingly.
> Probably not. I just tested that I could read files and navigate the
> directory structure. However looking into UDF I think you are right - it
> will fail.
> I have extended udf_find_entry() to do an explicit check based on
> fileCharacteristics as you propose.
> How do I actually test this case?
> 
> >   Otherwise the patch looks fine. But please rediff the patch against
> > Andrew's development tree (or -mm) because there are some cleanups there...
> > Thanks.
> Certainly there are. New patch against 2.6.24-mm1:

There's still a few trivial warnings from scripts/checkpatch.pl that
should be fixed up:

ERROR: trailing whitespace
#88: FILE: fs/udf/namei.c:1323:
+^I$

ERROR: trailing whitespace
#92: FILE: fs/udf/namei.c:1327:
+^I^I$

ERROR: trailing whitespace
#185: FILE: fs/udf/namei.c:1420:
+^I^Ifid->udf.parent_partref = location.partitionReferenceNum;^I$

WARNING: externs should be avoided in .c files
#212: FILE: fs/udf/super.c:79:
+extern struct export_operations udf_export_ops;

total: 3 errors, 1 warnings, 218 lines checked

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html