Re: [NFS] [PATCH] Make UDF exportable

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Rasmus Rohde <rohde@...>
Cc: Christoph Hellwig <hch@...>, <nfs@...>, <linux-fsdevel@...>
Date: Wednesday, February 6, 2008 - 2:08 pm

Hi,

  Interesting character before Signed-off-by :).

  Have you ever tried this? I think this could never work. UDF doesn't have
entry named .. in a directory. You have to search for an entry that has
in fileCharacteristics set bit FID_FILE_CHAR_PARENT. Maybe you could
hack-around udf_find_entry() to recognize .. dentry and do the search
accordingly.

  Otherwise the patch looks fine. But please rediff the patch against
Andrew's development tree (or -mm) because there are some cleanups there...
Thanks.

									Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [NFS] [PATCH] Make UDF exportable, Christoph Hellwig, (Tue Feb 5, 6:29 am)
Re: [NFS] [PATCH] Make UDF exportable, Rasmus Rohde, (Tue Feb 5, 1:44 pm)
Re: [NFS] [PATCH] Make UDF exportable, Jan Kara, (Wed Feb 6, 2:08 pm)
Re: [NFS] [PATCH] Make UDF exportable, Rasmus Rohde, (Wed Feb 6, 4:58 pm)
Re: [NFS] [PATCH] Make UDF exportable, Christoph Hellwig, (Thu Feb 7, 1:45 am)
Re: [NFS] [PATCH] Make UDF exportable, Rasmus Rohde, (Thu Feb 7, 3:06 am)
Re: [NFS] [PATCH] Make UDF exportable, Jan Kara, (Thu Feb 7, 10:48 am)
Re: [NFS] [PATCH] Make UDF exportable, Rasmus Rohde, (Thu Feb 7, 11:02 am)
Re: [NFS] [PATCH] Make UDF exportable, Christoph Hellwig, (Tue Apr 29, 10:33 am)
Re: [NFS] [PATCH] Make UDF exportable, Jan Kara, (Wed Apr 30, 11:41 am)
Re: [NFS] [PATCH] Make UDF exportable, Jan Kara, (Thu Feb 7, 11:13 am)
Re: [NFS] [PATCH] Make UDF exportable, Christoph Hellwig, (Wed Feb 6, 11:37 pm)
Re: [NFS] [PATCH] Make UDF exportable, Rasmus Rohde, (Tue Feb 5, 3:26 pm)