On Feb 28, 2008  17:10 -0700, Chris Kottaridis wrote:
quoted text
> That's all I currently have of the log, I'll see if I can get more of
> it.
> 
> I was pointed to this diff that has a "goto out" added if we hit this
> scenario:
> 
> feda58d37ae0efe22e711a74e26fb541d4eb1baa
>  fs/ext3/balloc.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
> index a26e683..d2dface 100644
> --- a/fs/ext3/balloc.c
> +++ b/fs/ext3/balloc.c
> @@ -530,11 +530,13 @@ do_more:
>  	    in_range (block, le32_to_cpu(desc->bg_inode_table),
>  		      sbi->s_itb_per_group) ||
>  	    in_range (block + count - 1, le32_to_cpu(desc->bg_inode_table),
> -		      sbi->s_itb_per_group))
> +		      sbi->s_itb_per_group)) {
>  		ext3_error (sb, "ext3_free_blocks",
>  			    "Freeing blocks in system zones - "
>  			    "Block = "E3FSBLK", count = %lu",
>  			    block, count);
> +		goto error_return;
> +	}
>  
>  	/*
>  	 * We are about to start releasing blocks in the bitmap,
> @@ -1637,11 +1639,13 @@ allocated:
>  	    in_range(ret_block, le32_to_cpu(gdp->bg_inode_table),
>  		      EXT3_SB(sb)->s_itb_per_group) ||
>  	    in_range(ret_block + num - 1, le32_to_cpu(gdp->bg_inode_table),
> -		      EXT3_SB(sb)->s_itb_per_group))
> +		      EXT3_SB(sb)->s_itb_per_group)) {
>  		ext3_error(sb, "ext3_new_block",
>  			    "Allocating block in system zone - "
>  			    "blocks from "E3FSBLK", length %lu",
>  			     ret_block, num);
> +		goto out;
> +	}
>  
>  	performed_allocation = 1;

Are these patches in the upstream kernel yet?  I'd submitted fixes like
this for 2.4 kernels, but it never seems to make it into the kernel for
2.6...

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html