linux-fsdevel mailing list

FromSubjectsort iconDate
Christoph Hellwig
Re: [patch 1/2] VFS: new fgetattr() file operation
Not at all. Attribute operations like this have no business at all looking at the struct file. Please fix your dreaded filesystem to implement proper unix semantics intead, and if that means adding silly rename support so be it. -
Sep 24, 5:36 am 2007
Miklos Szeredi
Re: [patch 1/2] VFS: new fgetattr() file operation
I don't quite understand your suggestion. A file isn't deleted while there are still links or open files refering to it. So getting the attributes for a file with nlink==0 is perfectly valid while the file is still open. If a network filesystem protocol can't handle operations (be it data or metadata) on an unlinked file, we must do sillirenaming, so that the file is not actually unlinked. Miklos -
Sep 24, 6:06 am 2007
Miklos Szeredi
Re: [patch 1/2] VFS: new fgetattr() file operation
It's a fixed protocol, with servers installed on millions of servers. The protocol is called SFTP and the server is part of the OpenSSH package. There's nothing I can change there. And even if I could change the protocol, it's impossible to implement full UNIX semantics with a userspace server. Please think a bit about That's what is done currently. But it's has various dawbacks, like rmdir doesn't work if there are open files within an otherwise empty directory. I'd happily accept ...
Sep 24, 5:48 am 2007
Christoph Hellwig
Re: [patch 1/2] VFS: new fgetattr() file operation
Or not support such a broken protocol at all. -
Sep 24, 6:10 am 2007
Miklos Szeredi
Re: [patch 1/2] VFS: new fgetattr() file operation
Wonder what people would say if we removed support for NFSv[23]. Just because a protocol does not support "perfect" UNIX semantics, it doesn't mean it's broken. By that standard almost all network filesystem protocols are severely broken. Miklos -
Sep 24, 6:18 am 2007
Miklos Szeredi
[patch 1/2] VFS: new fgetattr() file operation
Thanks to everyone for the feedback. Here's two of the VFS patches reworked according to comments. I also plan to rework the setattr() patch accordingly and perhaps the xattr patch, altough that is the lowest priority. Christoph, are these OK with you in this form? ---- From: Miklos Szeredi <mszeredi@suse.cz> Add a new file operation: f_op->fgetattr(), that is invoked by fstat(). Fall back to i_op->getattr() if it is not defined. This is useful for filesystems such as sshfs, which ...
Sep 24, 5:24 am 2007
Miklos Szeredi
[patch 2/2] VFS: allow filesystem to override mknod capa ...
From: Miklos Szeredi <mszeredi@suse.cz> Add a new super block flag, that results in the VFS not checking if the current process has enough privileges to do an mknod(). If this flag is set, all mounts for this super block will have the "nodev" flag implied. This is needed on filesystems, where an unprivileged user may be able to create a device node, without causing security problems. One such example is "mountlo" a loopback mount utility implemented with fuse and UML, which runs as an ...
Sep 24, 5:25 am 2007
Christoph Hellwig
Re: [patch 2/2] VFS: allow filesystem to override mknod ...
This one looks okay, but I'd prefer to not put it in until we actually have proper non-privilegued mounts. -
Sep 24, 5:38 am 2007
Miklos Szeredi
Re: [patch 1/2] VFS: new fgetattr() file operation
I don't think it can. How can we find in a reliable way another directory, which is writable by the user? Miklos -
Sep 24, 6:40 am 2007
Christoph Hellwig
Re: [patch 1/2] VFS: new fgetattr() file operation
Well, they are broken by these and other standards. At least nfs and cifs maintainers do the workarounds for this brokeness where they belong. -
Sep 24, 6:27 am 2007
Miklos Szeredi
Re: [patch 1/2] VFS: new fgetattr() file operation
And my patch is not working around a problem, rather solving a problem in a correct way. Let me summarise it: There are valid reasons we have fstat() in addition to stat/lstat. For example we want to protect agains races involving unlink/rename on an open file. Say I want to implement a network filesystem with a pure unprivileged userspace sever (this is basically what sshfs does). I want my filesystem client implementation to keep all these advantages of fstat(). So how can I do ...
Sep 24, 6:38 am 2007
Matthew Wilcox
Re: [patch 1/2] VFS: new fgetattr() file operation
Only sillyrename files with nlink > 1? I don't see how attributes can change anything for a deleted file. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -
Sep 24, 5:59 am 2007
Matthew Wilcox
Re: [patch 1/2] VFS: new fgetattr() file operation
Is it? Why not just pretend that the attributes are wiped when the file Or you could call getattr right before you unlink and cache the result in the client. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -
Sep 24, 6:16 am 2007
Miklos Szeredi
Re: [patch 1/2] VFS: new fgetattr() file operation
You mean "when finally unlinked"? Delete happens when the file is The file can still be modified after being unlinked. And even if we did this caching thing and modify the attributes when the file is modified, it would not deal with access on the remote end, and would be much more complex than the other alternatives. Miklos -
Sep 24, 6:21 am 2007
Alan Cox
Re: [patch 1/2] VFS: new fgetattr() file operation
NFS has that problem because it really has to sillyrename into the same directory. I don't see that ssh/sftp needs to do that. Instead it can sillyrename anywhere in the filesystem. Alan -
Sep 24, 6:42 am 2007
Michael Halcrow
Re: [PATCH 6/11] eCryptfs: Update metadata read/write fu ...
Fix an assignment-in-an-if. Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com> --- diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c index 4bf1a95..b3795f6 100644 --- a/fs/ecryptfs/crypto.c +++ b/fs/ecryptfs/crypto.c @@ -1306,8 +1306,9 @@ ecryptfs_write_metadata_to_contents(struct ecryptfs_crypt_stat *crypt_stat, int header_pages; int rc; - if ((rc = ecryptfs_write_lower(ecryptfs_dentry->d_inode, page_virt, - 0, PAGE_CACHE_SIZE))) { + rc = ...
Sep 24, 3:40 pm 2007
Michael Halcrow
Re: [PATCH 3/11] eCryptfs: read_write.c routines
Update data types and add casts in order to avoid potential overflow issues. Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com> --- diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c index 5d27cf9..4bf1a95 100644 --- a/fs/ecryptfs/crypto.c +++ b/fs/ecryptfs/crypto.c @@ -149,7 +149,7 @@ out: * ecryptfs_derive_iv * @iv: destination for the derived iv vale * @crypt_stat: Pointer to crypt_stat struct for the current inode - * @offset: Offset of the page whose's iv we are to ...
Sep 24, 3:12 pm 2007
Soeren Sonnenburg
Re: 2.6.22.6: kernel BUG at fs/locks.c:171
OK, it is the dvb card. I have 1 week of uptime now without any errors. Soeren -
Sep 24, 1:21 pm 2007
Andrea Arcangeli
Re: [00/41] Large Blocksize Support V7 (adds memmap support)
Various apps requires you (admin/user) to tune the size of their The whole point is if there's not enough ram of course... this is why The numbers will change depending on what's running on your system. It's up to you to know plus I normally keep vmstat monitored in the background to see how the cache/free levels change over The admin should do that if he's unsure, not a program of course! -
Sep 24, 8:39 am 2007
Christoph Lameter
Re: [00/41] Large Blocksize Support V7 (adds memmap support)
Yes, there were issues with the first releases of the JBD patches. The current crop in mm is fine but much of that may have bypassed this list. -
Sep 24, 2:13 pm 2007
Kyle Moffett
Re: [00/41] Large Blocksize Support V7 (adds memmap support)
Here's an excellent example of an 0-255 numbered hilbert curve used to enumerate the various top-level allocations of IPv4 space: http://xkcd.com/195/ Cheers, Kyle Moffett -
Sep 24, 5:32 am 2007
previous daytodaynext day
September 23, 2007September 24, 2007September 25, 2007