Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs_mknod/create()

view
thread

Score:

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Dave Hansen <hansendc@...>

To: Christoph Hellwig <hch@...>

Cc: Dave Hansen <haveblue@...>, <akpm@...>, <linux-fsdevel@...>, <viro@...>

Subject: Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs_mknod/create()

Date: Monday, June 25, 2007 - 11:19 am

On Sat, 2007-06-23 at 08:51 +0100, Christoph Hellwig wrote:
quoted text> > diff -puN fs/namei.c~18-24-sys-mknodat-elevate-write-count-for-vfs-mknod-create fs/namei.c
> > --- lxc/fs/namei.c~18-24-sys-mknodat-elevate-write-count-for-vfs-mknod-create 2007-06-21 23:23:25.000000000 -0700
> > +++ lxc-dave/fs/namei.c       2007-06-21 23:23:25.000000000 -0700
> > @@ -1897,14 +1897,26 @@ asmlinkage long sys_mknodat(int dfd, con
> >       if (!IS_ERR(dentry)) {
> >               switch (mode & S_IFMT) {
> >               case 0: case S_IFREG:
> > +                     error = mnt_want_write(nd.mnt);
> > +                     if (error)
> > +                             break;
> >                       error = vfs_create(nd.dentry->d_inode,dentry,mode,&nd);
> > +                     mnt_drop_write(nd.mnt);
> >                       break;
> >               case S_IFCHR: case S_IFBLK:
> > +                     error = mnt_want_write(nd.mnt);
> > +                     if (error)
> > +                             break;
> >                       error = vfs_mknod(nd.dentry->d_inode,dentry,mode,
> >                                       new_decode_dev(dev));
> > +                     mnt_drop_write(nd.mnt);
> >                       break;
> >               case S_IFIFO: case S_IFSOCK:
> > +                     error = mnt_want_write(nd.mnt);
> > +                     if (error)
> > +                             break;
> >                       error = vfs_mknod(nd.dentry->d_inode,dentry,mode,0);
> > +                     mnt_drop_write(nd.mnt);
> >                       break;
> >               case S_IFDIR:
> >                       error = -EPERM;
> 
> Should we just take the calls outside the switch statement? 

Yeah, that's much better.  I assume we don't care whether we're getting
-EROFS or -EPERM/-EINVAL for the S_IFDIR and default cases?

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/26] Mount writer count and read-only bind mounts, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 00/26] Mount writer count and read-only bind mounts, Andrew Morton, (Sat Jun 23, 12:52 pm)

Re: [PATCH 00/26] Mount writer count and read-only bind mounts, Christoph Hellwig, (Sat Jun 30, 5:57 am)

Re: [PATCH 00/26] Mount writer count and read-only bind mounts, Dave Hansen, (Mon Jun 25, 11:45 am)

[PATCH 14/26] elevate write count for file_update_time(), Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 14/26] elevate write count for file_update_time(), Christoph Hellwig, (Sat Jun 23, 3:46 am)

Re: [PATCH 14/26] elevate write count for file_update_time(), Dave Hansen, (Fri Jul 6, 3:17 pm)

Re: [PATCH 14/26] elevate write count for file_update_time(), Dave Hansen, (Mon Jun 25, 2:32 pm)

Re: [PATCH 14/26] elevate write count for file_update_time(), Christoph Hellwig, (Sat Jun 30, 5:38 am)

[PATCH 17/26] elevate write count over calls to vfs_rename(), Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 17/26] elevate write count over calls to vfs_rena..., Christoph Hellwig, (Sat Jun 23, 3:49 am)

[PATCH 22/26] sys_mknodat(): elevate write count for vfs_mkn..., Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs..., Christoph Hellwig, (Sat Jun 23, 3:51 am)

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs..., Dave Hansen, (Mon Jun 25, 11:19 am)

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs..., Christoph Hellwig, (Sat Jun 30, 5:39 am)

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs..., Dave Hansen, (Thu Jul 5, 6:43 pm)

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs..., Christoph Hellwig, (Wed Jul 11, 6:22 am)

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs..., Jan Engelhardt, (Sat Jul 7, 2:25 pm)

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs..., Christoph Hellwig, (Wed Jul 11, 6:22 am)

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs..., Dave Hansen, (Mon Jul 9, 3:04 pm)

Re: [PATCH 22/26] sys_mknodat(): elevate write count for vfs..., Dave Hansen, (Mon Jul 2, 7:31 pm)

[PATCH 16/26] unix_find_other() elevate write count for touc..., Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 16/26] unix_find_other() elevate write count for ..., Christoph Hellwig, (Sat Jun 23, 3:47 am)

[PATCH 24/26] do_rmdir(): elevate write count, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 24/26] do_rmdir(): elevate write count, Christoph Hellwig, (Sat Jun 23, 3:51 am)

[PATCH 26/26] honor r/w changes at do_remount() time, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 26/26] honor r/w changes at do_remount() time, Christoph Hellwig, (Sat Jun 23, 3:51 am)

[PATCH 25/26] r/o bind mounts: scalable writer count, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 25/26] r/o bind mounts: scalable writer count, Andrew Morton, (Sat Jun 23, 12:52 pm)

Re: [PATCH 25/26] r/o bind mounts: scalable writer count, Dave Hansen, (Mon Jun 25, 11:47 am)

Re: [PATCH 25/26] r/o bind mounts: scalable writer count, Miklos Szeredi, (Sat Jun 23, 7:28 am)

Re: [PATCH 25/26] r/o bind mounts: scalable writer count, Dave Hansen, (Mon Jun 25, 11:36 am)

Re: [PATCH 25/26] r/o bind mounts: scalable writer count, Miklos Szeredi, (Mon Jun 25, 3:09 pm)

Re: [PATCH 25/26] r/o bind mounts: scalable writer count, Miklos Szeredi, (Sat Jun 23, 7:31 am)

[PATCH 21/26] elevate write count for do_sys_utime() and tou..., Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 21/26] elevate write count for do_sys_utime() and..., Christoph Hellwig, (Sat Jun 23, 3:50 am)

[PATCH 23/26] elevate mnt writers for vfs_unlink() callers, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 23/26] elevate mnt writers for vfs_unlink() callers, Christoph Hellwig, (Sat Jun 23, 3:51 am)

[PATCH 13/26] elevate mount count for extended attributes, Dave Hansen, (Fri Jun 22, 4:03 pm)

[PATCH 19/26] elevate writer count for do_sys_truncate(), Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 19/26] elevate writer count for do_sys_truncate(), Christoph Hellwig, (Sat Jun 23, 3:49 am)

[PATCH 20/26] elevate write count for do_utimes(), Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 20/26] elevate write count for do_utimes(), Christoph Hellwig, (Sat Jun 23, 3:49 am)

[PATCH 15/26] mount_is_safe(): add comment, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 15/26] mount_is_safe(): add comment, Christoph Hellwig, (Sat Jun 23, 3:47 am)

Re: [PATCH 15/26] mount_is_safe(): add comment, Dave Hansen, (Mon Jun 25, 11:10 am)

[PATCH 01/26] document nlink function, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 01/26] document nlink function, Christoph Hellwig, (Sat Jun 23, 3:36 am)

[PATCH 10/26] elevate mnt writers for callers of vfs_mkdir(), Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 10/26] elevate mnt writers for callers of vfs_mkd..., Christoph Hellwig, (Sat Jun 23, 3:45 am)

[PATCH 18/26] nfs: check mnt instead of superblock directly, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 18/26] nfs: check mnt instead of superblock direc..., Christoph Hellwig, (Sat Jun 23, 3:49 am)

[PATCH 05/26] r/o bind mounts: stub functions, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 05/26] r/o bind mounts: stub functions, Andrew Morton, (Sat Jun 23, 12:52 pm)

Re: [PATCH 05/26] r/o bind mounts: stub functions, Dave Hansen, (Mon Jun 25, 11:49 am)

Re: [PATCH 05/26] r/o bind mounts: stub functions, Christoph Hellwig, (Sat Jun 23, 3:39 am)

[PATCH 06/26] elevate write count open()'d files, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 06/26] elevate write count open()'d files, Christoph Hellwig, (Sat Jun 23, 3:40 am)

Re: [PATCH 06/26] elevate write count open()'d files, Dave Hansen, (Mon Jun 25, 11:03 am)

[PATCH 12/26] elevate write count for link and symlink calls, Dave Hansen, (Fri Jun 22, 4:03 pm)

[PATCH 11/26] elevate write count during entire ncp_ioctl(), Dave Hansen, (Fri Jun 22, 4:03 pm)

[PATCH 04/26] filesystem helpers for custom 'struct file's, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's, Andrew Morton, (Sat Jun 23, 12:52 pm)

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's, Dave Hansen, (Mon Jun 25, 11:37 am)

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's, Andrew Morton, (Mon Jun 25, 1:25 pm)

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's, Dave Hansen, (Mon Jun 25, 1:32 pm)

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's, Christoph Hellwig, (Sat Jun 30, 5:35 am)

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's, Christoph Hellwig, (Sat Jun 23, 3:38 am)

Re: [PATCH 04/26] filesystem helpers for custom 'struct file's, Dave Hansen, (Mon Jun 25, 10:53 am)

[PATCH 08/26] elevate writer count for chown and friends, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 08/26] elevate writer count for chown and friends, Christoph Hellwig, (Sat Jun 23, 3:43 am)

[PATCH 09/26] make access() use mnt check, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 09/26] make access() use mnt check, Christoph Hellwig, (Sat Jun 23, 3:45 am)

Re: [PATCH 09/26] make access() use mnt check, Dave Hansen, (Mon Jun 25, 2:27 pm)

Re: [PATCH 09/26] make access() use mnt check, Christoph Hellwig, (Sat Jun 30, 5:37 am)

Re: [PATCH 09/26] make access() use mnt check, Dave Hansen, (Mon Jul 2, 12:09 pm)

Re: [PATCH 09/26] make access() use mnt check, Dave Kleikamp, (Tue Jun 26, 3:04 pm)

[PATCH 07/26] r/o bind mounts: elevate write count for some ..., Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 07/26] r/o bind mounts: elevate write count for s..., Christoph Hellwig, (Sat Jun 23, 3:42 am)

[PATCH 03/26] ext4: remove extra IS_RDONLY() check, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 03/26] ext4: remove extra IS_RDONLY() check, Christoph Hellwig, (Sat Jun 23, 3:37 am)

[PATCH 02/26] ext3: remove extra IS_RDONLY() check, Dave Hansen, (Fri Jun 22, 4:03 pm)

Re: [PATCH 02/26] ext3: remove extra IS_RDONLY() check, Christoph Hellwig, (Sat Jun 23, 3:36 am)

Navigation

Mail archive search

Popular discussions


linux-kernel:
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Linus Torvalds	Linux 2.6.27-rc8
James Bottomley	Re: Integration of SCST in the mainstream Linux kernel
Greg KH	Linux 2.6.25.10
git:
Sverre Rabbelier	Git vs Monotone
Robert Collins	Re: VCS comparison table
Junio C Hamano	Re: git-diff on touched files: bug or feature?
Linus Torvalds	Re: [PATCH] Avoid running lstat(2) on the same cache entry.
openbsd-misc:
Steve Shockley	Re: Real men don't attack straw men
chefren	Re: [Fwd: Open-Hardware]
ropers	Re: About Xen: maybe a reiterative question but ..
Leon Dippenaar	New tcp stack attack
linux-netdev:
David Miller	Re: [GIT]: Networking
Jeff Garzik	Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
Ilpo Järvinen	Re: [bug] stuck localhost TCP connections, v2.6.26-rc3+
Sangtae Ha	Re: A Linux TCP SACK Question

Latest forum posts


Kernel Module Oops! TRICKY PROBLEM!	7 hours ago	Linux kernel
usb mic not detected	10 hours ago	Applications and Utilities
linux-2.6.10	16 hours ago	Linux kernel
How to detect usb device insertioin and removal event ?	19 hours ago	Linux general
Extended configuration Read/Write	20 hours ago	Windows
Add ext2 inode field	1 day ago	Linux kernel
the kernel how to power off the machine	1 day ago	Linux kernel
struct gendisk via request_queue	1 day ago	Linux kernel
page initialization during kernel initialization	2 days ago	Linux kernel
Read Transport Layer Data form network packets (tcp/ip)	3 days ago	Linux kernel

Show all forums...

Recent Tags

Linus Torvalds Intel -rc8 bugs 2.6.27 2.6.27-rc8 quote -rc Linux

more tags

Colocation donated by:

Online users

Syndicate