Re: [PATCH 1/17] cramfs: use read_mapping_page | KernelTrap

Re: [PATCH 1/17] cramfs: use read_mapping_page

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Roman Zippel <zippel@...>

To: Christoph Hellwig <hch@...>

Cc: Nate Diller <nate.diller@...>, Andrew Morton <akpm@...>, Alexander Viro <viro@...>, Mikulas Patocka <mikulas@...>, David Woodhouse <dwmw2@...>, Dave Kleikamp <shaggy@...>, Anton Altaparmakov <aia21@...>, Evgeniy Dushistov <dushistov@...>, <linux-kernel@...>, <linux-fsdevel@...>, <reiserfs-dev@...>

Subject: Re: [PATCH 1/17] cramfs: use read_mapping_page

Date: Thursday, April 12, 2007 - 7:26 am

Hi,

On Thu, 12 Apr 2007, Christoph Hellwig wrote:

quoted text> On Wed, Apr 11, 2007 at 07:49:38PM -0700, Nate Diller wrote:
> > read_mapping_page_async() is going away, so convert its only user to
> > read_mapping_page().  This change has not been benchmarked, however, in
> > order to get real parallelism this wants something completely different,
> > like __do_page_cache_readahead(), which is not currently exported.
> 
> Why is read_mapping_page_async going away?  This probably needs a lot more
> testing, and I'd be much happier if you split it out of the series and
> sent it separately at the end.

That function wasn't fully async anyway, as it would often sleep in 
lock_page(). AFAICT only in the special case of a partial written page 
would this function return a not yet uptodate page.

bye, Roman

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/17] fs: cleanup single page synchronous read interf..., Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 6/17] hfs: remove redundant read_mapping_page error c..., Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 14/17] reiserfs: convert reiserfs_get_page to read_km..., Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 11/17] ntfs: convert ntfs_map_page to read_kmap_page, Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 16/17] ufs: convert ufs_get_page to read_kmap_page, Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 17/17] vxfs: convert vxfs_get_page to read_kmap_page, Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 12/17] partition: remove redundant read_mapping_page ..., Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 13/17] reiser4: remove redundant read_mapping_page er..., Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 15/17] sysv: convert dir_get_page to read_kmap_page, Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 10/17] mtd: convert page_read to read_kmap_page, Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 9/17] minix: convert dir_get_page to read_kmap_page, Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 8/17] jfs: use locking read_mapping_page, Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cach..., Nate Diller, (Wed Apr 11, 10:49 pm)

Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_..., David Woodhouse, (Sun Apr 15, 6:52 am)

Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_..., Phillip Lougher, (Thu Apr 12, 7:40 am)

Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_..., Nate Diller, (Thu Apr 12, 2:29 pm)

Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_..., Phillip Lougher, (Thu Apr 12, 2:53 pm)

[PATCH 5/17] hfsplus: remove redundant read_mapping_page err..., Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_page, Nate Diller, (Wed Apr 11, 10:49 pm)

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_..., David Howells, (Thu Apr 12, 6:58 am)

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_..., Nate Diller, (Thu Apr 12, 2:23 pm)

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_..., David Howells, (Thu Apr 12, 2:57 pm)

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_..., Nate Diller, (Thu Apr 12, 3:27 pm)

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_..., David Howells, (Thu Apr 12, 3:43 pm)

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_..., Andrew Morton, (Thu Apr 12, 3:21 pm)

Re: [PATCH 3/17] afs: convert afs_dir_get_page to read_kmap_..., David Howells, (Thu Apr 12, 3:29 pm)

[PATCH 4/17] ext2: convert ext2_get_page to read_kmap_page, Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 2/17] fs: introduce new read_cache_page interface, Nate Diller, (Wed Apr 11, 10:49 pm)

[PATCH 1/17] cramfs: use read_mapping_page, Nate Diller, (Wed Apr 11, 10:49 pm)

Re: [PATCH 1/17] cramfs: use read_mapping_page, Christoph Hellwig, (Thu Apr 12, 5:54 am)

Re: [PATCH 1/17] cramfs: use read_mapping_page, Roman Zippel, (Thu Apr 12, 7:26 am)

Re: [PATCH 1/17] cramfs: use read_mapping_page, Nate Diller, (Thu Apr 12, 2:36 pm)

Navigation

Popular discussions


linux-kernel:
Jon Smirl	463 kernel developers missing!
Nigel Cunningham	Re: [PATCH] Remove process freezer from suspend to RAM pathway
Greg KH	Re: [malware-list] [RFC 0/5] [TALPA] Intro to a linux interface for on access scan...
Jeff Garzik	Re: Linux 2.6.23-rc9 and a heads-up for the 2.6.24 series..
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Linus Torvalds	Re: [GIT]: Networking
Evgeniy Polyakov	Re: [BUG] New Kernel Bugs
openbsd-misc:

Colocation donated by:

Who's online

There are currently 3 users and 867 guests online.

Online users

Syndicate