Home » Mailing list archives » linux-fsdevel » 2007 » November » 3

[PATCH 7/8] Unionfs: don't printk an error if it's due to common copyup

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Erez Zadok
Subject: [PATCH 7/8] Unionfs: don't printk an error if it's due to common copyup
Date: Friday, November 2, 2007 - 6:22 pm

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
 fs/unionfs/inode.c  |    9 +++++----
 fs/unionfs/rename.c |    2 +-
 fs/unionfs/subr.c   |    8 ++++++--
 3 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index 169365c..bcefe45 100644
--- a/fs/unionfs/inode.c
+++ b/fs/unionfs/inode.c
@@ -465,10 +465,11 @@ static int unionfs_symlink(struct inode *dir, struct dentry *dentry,
 			if (!lower_dentry || IS_ERR(lower_dentry)) {
 				if (IS_ERR(lower_dentry))
 					err = PTR_ERR(lower_dentry);
-
-				printk(KERN_ERR "unionfs: lower dentry "
-				       "NULL (or error) for bindex = %d\n",
-				       bindex);
+				if (!IS_COPYUP_ERR(err))
+					printk(KERN_ERR
+					       "unionfs: create_parents for "
+					       "symlink failed: bindex=%d "
+					       "err=%d\n", bindex, err);
 				continue;
 			}
 		}
diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c
index 1ab474f..4a35b5e 100644
--- a/fs/unionfs/rename.c
+++ b/fs/unionfs/rename.c
@@ -41,7 +41,7 @@ static int __unionfs_rename(struct inode *old_dir, struct dentry *old_dentry,
 				       bindex);
 		if (IS_ERR(lower_new_dentry)) {
 			err = PTR_ERR(lower_new_dentry);
-			if (err == -EROFS)
+			if (IS_COPYUP_ERR(err))
 				goto out;
 			printk(KERN_ERR "unionfs: error creating directory "
 			       "tree for rename, bindex=%d err=%d\n",
diff --git a/fs/unionfs/subr.c b/fs/unionfs/subr.c
index d97086a..968ee8c 100644
--- a/fs/unionfs/subr.c
+++ b/fs/unionfs/subr.c
@@ -61,8 +61,12 @@ int create_whiteout(struct dentry *dentry, int start)
 						      dentry->d_name.name,
 						      bindex);
 			if (!lower_dentry || IS_ERR(lower_dentry)) {
-				printk(KERN_ERR "unionfs: create_parents "
-				       "failed for bindex = %d\n", bindex);
+				int ret = PTR_ERR(lower_dentry);
+				if (!IS_COPYUP_ERR(ret))
+					printk(KERN_ERR
+					       "unionfs: create_parents for "
+					       "whiteout failed: bindex=%d "
+					       "err=%d\n", bindex, ret);
 				continue;
 			}
 		}
-- 
1.5.2.2

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[GIT PULL -mm] 0/8 Unionfs updates/cleanups/fixes, Erez Zadok, (Fri Nov 2, 6:22 pm)
[PATCH 1/8] Unionfs: delete whiteouts in sticky directories, Erez Zadok, (Fri Nov 2, 6:22 pm)
[PATCH 2/8] Unionfs: cleanup permission checking code, Erez Zadok, (Fri Nov 2, 6:22 pm)
[PATCH 3/8] Unionfs: update usage.txt documentation, Erez Zadok, (Fri Nov 2, 6:22 pm)
[PATCH 4/8] Unionfs: mmap updates, Erez Zadok, (Fri Nov 2, 6:22 pm)
[PATCH 5/8] Unionfs: avoid a deadlock during branch-manage ..., Erez Zadok, (Fri Nov 2, 6:22 pm)
[PATCH 6/8] Unionfs: don't bother validating inode if it h ..., Erez Zadok, (Fri Nov 2, 6:22 pm)
[PATCH 7/8] Unionfs: don't printk an error if it's due to ..., Erez Zadok, (Fri Nov 2, 6:22 pm)
[PATCH 8/8] Unionfs/VFS: no need to export 2 symbols in se ..., Erez Zadok, (Fri Nov 2, 6:22 pm)