Oops, my fault. Of course, I tested the patch, but kernel modules are disabled in my test setup, so I missed the error. Thanks for pointing that out, Zach. Enclosed to this message is a new patch, which replaces the goto-loop by the while-based one, but leaves the EXPORT_SYMBOL macro intact. Signed-off-by Dmitri Vorobiev <dmitri.vorobiev@gmail.com> --- diff --git a/fs/namespace.c b/fs/namespace.c index 0608388..410e766 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -278,19 +278,17 ...

Zach Brown

Hi list, Apparently, the following two C language constructs while (condition) { // DO HARD WORK } and repeat: if (condition) { // DO HARD WORK goto repeat; } are equivalent, but the latter one looks quite cumbersome and is not idiomatic. However, the mntput_no_expire() routine in fs/namespace.c is implemented using the goto-based approach. The patch given below replaces the goto-loop by a while-based one. Besides, it removes the export for the same routine, because there ...

That certainly looks fine. I would also replace the 'return' with This doesn't look fine. Did you test this? mntput_no_expire() is called from mntput() which is an inline function in mount.h. So lots of callers of mntput() in modules will end up trying to call mntput_no_expire() from modules. $ nm fs/fuse/fuse.ko | grep mntput_no_expire U mntput_no_expire - z -

Yes, this is mainly my fault. There was a gap of 10 months between the 3.2 release in January this year, and the latest in November. With the rate of new kernel releases this wasn't really acceptable because the January release was stuck with a patch for kernels no newer than 2.6.20. I received numerous complaints about it. Some of you may be aware that I started work at Canonical, and this left Squashfs has backwards compatibility with older versions, and it should mount all older ...