Home » Mailing list archives » linux-fsdevel » 2007 » November » 16

[PATCH] ext3,4:fdatasync should skip metadata writeout

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Hisashi Hifumi <hifumi.hisashi@...>
To: <akpm@...>, <linux-ext4@...>, <linux-fsdevel@...>
Subject: [PATCH] ext3,4:fdatasync should skip metadata writeout
Date: Thursday, November 15, 2007 - 10:47 pm

Hi.
Currently fdatasync is identical to fsync in ext3,4.
I think fdatasync should skip journal flush in data=ordered and data=writeback mode
because this syscall is not required to synchronize the metadata.

My patch as below is similar to the approach of GFS2's fsync code(gfs2_fsync).

Thanks.

Signed-off-by :Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>

diff -Nrup linux-2.6.24-rc2.org/fs/ext3/fsync.c linux-2.6.24-rc2/fs/ext3/fsync.c
--- linux-2.6.24-rc2.org/fs/ext3/fsync.c	2007-11-07 06:57:46.000000000 +0900
+++ linux-2.6.24-rc2/fs/ext3/fsync.c	2007-11-15 17:50:24.000000000 +0900
@@ -72,6 +72,9 @@ int ext3_sync_file(struct file * file, s
 		goto out;
 	}
 
+	if (datasync)
+		goto out;	
+
 	/*
 	* The VFS has written the file data.  If the inode is unaltered
 	* then we need not start a commit.
diff -Nrup linux-2.6.24-rc2.org/fs/ext4/fsync.c linux-2.6.24-rc2/fs/ext4/fsync.c
--- linux-2.6.24-rc2.org/fs/ext4/fsync.c	2007-11-07 06:57:46.000000000 +0900
+++ linux-2.6.24-rc2/fs/ext4/fsync.c	2007-11-15 17:50:54.000000000 +0900
@@ -72,6 +72,9 @@ int ext4_sync_file(struct file * file, s
 		goto out;
 	}
 
+	if (datasync)
+		goto out;
+
 	/*
 	* The VFS has written the file data.  If the inode is unaltered
 	* then we need not start a commit.
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] ext3,4:fdatasync should skip metadata writeout, Hisashi Hifumi, (Thu Nov 15, 10:47 pm)
Re: [PATCH] ext3,4:fdatasync should skip metadata writeout, Jörn, (Thu Nov 15, 11:43 pm)
Re: [PATCH] ext3,4:fdatasync should skip metadata writeout, Andrew Morton, (Thu Nov 15, 10:59 pm)
[RESEND] [PATCH] ext3,4:fdatasync should skip metadata writ..., Hisashi Hifumi, (Mon Feb 4, 6:15 am)
Re: [RESEND] [PATCH] ext3,4:fdatasync should skip metadata w..., Jan Kara, (Wed Feb 6, 12:22 pm)
Re: [RESEND] [PATCH] ext3,4:fdatasync should skip metadata ..., Hisashi Hifumi, (Thu Feb 7, 2:45 am)
Re: [PATCH] ext3,4:fdatasync should skip metadata writeout, Hisashi Hifumi, (Tue Nov 20, 3:20 am)
Re: [PATCH] ext3,4:fdatasync should skip metadata writeout, Wendy Cheng, (Thu Nov 15, 11:47 pm)
Re: [PATCH] ext3,4:fdatasync should skip metadata writeout, Andrew Morton, (Thu Nov 15, 11:53 pm)
Re: [PATCH] ext3,4:fdatasync should skip metadata writeout, Jörn, (Thu Nov 15, 11:17 pm)
Re: [PATCH] ext3,4:fdatasync should skip metadata writeout, Bryan Henderson, (Fri Nov 16, 2:12 pm)