Home » Mailing list archives » linux-fsdevel » 2007 » November » 13

[PATCH 6/9] Unionfs: debugging updates

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Erez Zadok <ezk@...>
To: <akpm@...>
Cc: <linux-kernel@...>, <linux-fsdevel@...>, <viro@...>, <hch@...>, Erez Zadok <ezk@...>
Subject: [PATCH 6/9] Unionfs: debugging updates
Date: Tuesday, November 13, 2007 - 6:10 am

Don't perform dentry+inode checks unless both are valid.

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
 fs/unionfs/debug.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c
index 0066ccd..8464fbb 100644
--- a/fs/unionfs/debug.c
+++ b/fs/unionfs/debug.c
@@ -299,7 +299,7 @@ check_inode:
 	 * be NULL.  But, check that all three are NULL: lower dentry, mnt,
 	 * and inode.
 	 */
-	if (S_ISDIR(inode->i_mode))
+	if (dstart >= 0 && dend >= 0 && S_ISDIR(inode->i_mode))
 		for (bindex = dstart+1; bindex < dend; bindex++) {
 			lower_inode = unionfs_lower_inode_idx(inode, bindex);
 			lower_dentry = unionfs_lower_dentry_idx(dentry,
-- 
1.5.2.2

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[GIT PULL -mm] 0/9 Unionfs updates/cleanups/fixes, Erez Zadok, (Tue Nov 13, 6:10 am)
[PATCH 6/9] Unionfs: debugging updates, Erez Zadok, (Tue Nov 13, 6:10 am)
[PATCH 4/9] Unionfs: writepage updates, Erez Zadok, (Tue Nov 13, 6:10 am)
[PATCH 5/9] Unionfs: clear partial read in readpage, Erez Zadok, (Tue Nov 13, 6:10 am)
[PATCH 9/9] Unionfs: move debugging checks inside locks, Erez Zadok, (Tue Nov 13, 6:10 am)
[PATCH 7/9] Unionfs: remove unnecessary lower atime updates, Erez Zadok, (Tue Nov 13, 6:10 am)
[PATCH 8/9] Unionfs: fold do_readpage into unionfs_readpage, Erez Zadok, (Tue Nov 13, 6:10 am)
[PATCH 3/9] Unionfs: update cache-coherency detection heuris..., Erez Zadok, (Tue Nov 13, 6:10 am)
[PATCH 1/9] Unionfs: flush and release updates, Erez Zadok, (Tue Nov 13, 6:10 am)
[PATCH 2/9] Unionfs: use i_size wrappers, Erez Zadok, (Tue Nov 13, 6:10 am)